From nobody Fri Nov 14 03:50:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584570268; cv=none; d=zohomail.com; s=zohoarc; b=Hl4AEwGpD4YJ0c22SQXR8hYOE2glcC6ssKZvGffNCYIe1v+nLuhaV19KJXgM3GDTCaPFLaSbNH7o2AFo6R62uNWSXF0JgeGCUyY/AVfgugxeS+rDdgWuyVLmYVouSsstGD06W92OGnymRudtQVQzGQdicbeYtyGVkaUW/zbwvIg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584570268; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=IleK/yNW4pkfiWy8U9Z+21DMP5F9ievVLSZTVwIzUvI=; b=OKe8/0muECDALbZDJbP3hoHTuldTffe/cHmrjGIBsmmephcXRxWh61iNLNJH7VRuQD0/xciiuqRHUoKJWR41xdVNjUldAaJ2Yknwc3ZTcda+Y0V7GgryA+oaZ9tosd1Xbdsu5DuNgqBJUJALLOme7SvTcfQUU+X0aU4H373202U= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584570268122329.2090304838158; Wed, 18 Mar 2020 15:24:28 -0700 (PDT) Received: from localhost ([::1]:59020 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEh6v-0002sE-Fl for importer@patchew.org; Wed, 18 Mar 2020 18:24:25 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35389) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEh5N-0002NA-7f for qemu-devel@nongnu.org; Wed, 18 Mar 2020 18:22:50 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEh5L-0007ot-Up for qemu-devel@nongnu.org; Wed, 18 Mar 2020 18:22:48 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:60562) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEh5L-0007jJ-Q3 for qemu-devel@nongnu.org; Wed, 18 Mar 2020 18:22:47 -0400 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-390-_-UgZG-_Ms--s7YwhYaGdA-1; Wed, 18 Mar 2020 18:22:44 -0400 Received: by mail-wm1-f71.google.com with SMTP id s20so149148wmj.2 for ; Wed, 18 Mar 2020 15:22:43 -0700 (PDT) Received: from localhost.localdomain (37.red-83-52-54.dynamicip.rima-tde.net. [83.52.54.37]) by smtp.gmail.com with ESMTPSA id z6sm268305wrp.95.2020.03.18.15.22.41 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 18 Mar 2020 15:22:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584570165; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=IleK/yNW4pkfiWy8U9Z+21DMP5F9ievVLSZTVwIzUvI=; b=ahcdq7xW0zN3+hDB1rMxh25/4WzZDfvQQSvO/54DZOu81kFhh904OsVFrdnu+s9SL0KvCM W0ghi9Fw1ZKUawmXlA9W46rQbOO+OC3yWiXPVjgPV0ZOM+f3jQplZJVOOHrgfP8M4Tg6u6 skJ/zGqRggFiyc5eKr/+h5EECcunhwI= X-MC-Unique: _-UgZG-_Ms--s7YwhYaGdA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=wTFvmkrYGR3nvc+p1HX4PhBtjC+SXzPdHGKE+XXOjQA=; b=CIqjwCdLCqocJfZwos3qgJlrhFGyXSq7VQEejvFD/8CAQs7Ynov2dGQ2wy+Cc1QlSJ +g82l4p+WIMBcnGRlq0pqyq0iC8BciM8Qla9hHt9WZHmOs2NzLshk+6dseQ8/SlFKX66 06IC3IthMdyWmfG/aH8UVI1q4uruTbonO2y+rMKQrWJ3LqltAsHW8TuLklV3RdelYbMA nrUm1fX9UTw8AyIVCkQq98U8Qw6myermaP4Bb8S3h7LRzNCg/zo9qEz9c1L4LBeC0sia MaSilXzIpSndnuRVPDjXMDb/ORDbfE/LKA5DiucVxZNYnKdtX4AW0ZM9XH7tMILyLAjX 1Rvg== X-Gm-Message-State: ANhLgQ3HUyuJS0PcbvXpLSK2skkjYivNI6K/txpxCDeyfzsN2XQVhCpc px7WZl5sAPVgQQPJ0SAfl1fLcdTlPOPAm17kjUS2CZ27sx2iTJ7/yxd7BjPE8hJlBUXdwoZPHFf Mz917r6qfPIwXcJ0= X-Received: by 2002:a5d:4681:: with SMTP id u1mr128508wrq.62.1584570162700; Wed, 18 Mar 2020 15:22:42 -0700 (PDT) X-Google-Smtp-Source: ADFU+vv+p8ox9R1NYWQrrTyjFFCa5YCTA3ufyA1Wci2u2mCZ1i3c+cqYCnNWzjVxEVXGGrNAyH2+ow== X-Received: by 2002:a5d:4681:: with SMTP id u1mr128493wrq.62.1584570162459; Wed, 18 Mar 2020 15:22:42 -0700 (PDT) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH-for-5.0] block: Assert BlockDriver::format_name is not NULL Date: Wed, 18 Mar 2020 23:22:35 +0100 Message-Id: <20200318222235.23856-1-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mansour Ahmadi , qemu-block@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" bdrv_do_find_format() calls strcmp() using BlockDriver::format_name as argument, which must not be NULL. Assert this field is not null when we register a block driver in bdrv_register(). Reported-by: Mansour Ahmadi Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alberto Garcia --- block.c | 1 + 1 file changed, 1 insertion(+) diff --git a/block.c b/block.c index a2542c977b..6b984dc883 100644 --- a/block.c +++ b/block.c @@ -363,6 +363,7 @@ char *bdrv_get_full_backing_filename(BlockDriverState *= bs, Error **errp) =20 void bdrv_register(BlockDriver *bdrv) { + assert(bdrv->format_name); QLIST_INSERT_HEAD(&bdrv_drivers, bdrv, list); } =20 --=20 2.21.1