From nobody Fri Nov 14 03:44:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584487685; cv=none; d=zohomail.com; s=zohoarc; b=OKx1tsM+s0LFAsXcIT8mpABscLk6fQnEW0hTub7AoJfIyU9HsXzROURK1fCqoQx5EJC8hgQSCCfhpu++037/2R5tr4Axi68xAjwvnJxGeC43SESl2V/K6kGRgBtIFlwY/o+diG+4nPVy5eHF+wO52nu8DVmvCSunHdXP08aP9Hc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584487685; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rvAt1CSPjqW2q4HvtdiK4wixwpQOtmzZV7FR/w/lqw8=; b=BUOVIaAPYVu61ajArHDt9Zqvopx81+pwCzKvgzTkta8hxU0utQdDrTKte3ww3SwsQF0dcO0nM5NkTxE17OiwTKhk+SY0xHOe9AHcI+lw/6B/75GEnQdGq9E49rHL5OEWdWHO1ZfIPf8NlNP/7gCsc2Vq6oyuDO2nM9gKDxfYBNY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584487685712786.0089165498158; Tue, 17 Mar 2020 16:28:05 -0700 (PDT) Received: from localhost ([::1]:43004 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELcy-0005j6-Li for importer@patchew.org; Tue, 17 Mar 2020 19:28:04 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53191) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELZY-0000bi-UH for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:33 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jELZX-0004mj-ND for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:32 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:48327) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jELZX-0004k5-J6 for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:31 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-102-pxbscp3kNcujnvuK9h5-SQ-1; Tue, 17 Mar 2020 19:24:27 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 364FC100550D; Tue, 17 Mar 2020 23:24:25 +0000 (UTC) Received: from probe.redhat.com (ovpn-112-191.rdu2.redhat.com [10.10.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8934760BE0; Tue, 17 Mar 2020 23:24:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584487471; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rvAt1CSPjqW2q4HvtdiK4wixwpQOtmzZV7FR/w/lqw8=; b=JlmGwgyWnE7tsIBJkMQtXFw1i/+eRgOvaa5O3MTIN7W3t8SqiiNRegV0BIB1jvcJuQz69P zwHKGyF1YbgtqJOlR2FBjs0DJzbN9Rb9OxHiNl0yMn2CkdLeexzSZhj69241k10a+rbDgs rzKzZMc6ue7/594wvfp8ViYuCNhghJo= X-MC-Unique: pxbscp3kNcujnvuK9h5-SQ-1 From: John Snow To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 08/20] via-ide: ensure that PCI_INTERRUPT_LINE is hard-wired to its default value Date: Tue, 17 Mar 2020 19:23:17 -0400 Message-Id: <20200317232329.22362-9-jsnow@redhat.com> In-Reply-To: <20200317232329.22362-1-jsnow@redhat.com> References: <20200317232329.22362-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, Helge Deller , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , John Snow , David Gibson , Kevin Wolf , Max Reitz , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland Some firmwares accidentally write to PCI_INTERRUPT_LINE on startup which has no effect on real hardware since it is hard-wired to its default value, but causes the guest OS to become confused trying to initialise IDE devices when running under QEMU. Signed-off-by: Mark Cave-Ayland Tested-by: BALATON Zoltan Signed-off-by: BALATON Zoltan Message-id: 20200313082444.2439-5-mark.cave-ayland@ilande.co.uk Signed-off-by: John Snow --- hw/ide/via.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/ide/via.c b/hw/ide/via.c index 3153be8862..8363bd4802 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -169,7 +169,7 @@ static void via_ide_realize(PCIDevice *dev, Error **err= p) =20 pci_config_set_prog_interface(pci_conf, 0x8f); /* native PCI ATA mode = */ pci_set_long(pci_conf + PCI_CAPABILITY_LIST, 0x000000c0); - dev->wmask[PCI_INTERRUPT_LINE] =3D 0xf; + dev->wmask[PCI_INTERRUPT_LINE] =3D 0; =20 memory_region_init_io(&d->data_bar[0], OBJECT(d), &pci_ide_data_le_ops, &d->bus[0], "via-ide0-data", 8); --=20 2.21.1