From nobody Fri Nov 14 03:44:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584487677; cv=none; d=zohomail.com; s=zohoarc; b=R42HFzsNjNAqLFRmsAU6T+atUgCp+P3fjB9wqSdXr6No44iGod7YLRVSWa8FVDqPYvS6kPd3FkJh3Y8Gymdcq03/3HqqERYY61IieUblnlfRgS8XDjmZ/fy9jqFaWXKwELxpYa9yyCudA1z/ybt/nZtyRXny2q7iMRFtvBRud1k= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584487677; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=FoFgopLAB+y1Kafxr406tQHOxCuRauEC8WkTDOoEQZg=; b=RvVhZqUwHo6uuEHJ1YiSVDRvKnOxpN65d7slFmVOBz1TOKxXVkQVAOZpubLqjfjGvO79LnNK1aV1aZvOR5SJRexuoEBoGG9i5zr4wASfElKC9rXlaZdx46AsfvTkCYGg02JVe38Maeu3Fs7heQTTCJEjkiPY+KAK7foc2kuSTcQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584487677883676.7379625319224; Tue, 17 Mar 2020 16:27:57 -0700 (PDT) Received: from localhost ([::1]:43000 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELcq-0005OE-Ew for importer@patchew.org; Tue, 17 Mar 2020 19:27:56 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52528) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELZA-00086v-1z for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:12 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jELZ8-0001j6-UK for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:07 -0400 Received: from us-smtp-delivery-74.mimecast.com ([216.205.24.74]:47223) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jELZ8-0001fP-NB for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:06 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-475-J8fsZo4cMUut_8bloKzKrg-1; Tue, 17 Mar 2020 19:24:03 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 5E18218A6EC1; Tue, 17 Mar 2020 23:24:01 +0000 (UTC) Received: from probe.redhat.com (ovpn-112-191.rdu2.redhat.com [10.10.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id EE9F460BE0; Tue, 17 Mar 2020 23:23:54 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584487446; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=FoFgopLAB+y1Kafxr406tQHOxCuRauEC8WkTDOoEQZg=; b=LPaibMfvJgLPct//yGPxH9zksVmaZZAa+VPOHnwRlErPYfpLpbYd6Nkx7G6YK0lIKScmvU kggPdQ6EX4T7j0mNMO/deFWV9KxG+2JpBNZIgp6C2F5atiBbY8twh4LXSumFLRfBI5KLaz fyjSizAiADjGw/0WaB8VyupSMvG8hQw= X-MC-Unique: J8fsZo4cMUut_8bloKzKrg-1 From: John Snow To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 04/20] cmd646: remove unused pci_cmd646_ide_init() function Date: Tue, 17 Mar 2020 19:23:13 -0400 Message-Id: <20200317232329.22362-5-jsnow@redhat.com> In-Reply-To: <20200317232329.22362-1-jsnow@redhat.com> References: <20200317232329.22362-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 216.205.24.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, Helge Deller , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , Richard Henderson , John Snow , David Gibson , Kevin Wolf , Max Reitz , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland Signed-off-by: Mark Cave-Ayland Reviewed-by: Richard Henderson Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-id: 20200307091313.24190-3-mark.cave-ayland@ilande.co.uk Signed-off-by: John Snow --- include/hw/ide.h | 2 -- hw/ide/cmd646.c | 12 ------------ 2 files changed, 14 deletions(-) diff --git a/include/hw/ide.h b/include/hw/ide.h index 28d8a06439..0c7080ed92 100644 --- a/include/hw/ide.h +++ b/include/hw/ide.h @@ -12,8 +12,6 @@ ISADevice *isa_ide_init(ISABus *bus, int iobase, int ioba= se2, int isairq, DriveInfo *hd0, DriveInfo *hd1); =20 /* ide-pci.c */ -void pci_cmd646_ide_init(PCIBus *bus, DriveInfo **hd_table, - int secondary_ide_enabled); PCIDevice *pci_piix3_xen_ide_init(PCIBus *bus, DriveInfo **hd_table, int d= evfn); PCIDevice *pci_piix3_ide_init(PCIBus *bus, DriveInfo **hd_table, int devfn= ); PCIDevice *pci_piix4_ide_init(PCIBus *bus, DriveInfo **hd_table, int devfn= ); diff --git a/hw/ide/cmd646.c b/hw/ide/cmd646.c index 3c4f765bd6..699f25824d 100644 --- a/hw/ide/cmd646.c +++ b/hw/ide/cmd646.c @@ -314,18 +314,6 @@ static void pci_cmd646_ide_exitfn(PCIDevice *dev) } } =20 -void pci_cmd646_ide_init(PCIBus *bus, DriveInfo **hd_table, - int secondary_ide_enabled) -{ - PCIDevice *dev; - - dev =3D pci_create(bus, -1, "cmd646-ide"); - qdev_prop_set_uint32(&dev->qdev, "secondary", secondary_ide_enabled); - qdev_init_nofail(&dev->qdev); - - pci_ide_create_devs(dev, hd_table); -} - static Property cmd646_ide_properties[] =3D { DEFINE_PROP_UINT32("secondary", PCIIDEState, secondary, 0), DEFINE_PROP_END_OF_LIST(), --=20 2.21.1