From nobody Fri Nov 14 03:44:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584487785; cv=none; d=zohomail.com; s=zohoarc; b=IuWqds+aVpiAPeRklGJaTSCyuCpjrOqkWUDQcFSX+om+nEq22qeTYxy5G2iZgmS9YapqdouIQdQVlNCu3f46XFmUGGO7Jdy86xuPgHmvEX/6x8odmPqoXKmJcY985+5kUFCPzJwMGSgqqtr4Ag5HgOU3oxEFdH7F2zQKYGj4/1Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584487785; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sKeIG4CmpLF/eu2UZ+illruMr++EhTIuEcgMzvui7tk=; b=aT9n21ne9xSQqE6HnQC6H4wV62PapQcO8xKlj/l1SD2P5XnPTU9hZZKfo21KLZ1COCjbRlBuISQOzDWw8UYX1MOaor6UBA+7ouLeSrhJeo860ZD1zIQYkh0AjUqhCgSoumgfF8kJ6rjXQl3nM1jkLjYUDN903yaNGA1TYCpLar8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584487785090430.7587071567534; Tue, 17 Mar 2020 16:29:45 -0700 (PDT) Received: from localhost ([::1]:43036 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELeZ-0000sY-U7 for importer@patchew.org; Tue, 17 Mar 2020 19:29:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:53504) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jELZo-00012B-0e for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:49 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jELZm-0006Ec-Eu for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:47 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:44212) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jELZm-0006BM-B6 for qemu-devel@nongnu.org; Tue, 17 Mar 2020 19:24:46 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-D5oAyquCOYeso2VARtF5ng-1; Tue, 17 Mar 2020 19:24:42 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 21A4C107ACC4; Tue, 17 Mar 2020 23:24:40 +0000 (UTC) Received: from probe.redhat.com (ovpn-112-191.rdu2.redhat.com [10.10.112.191]) by smtp.corp.redhat.com (Postfix) with ESMTP id 0462260BE0; Tue, 17 Mar 2020 23:24:29 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584487486; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=sKeIG4CmpLF/eu2UZ+illruMr++EhTIuEcgMzvui7tk=; b=N0tG+YncPOil/gTirYsSf/hmc2ER+KGxhS1CJndOFFN0A420C1bw7i700jfM0odloVCQ+Y b8x7hc7ZdJ8UWNSHKWVm7HUmPgCzYHHB/BoDV2/XeBwngm7v2TYS8zaT5z+B6Tro92bpZP xAAOVGETaxcZElckEW1GlWBWy2GtYhg= X-MC-Unique: D5oAyquCOYeso2VARtF5ng-1 From: John Snow To: qemu-devel@nongnu.org, Peter Maydell Subject: [PULL 10/20] via-ide: allow guests to write to PCI_CLASS_PROG Date: Tue, 17 Mar 2020 19:23:19 -0400 Message-Id: <20200317232329.22362-11-jsnow@redhat.com> In-Reply-To: <20200317232329.22362-1-jsnow@redhat.com> References: <20200317232329.22362-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Michael S. Tsirkin" , Mark Cave-Ayland , qemu-block@nongnu.org, Helge Deller , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Aleksandar Rikalo , Richard Henderson , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Artyom Tarasenko , Laurent Vivier , Thomas Huth , Eduardo Habkost , John Snow , David Gibson , Kevin Wolf , Max Reitz , qemu-ppc@nongnu.org, Aleksandar Markovic , Paolo Bonzini , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Mark Cave-Ayland MorphOS writes to PCI_CLASS_PROG during IDE initialisation to place the controller in native mode, but thinks the initialisation has failed because the native mode bits aren't set when reading the register back. Signed-off-by: Mark Cave-Ayland Tested-by: BALATON Zoltan Signed-off-by: BALATON Zoltan Message-id: 20200313082444.2439-7-mark.cave-ayland@ilande.co.uk Signed-off-by: John Snow --- hw/ide/via.c | 1 + 1 file changed, 1 insertion(+) diff --git a/hw/ide/via.c b/hw/ide/via.c index c8835de01b..3c4d474e48 100644 --- a/hw/ide/via.c +++ b/hw/ide/via.c @@ -170,6 +170,7 @@ static void via_ide_realize(PCIDevice *dev, Error **err= p) pci_config_set_prog_interface(pci_conf, 0x8a); /* legacy mode */ pci_set_long(pci_conf + PCI_CAPABILITY_LIST, 0x000000c0); dev->wmask[PCI_INTERRUPT_LINE] =3D 0; + dev->wmask[PCI_CLASS_PROG] =3D 5; =20 memory_region_init_io(&d->data_bar[0], OBJECT(d), &pci_ide_data_le_ops, &d->bus[0], "via-ide0-data", 8); --=20 2.21.1