From nobody Sun Feb 8 16:30:49 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584474723; cv=none; d=zohomail.com; s=zohoarc; b=Ac1RAvRb9xa/qe9Hqeh7gkjI0Y6eXT48DPOefj8ARyOnlJcwxQRkCY7dnZNZ5uJ9dxhKjz5bNaSMvRLR9wdyNXmq1cGn/k00xaLDkaOl4PKqvQixm7nCxEpQTcjtMfbHyBTy9iWbJyb7XZrqEwigtW2pHWBKiATKrY0f5IluCcU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584474723; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=rX4c44rhuMkGop3AxusgS1sFdsudEKDgbJvrNqbBkWs=; b=lyy5bEWRzx2GCj+VnChWPwJ5CSZU8A62vF2UxerYwV4bpjMlkwWW8CiC9paz5uwM2uWlPzeco2beVZ4NBGubGa1NMgYwB50Jx+aro+bEUPxP42cGU3DqlN7qK8pgwnEDazDgaHxh8mMYJDV6vIiWVoZo1m28KDIiVfEC1dBi9MY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584474723509511.9397727817068; Tue, 17 Mar 2020 12:52:03 -0700 (PDT) Received: from localhost ([::1]:40494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEIFu-0000KA-Al for importer@patchew.org; Tue, 17 Mar 2020 15:52:02 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34270) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEIEq-0007kI-HZ for qemu-devel@nongnu.org; Tue, 17 Mar 2020 15:50:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEIEp-0001qL-JW for qemu-devel@nongnu.org; Tue, 17 Mar 2020 15:50:56 -0400 Received: from us-smtp-delivery-74.mimecast.com ([63.128.21.74]:41161) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jEIEp-0001p0-Fh for qemu-devel@nongnu.org; Tue, 17 Mar 2020 15:50:55 -0400 Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-58-6R5yaCiDORKM5GGsExcYRg-1; Tue, 17 Mar 2020 15:50:53 -0400 Received: by mail-wr1-f70.google.com with SMTP id t10so4872713wrp.15 for ; Tue, 17 Mar 2020 12:50:53 -0700 (PDT) Received: from xz-x1.redhat.com ([2607:9880:19c0:32::2]) by smtp.gmail.com with ESMTPSA id z22sm596119wmi.1.2020.03.17.12.50.49 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 12:50:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584474655; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=rX4c44rhuMkGop3AxusgS1sFdsudEKDgbJvrNqbBkWs=; b=Gnns0oqFZ7hoRzRvgrVuwn2CnZj8UQr3Obx2n8jXc0iC1IlNQ8Vd0etADD79u8jxQh/S1b QrvkPwVtMgCuZnEYgeS7HQEPPK3vgp5RjUXfVkTdlU3e81JMT1MGz83fxFpWA0bVbG3h5W cmcsisuyQD1zCQd5EvnM+QZt46NwtRQ= X-MC-Unique: 6R5yaCiDORKM5GGsExcYRg-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=HdePRUJwnDwXnzR9QSorBgIKeVRO36+j82UD9j+Yyjs=; b=FUzD2JwJBVmW9BMjhB7QOtsN6wy3+nJBccEpXGqSDX0hrv7+fyn+vkJ/H2l87wrkzo cmcEhmRzilYsFF72aDVtgI+QDD9Sc3wkXZaN28mb41EFbWmj5JaZKKAPTonD0yzfllS3 BYuqS+unXwu/VOIfHuBDq1jD7evNE7t09pqN4Ter6jNf2Ua2uWnrGE99aLHRGf8Ga2Gx aa+d8rYWUUjwnbiCnhXPcg0t2JuhSX6yv5UPfmLjvMSZH1JV2KORx5W8Nf5gd6bvL47F iuNTuAXJNlLNPGbEbJeW3GCe1ZhRV1CMA4tGQVFK2RtBJIhYWgMKXajoX4lwHjrZRyba eHHw== X-Gm-Message-State: ANhLgQ2PxeLMg+awg5YfZRE/NBvjzEqSBNl3xTJ30fj4q0qmDEoVPSaj jdE/ZkowKbXlN+dRkHRkJPIkNeRW210j3g9ZeawmxDEEccKr1JXswOkavlUAIsOiVHW9JuJ7IFZ E7/RX6Rip0pLvvY0= X-Received: by 2002:adf:ec82:: with SMTP id z2mr724397wrn.302.1584474652093; Tue, 17 Mar 2020 12:50:52 -0700 (PDT) X-Google-Smtp-Source: ADFU+vvJGi70HBi0Xf5GQp5SQ6NguwAnJKgP9G9b/auYTiWn1NytsHjMbFFk8bzOLn5JuP+g615MNQ== X-Received: by 2002:adf:ec82:: with SMTP id z2mr724370wrn.302.1584474651780; Tue, 17 Mar 2020 12:50:51 -0700 (PDT) From: Peter Xu To: qemu-devel@nongnu.org Subject: [PATCH v3 1/5] vfio/pci: Disable INTx fast path if using split irqchip Date: Tue, 17 Mar 2020 15:50:38 -0400 Message-Id: <20200317195042.282977-2-peterx@redhat.com> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200317195042.282977-1-peterx@redhat.com> References: <20200317195042.282977-1-peterx@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 63.128.21.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , Alex Williamson , Cornelia Huck , peterx@redhat.com, Eric Auger Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" It's currently broken. Let's use the slow path to at least make it functional. Tested-by: Eric Auger Reviewed-by: Eric Auger Signed-off-by: Peter Xu Acked-by: Alex Williamson Reviewed-by: Alex Williamson --- hw/vfio/pci.c | 12 ++++++++++++ 1 file changed, 12 insertions(+) diff --git a/hw/vfio/pci.c b/hw/vfio/pci.c index 5e75a95129..98e0e0c994 100644 --- a/hw/vfio/pci.c +++ b/hw/vfio/pci.c @@ -128,6 +128,18 @@ static void vfio_intx_enable_kvm(VFIOPCIDevice *vdev, = Error **errp) return; } =20 + if (kvm_irqchip_is_split()) { + /* + * VFIO INTx is currently not working with split kernel + * irqchip for level triggered interrupts. Go the slow path + * as long as split is enabled so we can be at least + * functional (even with poor performance). + * + * TODO: Remove this after all things fixed up. + */ + return; + } + /* Get to a known interrupt state */ qemu_set_fd_handler(irqfd.fd, NULL, NULL, vdev); vfio_mask_single_irqindex(&vdev->vbasedev, VFIO_PCI_INTX_IRQ_INDEX); --=20 2.24.1