From nobody Thu Dec 18 22:21:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1584445447; cv=none; d=zohomail.com; s=zohoarc; b=J3/7LWvpYmBplgCMaqtJPggj6ODlE8dx2X3W1bauPgEzN37zaCHi+hZ+v6rnhUtkK+cBUwJ01ZWoAttMfVQxskvJpuzQ3gV0smZKcQoUi8/EPc0uoEmdLgQyaBb+KRjD4wPNrNXzFNl2MRJ9ZfHhLpH4YbfZfKP3SRx1NpnfXAw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584445447; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7QaJCv7GzRfGh0KkLLK7VCXCCrICGrOH8s1Sycp5qFA=; b=mB7ksFD+YnKBqgLOGUaQUNe71TioW3S59l1s1RO7AGGmTv/BhBYMdqtWxlkJqx55kPToApzIwFP4Fe8l+T86Y5iN08/56T4NHhKg0DnaoLeZl2WcYXNKDfIQOddpvAgEpsDfj8nYXBN2gi8rkeh9T+cVueygq3syfDpQI9D/9Y0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584445447505893.5641410923502; Tue, 17 Mar 2020 04:44:07 -0700 (PDT) Received: from localhost ([::1]:59214 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEAdi-00068b-DV for importer@patchew.org; Tue, 17 Mar 2020 07:44:06 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43616) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jEAac-0000YR-1B for qemu-devel@nongnu.org; Tue, 17 Mar 2020 07:40:55 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jEAaa-0003M4-Pk for qemu-devel@nongnu.org; Tue, 17 Mar 2020 07:40:53 -0400 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:54860) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jEAaa-0003F0-Ij for qemu-devel@nongnu.org; Tue, 17 Mar 2020 07:40:52 -0400 Received: by mail-wm1-x341.google.com with SMTP id n8so21058777wmc.4 for ; Tue, 17 Mar 2020 04:40:52 -0700 (PDT) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id a186sm3577443wmh.33.2020.03.17.04.40.50 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 17 Mar 2020 04:40:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=7QaJCv7GzRfGh0KkLLK7VCXCCrICGrOH8s1Sycp5qFA=; b=p65F/NlVIgSOkwUvLg80G0rnrKNGAqyMxUegZmTKBWOtpEb1Djb7+rBUJEc3okVMFa h5mbmNliCWWd8Ar8TXB7MonnfTe5mV9uTd97NPUmP5zop+KxLxuJENt/zR9BGFWnijQk GB5f0u09aArT+c36p4SmPR7vGxigDeynaMwP8dM7hJ7IzMgOLUqjf6+94cTR99ec1zg2 rtRlYiRqxvGx0Jkg5CePRj2/DHh5z5+yU8MqPSWnOyLOCz7w23FzXjtYxoAPtaKkBa33 V6VnIBor9lz/+mdBWL5hkDEiOBVg1BlM39toozV8EZA2uPVXDdmhDePxRP2OnyogmpE9 VA2Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=7QaJCv7GzRfGh0KkLLK7VCXCCrICGrOH8s1Sycp5qFA=; b=lxAIwQKZuc7B54PoH8C33BO8cwV0OKvaZHIgC1P50AfFMotr/ir0V3aLg/R7swNJFQ Uiu2e3oYigA2HwzK6LeNKaD+FeqFnG7VKQrF6TC9jaz1snoDtPiO3m+F7qbXf9w+IWG6 Khk87/e5D3CVOSmTYfiwnHqXT/CQ1VSjpXx8EjQCta2WIyVn5qZV0n6QTcFuCcSms6/v xVhV+hI72NPssr79GKp3CQIdiiOQ3e3Y7iYXmOia1UsO7eslJh2D0zOsLvQiRYZoDTaW Z99XMaNCFy9OSwmohWX7tGU3AqCxWCaBMhcL7jyNX17H0b/W9S6lImvdPgnLh5q/BRLY JX2w== X-Gm-Message-State: ANhLgQ2a6Gqjm+8Jt4HF7PN/qLQkxK+kylz/0Wl7X3mTQZ3lDKJNEsXI YlOmBb9brvoJF4MNvy6QttLaULeII6NgzA== X-Google-Smtp-Source: ADFU+vsTgTCjodEg+OcPg5uOds6Zxx/GV50FSGSZDeZ2EVrOqv1GNY3GGi4tCxMlkPE1vawxT//cMQ== X-Received: by 2002:a7b:cb86:: with SMTP id m6mr4811503wmi.72.1584445251089; Tue, 17 Mar 2020 04:40:51 -0700 (PDT) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 08/11] m25p80: Improve command handling for Jedec commands Date: Tue, 17 Mar 2020 11:40:36 +0000 Message-Id: <20200317114039.26914-9-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200317114039.26914-1-peter.maydell@linaro.org> References: <20200317114039.26914-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) From: Guenter Roeck When requesting JEDEC data using the JEDEC_READ command, the Linux kernel always requests 6 bytes. The current implementation only returns three bytes, and interprets the remaining three bytes as new commands. While this does not matter most of the time, it is at the very least confusing. To avoid the problem, always report up to 6 bytes of JEDEC data. Fill remaining data with 0. Signed-off-by: Guenter Roeck Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Alistair Francis Reviewed-by: C=C3=A9dric Le Goater Signed-off-by: Peter Maydell --- hw/block/m25p80.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/hw/block/m25p80.c b/hw/block/m25p80.c index 5ff8d270c4a..53bf63856f5 100644 --- a/hw/block/m25p80.c +++ b/hw/block/m25p80.c @@ -1040,8 +1040,11 @@ static void decode_new_cmd(Flash *s, uint32_t value) for (i =3D 0; i < s->pi->id_len; i++) { s->data[i] =3D s->pi->id[i]; } + for (; i < SPI_NOR_MAX_ID_LEN; i++) { + s->data[i] =3D 0; + } =20 - s->len =3D s->pi->id_len; + s->len =3D SPI_NOR_MAX_ID_LEN; s->pos =3D 0; s->state =3D STATE_READING_DATA; break; --=20 2.20.1