From nobody Thu Oct 2 03:25:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584440457; cv=none; d=zohomail.com; s=zohoarc; b=PgR2KHeAGkhHf4ObGm1IZSpG93jObZIuArYpQ3TasrjretEa6esUgKOzU67ZUO/LtNOxkL06wiuIw6+F2jfIEPrtA3/CbGFf+94d2Dz3VD5a/Kmyp+Lwc70AGKqiFsF/qKKL9MM57kWawXqqkLHnMqXc0N9APip4aN6XywdO3S8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584440457; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ezRqYmV2CPUNPe55opdkZV7ScXAVkrgxjYZP9JXJIqI=; b=lkksOFcMGxH1oD++qKYL2TKJVsbvXQeU0BCSkOsewAsaRLEWA4x1u66nRCjTrYSwjUMeop7epjW71d2vcIx/YxKID6XZep0cZq81RlSEMNKFYYaOtnpLoHUux7d7Zwjw5zQDTw+Dv83pGfr/1xWZjy4irOOSLOOroVzSiVyS61o= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584440457432934.6984718053964; Tue, 17 Mar 2020 03:20:57 -0700 (PDT) Received: from localhost ([::1]:55790 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE9LD-00056e-C6 for importer@patchew.org; Tue, 17 Mar 2020 06:20:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46826) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE96c-0002an-BW for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:51 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE96a-0000k0-MR for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:50 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:49853 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE96a-0006UO-7O; Tue, 17 Mar 2020 06:05:48 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 48hTL26Nbsz9sTZ; Tue, 17 Mar 2020 21:04:42 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1584439482; bh=bQQmdDvTIGTYx9hToVqDanlWHhCaBUAPPuQxwhbV9d4=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Szs+mtCHEuG7pJhOWVtyNcVeUiRz0W20aviFU8F21j9s/3iP6aPIMGNAaouPtlhIQ SccB+wE18iry5mn4V9a+UlrVXfm/lxWQJuwNK2FDzEBD9x8QJ8S3HlAtL6fJcohpj3 u3cxIPnQdZ3T+akLA0ZDFZx112csMId2cn1188w0= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 41/45] ppc/spapr: Allow FWNMI on TCG Date: Tue, 17 Mar 2020 21:04:19 +1100 Message-Id: <20200317100423.622643-42-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317100423.622643-1-david@gibson.dropbear.id.au> References: <20200317100423.622643-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, Nicholas Piggin , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Nicholas Piggin There should no longer be a reason to prevent TCG providing FWNMI. System Reset interrupts are generated to the guest with nmi monitor command and H_SIGNAL_SYS_RESET. Machine Checks can not be injected currently, but this could be implemented with the mce monitor cmd similarly to i386. Signed-off-by: Nicholas Piggin Message-Id: <20200316142613.121089-6-npiggin@gmail.com> Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Greg Kurz [dwg: Re-enable FWNMI in qtests, since that now works] Signed-off-by: David Gibson --- hw/ppc/spapr_caps.c | 5 +---- tests/qtest/libqos/libqos-spapr.h | 3 +-- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/hw/ppc/spapr_caps.c b/hw/ppc/spapr_caps.c index f626d769a0..679ae7959f 100644 --- a/hw/ppc/spapr_caps.c +++ b/hw/ppc/spapr_caps.c @@ -516,10 +516,7 @@ static void cap_fwnmi_apply(SpaprMachineState *spapr, = uint8_t val, return; /* Disabled by default */ } =20 - if (tcg_enabled()) { - warn_report("Firmware Assisted Non-Maskable Interrupts(FWNMI) not " - "supported in TCG"); - } else if (kvm_enabled()) { + if (kvm_enabled()) { if (kvmppc_set_fwnmi() < 0) { error_setg(errp, "Firmware Assisted Non-Maskable Interrupts(FW= NMI) " "not supported by KVM"); diff --git a/tests/qtest/libqos/libqos-spapr.h b/tests/qtest/libqos/libqos-= spapr.h index 16174dbada..49bd72d20b 100644 --- a/tests/qtest/libqos/libqos-spapr.h +++ b/tests/qtest/libqos/libqos-spapr.h @@ -12,7 +12,6 @@ void qtest_spapr_shutdown(QOSState *qs); "cap-cfpc=3Dbroken," \ "cap-sbbc=3Dbroken," \ "cap-ibs=3Dbroken," \ - "cap-ccf-assist=3Doff," \ - "cap-fwnmi=3Doff" + "cap-ccf-assist=3Doff," =20 #endif --=20 2.24.1