From nobody Thu Oct 2 03:23:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584440328; cv=none; d=zohomail.com; s=zohoarc; b=QiFII1DVCsQUKJ8GowGoYwSMFQ+S2OqreJZWWZ5+ufFULlZdOWputzOM970Q4p7TwqzurRTXCKf8L1SWUxvaxwkauLSBOdyKamYZ6cFjuJeDXQusyMQfzmrMR8CkpgSTAHGuyAHtAb/65qEb6sdEnepf37sTZaviP8rA3IzF5Ao= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584440328; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=0xQuhzFCwnU+Fb9Eg5nGeSo0kcX1uWm26jlHJoTDLKI=; b=joSpYppEuOXv2iHgHRAIeEhKn9vZlwEAvQjZA3IqpJ/DX8OS41uI7YmseEgTXjOLjWfDsiIRYlwDIzflUfHCZc+zT37nmHcS6GAZACwBapgUJZpeR4SaXvKqTcGMM/5GJvS7xEhEaTCIVegmnk1pigQS0/QSaJPIl1iqvEXtgv4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584440328062832.2008890568429; Tue, 17 Mar 2020 03:18:48 -0700 (PDT) Received: from localhost ([::1]:55746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE9J8-0000xP-VF for importer@patchew.org; Tue, 17 Mar 2020 06:18:47 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:46581) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE96V-0002Mh-Ah for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:44 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE96T-0008P1-U9 for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:43 -0400 Received: from bilbo.ozlabs.org ([2401:3900:2:1::2]:43735 helo=ozlabs.org) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE96T-0005o2-H7; Tue, 17 Mar 2020 06:05:41 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 48hTL12ZBpz9sTV; Tue, 17 Mar 2020 21:04:41 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1584439481; bh=lfwtAqakSHQ2oL/cyuePyT3lif+wTyFCZKQf8mU9yS0=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=bWg75vvtYOff8Cyx7nXTWFHze0b2yh4vu2qehCJ7Fc6kZjsW3j/Y86QzvQ3tr2CD5 ak5FrhyaTrwMLa707GrZJ8XVCGHjqbsbslYZwIZEKRtKxS4XyvcKxUTtLTbf/XJ9Y7 1HfX7KnHB6/MehZo39jQGxXscxTohlf6qQmxSOiE= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 37/45] ppc/spapr: Fix FWNMI machine check failure handling Date: Tue, 17 Mar 2020 21:04:15 +1100 Message-Id: <20200317100423.622643-38-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317100423.622643-1-david@gibson.dropbear.id.au> References: <20200317100423.622643-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, Nicholas Piggin , qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Nicholas Piggin ppc_cpu_do_system_reset delivers a system rreset interrupt to the guest, which is certainly not what is intended here. Panic the guest like other failure cases here do. Signed-off-by: Nicholas Piggin Message-Id: <20200316142613.121089-2-npiggin@gmail.com> Reviewed-by: Greg Kurz Signed-off-by: David Gibson --- hw/ppc/spapr_events.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/hw/ppc/spapr_events.c b/hw/ppc/spapr_events.c index 2afd1844e4..11303258d4 100644 --- a/hw/ppc/spapr_events.c +++ b/hw/ppc/spapr_events.c @@ -785,7 +785,6 @@ static uint32_t spapr_mce_get_elog_type(PowerPCCPU *cpu= , bool recovered, static void spapr_mce_dispatch_elog(PowerPCCPU *cpu, bool recovered) { SpaprMachineState *spapr =3D SPAPR_MACHINE(qdev_get_machine()); - CPUState *cs =3D CPU(cpu); uint64_t rtas_addr; CPUPPCState *env =3D &cpu->env; PowerPCCPUClass *pcc =3D POWERPC_CPU_GET_CLASS(cpu); @@ -823,8 +822,7 @@ static void spapr_mce_dispatch_elog(PowerPCCPU *cpu, bo= ol recovered) /* get rtas addr from fdt */ rtas_addr =3D spapr_get_rtas_addr(); if (!rtas_addr) { - /* Unable to fetch rtas_addr. Hence reset the guest */ - ppc_cpu_do_system_reset(cs); + qemu_system_guest_panicked(NULL); g_free(ext_elog); return; } --=20 2.24.1