From nobody Thu Oct 2 03:25:45 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584440253; cv=none; d=zohomail.com; s=zohoarc; b=gtO4qRTEPaUCyBayQ9iKnaqOFNjplnovowFugZAqkKe3VRaFlyP43OCtphV7pzJeNDik7TjahujeblvmxmLBEWFuRTPqwqYO1uc3n97UBELI6dT+H/qGYsM7Szs6k4BWkJKoqMlVoJbxY5kARHXNy5jboEZu2ZjHsOi3gblwdpY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584440253; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dftqvk3Uz8mWh8oiS/fZ7xvU1ekdB2VXHheCtsyKBdQ=; b=dAF+P//z7s1Z7xWD/XSVPUIY9PjcMe4eYOmbSdRcLwFjIWA2hYFT/Y8h/z7L+od+fYd6kfTtXSRyuI8mYmpaC28YDktW4MGdEzPCJTiVFVkRMMjOkusObzgaThADl8U1vso6AlcL/6iV7dNVU/5ZLRfh1GNVexvZMvODzvOTeGo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584440253951908.4504269679003; Tue, 17 Mar 2020 03:17:33 -0700 (PDT) Received: from localhost ([::1]:55730 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE9Hw-0007Jg-TK for importer@patchew.org; Tue, 17 Mar 2020 06:17:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45503) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jE95q-0001G5-AN for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jE95n-0003Xz-LT for qemu-devel@nongnu.org; Tue, 17 Mar 2020 06:05:02 -0400 Received: from ozlabs.org ([203.11.71.1]:43399) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jE95n-0002rh-8h; Tue, 17 Mar 2020 06:04:59 -0400 Received: by ozlabs.org (Postfix, from userid 1007) id 48hTKy3N2Xz9sTK; Tue, 17 Mar 2020 21:04:37 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1584439478; bh=uQp81HKqcQMQGuUZd2mCb4gRCwE3YNLsmBa2mm3EkEM=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=NQSNsgj1zL3hLBu2aLFJ65wrPf+rW0aDySYtLovErcqUZRC+rXDOqPgzfhgApBgK3 S32YRE+R2+illdIT2qpxwThF845Vb6yjVEyLuzmZ4ABAVzAraNRP5FRQvXiBPGdp5N jTFU1lPsLrAHQ0nNnUEO5I3dRdiB6836PUQe7VRA= From: David Gibson To: peter.maydell@linaro.org Subject: [PULL 24/45] hw/scsi/spapr_vscsi: Simplify a bit Date: Tue, 17 Mar 2020 21:04:02 +1100 Message-Id: <20200317100423.622643-25-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200317100423.622643-1-david@gibson.dropbear.id.au> References: <20200317100423.622643-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 203.11.71.1 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, aik@ozlabs.ru, mdroth@linux.vnet.ibm.com, qemu-devel@nongnu.org, groug@kaod.org, qemu-ppc@nongnu.org, clg@kaod.org, Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 We already have a 'iu' pointer, use it (this simplifies the next commit). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200305121253.19078-4-philmd@redhat.com> Reviewed-by: Paolo Bonzini Signed-off-by: David Gibson --- hw/scsi/spapr_vscsi.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c index 7e397ed797..3cb5a38181 100644 --- a/hw/scsi/spapr_vscsi.c +++ b/hw/scsi/spapr_vscsi.c @@ -261,9 +261,9 @@ static int vscsi_send_rsp(VSCSIState *s, vscsi_req *req, if (status) { iu->srp.rsp.sol_not =3D (sol_not & 0x04) >> 2; if (req->senselen) { - req->iu.srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; - req->iu.srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen); - memcpy(req->iu.srp.rsp.data, req->sense, req->senselen); + iu->srp.rsp.flags |=3D SRP_RSP_FLAG_SNSVALID; + iu->srp.rsp.sense_data_len =3D cpu_to_be32(req->senselen); + memcpy(iu->srp.rsp.data, req->sense, req->senselen); total_len +=3D req->senselen; } } else { --=20 2.24.1