From nobody Tue Feb 10 06:25:35 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1584382225; cv=none; d=zohomail.com; s=zohoarc; b=dp9cQKCqcLYXgm10JnSMVY496FKXDgYT+lWIvZdixygDUxQLLmoD3Pzhyy0DRbd3PaWcy3oKAtPDAMeG5ba6MXlsdnPi4XkQclH1XSU87W6rz9WE9LB1SKAHgU1MMJVVGo5GMTIu5AqOMJfLzz8k1G1aTs1W1T8zgZONcbGc3OM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584382225; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5wBDeZKmYofKOsnZiNwMAFl1gvv88UQfd1fG073rc/U=; b=AqJ+LgGsD/3DWwOw9/AskX3szy3VCNygR/mNhllMpCOemugW47LPcXKKocpfRq9N3TbMKlqV0Jwo32tfyGNO75x3j2pl4K2LI4ROd4UDbPcpdMl6Hw5I9WuNYpZlrwV19MY/26aHqIUwkyDBYgxf18Z3zJYeHvfq8GaQHiMnCYA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584382225037917.7462181918257; Mon, 16 Mar 2020 11:10:25 -0700 (PDT) Received: from localhost ([::1]:45388 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDuBz-00049h-Vj for importer@patchew.org; Mon, 16 Mar 2020 14:10:24 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45434) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDtRZ-0000z0-R0 for qemu-devel@nongnu.org; Mon, 16 Mar 2020 13:22:28 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDtRW-00015y-SV for qemu-devel@nongnu.org; Mon, 16 Mar 2020 13:22:25 -0400 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:35360) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jDtRW-00011D-Lw for qemu-devel@nongnu.org; Mon, 16 Mar 2020 13:22:22 -0400 Received: by mail-wm1-x344.google.com with SMTP id m3so18986520wmi.0 for ; Mon, 16 Mar 2020 10:22:22 -0700 (PDT) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id s131sm417588wmf.35.2020.03.16.10.22.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 16 Mar 2020 10:22:13 -0700 (PDT) Received: from zen.lan (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 3A6731FF9B; Mon, 16 Mar 2020 17:21:56 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=5wBDeZKmYofKOsnZiNwMAFl1gvv88UQfd1fG073rc/U=; b=O/ZHaq+4jqJ1zeOhhv8adHC0sTLb41OJphB8gOFfwFNIKK95KvhUhpcoZx1htTfaph 3EzpkoPgrc92HV79JPkUZe709WIGflu3o5NOD8MYgtFSuI7frK5hb0sI8tg0cN6to/GE jH8P5+JC+glZ0b52Za1WCK3Jp4NNo6erz7TTLV5rjwXE8BU0k6j3898SnN5+DLn1X4W+ rdHqYQH/aPcvPSPwzbT2f1ROyt69pU+Y0IfI1Y25I6w6NC3kIvBX7F8FL3FNLhUuXVCs MSY5WSeisnVTkBDbEV832Q2VGMLYYYvHf70kvvGWsablTuYkvKHKlYmN2D6FVNgxzZeb jLsQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=5wBDeZKmYofKOsnZiNwMAFl1gvv88UQfd1fG073rc/U=; b=BHXpytI6j7bdQK1Xewrw+CYuc3Uwzw5Zy4kH1l4O1KpMSVzNG5ft4RWmds3qmhqR+N 8+TaPodj6WU7i68IFhEw3huyaHjFFxEW2zZUfxlnYLGN4VhdAzDwKClIun/oc4cI/O86 HiKiQQawIWQSRULRpiMlh/DQT7xoWtX2UaG/ZjfUlGHZnLKTzsEJCOiM2WTEfpWt2A6V VxUB2MmprjyM2KnaujyxzBe8EXYChq1zsmckDy5dJAgwgTjD3D/w9EEHQpoIbQf5bmBN Td5MPKWfvpe/RSFJ51slai8+gCAJHh9LUVSumLzr7tYMW5yz//UiLhsni0CGLtln9KPP I8fA== X-Gm-Message-State: ANhLgQ3tU3oDuaBjh0Nw6fRDBQbKXmbSgqeTc2i+po56THJYc10V9isB xXoQ9y43gODOwZCUhaKejw0Sng== X-Google-Smtp-Source: ADFU+vtepgVND9dXrAr3lAHeZb1+zcrFt059iGnfun1ovyDggTxuhLjwSvm26r+2aJzf4HmXxKpT1Q== X-Received: by 2002:a7b:c5cd:: with SMTP id n13mr156570wmk.172.1584379341542; Mon, 16 Mar 2020 10:22:21 -0700 (PDT) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 12/28] target/m68k: use gdb_get_reg helpers Date: Mon, 16 Mar 2020 17:21:39 +0000 Message-Id: <20200316172155.971-13-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200316172155.971-1-alex.bennee@linaro.org> References: <20200316172155.971-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Richard Henderson , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) This is cleaner than poking memory directly and will make later clean-ups easier. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Richard Henderson Reviewed-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- v3 - fix mem_buf references - fix mem_buf + len cases --- target/m68k/helper.c | 29 +++++++++++------------------ 1 file changed, 11 insertions(+), 18 deletions(-) diff --git a/target/m68k/helper.c b/target/m68k/helper.c index baf7729af00..c23b70f854d 100644 --- a/target/m68k/helper.c +++ b/target/m68k/helper.c @@ -72,19 +72,15 @@ static int cf_fpu_gdb_get_reg(CPUM68KState *env, uint8_= t *mem_buf, int n) { if (n < 8) { float_status s; - stfq_p(mem_buf, floatx80_to_float64(env->fregs[n].d, &s)); - return 8; + return gdb_get_reg64(mem_buf, floatx80_to_float64(env->fregs[n].d,= &s)); } switch (n) { case 8: /* fpcontrol */ - stl_be_p(mem_buf, env->fpcr); - return 4; + return gdb_get_reg32(mem_buf, env->fpcr); case 9: /* fpstatus */ - stl_be_p(mem_buf, env->fpsr); - return 4; + return gdb_get_reg32(mem_buf, env->fpsr); case 10: /* fpiar, not implemented */ - memset(mem_buf, 0, 4); - return 4; + return gdb_get_reg32(mem_buf, 0); } return 0; } @@ -112,21 +108,18 @@ static int cf_fpu_gdb_set_reg(CPUM68KState *env, uint= 8_t *mem_buf, int n) static int m68k_fpu_gdb_get_reg(CPUM68KState *env, uint8_t *mem_buf, int n) { if (n < 8) { - stw_be_p(mem_buf, env->fregs[n].l.upper); - memset(mem_buf + 2, 0, 2); - stq_be_p(mem_buf + 4, env->fregs[n].l.lower); - return 12; + int len =3D gdb_get_reg16(mem_buf, env->fregs[n].l.upper); + len +=3D gdb_get_reg16(mem_buf + len, 0); + len +=3D gdb_get_reg64(mem_buf + len, env->fregs[n].l.lower); + return len; } switch (n) { case 8: /* fpcontrol */ - stl_be_p(mem_buf, env->fpcr); - return 4; + return gdb_get_reg32(mem_buf, env->fpcr); case 9: /* fpstatus */ - stl_be_p(mem_buf, env->fpsr); - return 4; + return gdb_get_reg32(mem_buf, env->fpsr); case 10: /* fpiar, not implemented */ - memset(mem_buf, 0, 4); - return 4; + return gdb_get_reg32(mem_buf, 0); } return 0; } --=20 2.20.1