From nobody Mon Feb 9 13:38:20 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584378213; cv=none; d=zohomail.com; s=zohoarc; b=iJXeCTT4mJbOMM2hiARNiJc0u4mJo2xVN724ra6MrHVjHGJuQ/wvS/htgDS3ysxjcaBxkkJdGJJzxJfUhG+c4FNpiwEM4dL14Kob6CLiBLdDqUj86aF3l1gKH0po3Ry44CrmI9A7OVwiFkWrenrCeK7xLKJyWW/eBhIKLkBpJ4w= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584378213; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=cvHfXY5BFsQzf+6v3otQNJw9+eNc0vboR9t9t2vn2dw=; b=fxY0lGoSbXA+uw4YFlEMYj3vAt0GNOAkYd30O4GdVIrEX/p1hsiorAISeyH4YybounywHFPELSZz9Ui6SJDFRoheer0IMJF7QvMOQWoYer3xrX2OlTsQtdiR+hh2sDBioKu1lZ6T2B49KKO7HM44aiXCtiu3+aCMylmu4kRgWrs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584378213484984.3648564499267; Mon, 16 Mar 2020 10:03:33 -0700 (PDT) Received: from localhost ([::1]:43042 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDt9I-0008Cj-DG for importer@patchew.org; Mon, 16 Mar 2020 13:03:32 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54802) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDqle-0000dv-Ru for qemu-devel@nongnu.org; Mon, 16 Mar 2020 10:31:00 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDqlZ-00074F-Nv for qemu-devel@nongnu.org; Mon, 16 Mar 2020 10:30:58 -0400 Received: from charlie.dont.surf ([128.199.63.193]:48846) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDqlT-00045U-Tz; Mon, 16 Mar 2020 10:30:48 -0400 Received: from apples.local (80-62-117-52-mobile.dk.customer.tdc.net [80.62.117.52]) by charlie.dont.surf (Postfix) with ESMTPSA id A498DBFAC0; Mon, 16 Mar 2020 14:29:56 +0000 (UTC) From: Klaus Jensen To: qemu-block@nongnu.org Subject: [PATCH v6 42/42] nvme: make lba data size configurable Date: Mon, 16 Mar 2020 07:29:28 -0700 Message-Id: <20200316142928.153431-43-its@irrelevant.dk> X-Mailer: git-send-email 2.25.1 In-Reply-To: <20200316142928.153431-1-its@irrelevant.dk> References: <20200316142928.153431-1-its@irrelevant.dk> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 128.199.63.193 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Beata Michalska , qemu-devel@nongnu.org, Max Reitz , Klaus Jensen , Keith Busch , Javier Gonzalez , Maxim Levitsky Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Klaus Jensen Signed-off-by: Klaus Jensen Acked-by: Keith Busch Reviewed-by: Maxim Levitsky --- hw/block/nvme-ns.c | 7 ++++++- hw/block/nvme-ns.h | 4 +++- hw/block/nvme.c | 1 + 3 files changed, 10 insertions(+), 2 deletions(-) diff --git a/hw/block/nvme-ns.c b/hw/block/nvme-ns.c index 6d975104171d..d7e5c81c5f16 100644 --- a/hw/block/nvme-ns.c +++ b/hw/block/nvme-ns.c @@ -18,7 +18,7 @@ static int nvme_ns_init(NvmeNamespace *ns) { NvmeIdNs *id_ns =3D &ns->id_ns; =20 - id_ns->lbaf[0].ds =3D BDRV_SECTOR_BITS; + id_ns->lbaf[0].ds =3D ns->params.lbads; id_ns->nsze =3D cpu_to_le64(nvme_ns_nlbas(ns)); =20 /* no thin provisioning */ @@ -78,6 +78,11 @@ static int nvme_ns_check_constraints(NvmeNamespace *ns, = Error **errp) return 1; } =20 + if (ns->params.lbads < 9 || ns->params.lbads > 12) { + error_setg(errp, "unsupported lbads (supported: 9-12)"); + return 1; + } + return 0; } =20 diff --git a/hw/block/nvme-ns.h b/hw/block/nvme-ns.h index 3c3651d485d0..43b78f8b8d9c 100644 --- a/hw/block/nvme-ns.h +++ b/hw/block/nvme-ns.h @@ -7,10 +7,12 @@ =20 #define DEFINE_NVME_NS_PROPERTIES(_state, _props) \ DEFINE_PROP_DRIVE("drive", _state, blk), \ - DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0) + DEFINE_PROP_UINT32("nsid", _state, _props.nsid, 0), \ + DEFINE_PROP_UINT8("lbads", _state, _props.lbads, BDRV_SECTOR_BITS) =20 typedef struct NvmeNamespaceParams { uint32_t nsid; + uint8_t lbads; } NvmeNamespaceParams; =20 typedef struct NvmeNamespace { diff --git a/hw/block/nvme.c b/hw/block/nvme.c index 4f1504fc00fe..61a9da970d41 100644 --- a/hw/block/nvme.c +++ b/hw/block/nvme.c @@ -2624,6 +2624,7 @@ static void nvme_realize(PCIDevice *pci_dev, Error **= errp) if (n->namespace.blk) { ns =3D &n->namespace; ns->params.nsid =3D 1; + ns->params.lbads =3D BDRV_SECTOR_BITS; =20 if (nvme_ns_setup(n, ns, errp)) { return; --=20 2.25.1