From nobody Sun May 5 03:25:39 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1584367341; cv=none; d=zohomail.com; s=zohoarc; b=HyS4lf1OF/y/18A+pqFvGLtenCd/rOSk5xf1MYGMA2yVKO4silrsYbK48v6uKCHHu82gQGN8t/pc0GMcySwPvamaUpJzP5idCUxdX76qE2Gn2tcnYACJ0qHyr95AEpRzAfkVntqNJaC9I8LleQIuaNmO6k9vZ3JwYv97Fe36O3Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584367341; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=ReZQJWcnA6vBF7ZqTDr4kwx19RG8syAyKejIDYPf+yc=; b=Vax2G9o3nxuVqbod3KzcmOeAQE0eNRDz23/L1rK1a0EZf1S+inHClI2aAGqf6clJoHlPxNMne3kM/9qGS1nFhnC9g6Ev+LvOItQOHrYBAizRYMPnsZuOzmJROp3Vvr1BmsSV88J3smURWOfGNjoHeJiZvzVPrUp5GbG9AnmQOTI= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584367341597289.261628954202; Mon, 16 Mar 2020 07:02:21 -0700 (PDT) Received: from localhost ([::1]:38744 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDqJu-0005pb-7I for importer@patchew.org; Mon, 16 Mar 2020 10:02:18 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40005) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDobm-0000Uq-7P for qemu-devel@nongnu.org; Mon, 16 Mar 2020 08:12:39 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDobk-0007kv-Hd for qemu-devel@nongnu.org; Mon, 16 Mar 2020 08:12:37 -0400 Received: from aserp2120.oracle.com ([141.146.126.78]:46460) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDobk-00077w-6R for qemu-devel@nongnu.org; Mon, 16 Mar 2020 08:12:36 -0400 Received: from pps.filterd (aserp2120.oracle.com [127.0.0.1]) by aserp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02GC8iX7066974; Mon, 16 Mar 2020 12:12:22 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by aserp2120.oracle.com with ESMTP id 2yrq7kpg4m-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 12:12:21 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02GC8LSx041307; Mon, 16 Mar 2020 12:12:21 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2ys8yvp776-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 16 Mar 2020 12:12:21 +0000 Received: from abhmp0007.oracle.com (abhmp0007.oracle.com [141.146.116.13]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02GCCJax026561; Mon, 16 Mar 2020 12:12:19 GMT Received: from spark.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Mon, 16 Mar 2020 05:12:18 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=ReZQJWcnA6vBF7ZqTDr4kwx19RG8syAyKejIDYPf+yc=; b=WkfX1AtKu/QKWuTFWYhVxJ5nZEQC4CdY/mjMZ6k1mhaBuinnsTseiuDxMYifhj5OXqgd Ufki093hNJRlkLjFIN3qWl2clgLjKTJiHLq9pLQxJHKPi72Jo9v3SWNJDrPFvj8bX550 zecuAK2nYjY6JbEdTrN63CWZwfka2sblYMY+7b6e1KCoFhpFvj3cAPU2ShTYgkfo46YA 5VmXjoJEfTMZojIcvMR+w0S0W82lSpGEquMN4Ddfp6ER1idvxpxgJbV52fITln3Xwsah pyQtyYtmo3M78JQIpJF1umDv7QWgqIZ9Yy5gX8K8bU15Vs5BlCpVCrRwApzzAUndHuUm Cg== From: Liran Alon To: qemu-devel@nongnu.org Subject: [PATCH v2] hw/scsi/vmw_pvscsi: Remove assertion for kick after reset Date: Mon, 16 Mar 2020 14:14:28 +0200 Message-Id: <20200316121428.48723-1-liran.alon@oracle.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9561 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 phishscore=0 mlxlogscore=999 mlxscore=0 adultscore=0 bulkscore=0 malwarescore=0 spamscore=0 suspectscore=1 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160061 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9561 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 lowpriorityscore=0 suspectscore=1 adultscore=0 bulkscore=0 mlxlogscore=999 priorityscore=1501 clxscore=1015 malwarescore=0 mlxscore=0 phishscore=0 impostorscore=0 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2003020000 definitions=main-2003160061 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 141.146.126.78 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: fam@euphon.net, pbonzini@redhat.com, dmitry.fleytman@gmail.com, liran.alon@oracle.com, elazar@vastdata.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Elazar Leibovich When running Ubuntu 3.13.0-65-generic guest, QEMU sometimes crashes during guest ACPI reset. It crashes on assert(s->rings_info_valid) in pvscsi_process_io(). Analyzing the crash revealed that it happens when userspace issues a sync during a reboot syscall. Below are backtraces we gathered from the guests. Guest backtrace when issuing PVSCSI_CMD_ADAPTER_RESET: pci_device_shutdown device_shutdown init_pid_ns init_pid_ns kernel_power_off SYSC_reboot Guest backtrace when issuing PVSCSI_REG_OFFSET_KICK_RW_IO: scsi_done scsi_dispatch_cmd blk_add_timer scsi_request_fn elv_rb_add __blk_run_queue queue_unplugged blk_flush_plug_list blk_finish_plug ext4_writepages set_next_entity do_writepages __filemap_fdatawrite_range filemap_write_and_wait_range ext4_sync_file ext4_sync_file do_fsync sys_fsync Since QEMU pvscsi should imitate VMware pvscsi device emulation, we decided to imitate VMware's behavior in this case. To check VMware behavior, we wrote a kernel module that issues a reset to the pvscsi device and then issues a kick. We ran it on VMware ESXi 6.5 and it seems that it simply ignores the kick. Hence, we decided to ignore the kick as well. Signed-off-by: Elazar Leibovich Signed-off-by: Liran Alon --- hw/scsi/vmw_pvscsi.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/scsi/vmw_pvscsi.c b/hw/scsi/vmw_pvscsi.c index c91352cf46de..2491f204ddd7 100644 --- a/hw/scsi/vmw_pvscsi.c +++ b/hw/scsi/vmw_pvscsi.c @@ -29,6 +29,7 @@ #include "qapi/error.h" #include "qemu/main-loop.h" #include "qemu/module.h" +#include "qemu/log.h" #include "hw/scsi/scsi.h" #include "migration/vmstate.h" #include "scsi/constants.h" @@ -719,7 +720,12 @@ pvscsi_process_io(PVSCSIState *s) PVSCSIRingReqDesc descr; hwaddr next_descr_pa; =20 - assert(s->rings_info_valid); + if (!s->rings_info_valid) { + qemu_log("WARNING: PVSCSI: Cannot process I/O when " + "rings are not valid.\n"); + return; + } + while ((next_descr_pa =3D pvscsi_ring_pop_req_descr(&s->rings)) !=3D 0= ) { =20 /* Only read after production index verification */ --=20 2.20.1