From nobody Mon Feb 9 04:31:57 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1584283794; cv=none; d=zohomail.com; s=zohoarc; b=RN65s+QGcRtroRNJZSN/N85inyYFMAKfk2ktcmBxRehdeE2nMTE4Ob7IjextFM304o4d/3ZVcaO6YUoWsz5l/RFX/Je3P/e73g2HLuLKdSA+sj+XNDu54Ij6putGL+2bLtGDY+67om1zeSG+6dvGHDwap1c6JvLvEcaBLv2a26U= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584283794; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=MOc7HeT+1s334JGeFcRwNRegWa0ts+HD+BGwpDGZNUc=; b=azHF20M5WLgz85DTwLnxV5xO+kPSTleF/Z6ULKXHxJ/p2zRXlbQFO7UNRjGlZ2WxQzmfqaub5y1+fxVsayznaVLAK7FDtawSZnzYYVNPA8lOFgrWLHByhxh84WPi/h9xQOu/32aDE9oLdEiUFgloG4lQBsPba/Pifl17lN0xcoY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584283794073852.0501185931978; Sun, 15 Mar 2020 07:49:54 -0700 (PDT) Received: from localhost ([::1]:54754 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDUaO-0007R3-Nu for importer@patchew.org; Sun, 15 Mar 2020 10:49:52 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:40350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jDUXf-0005XD-Bl for qemu-devel@nongnu.org; Sun, 15 Mar 2020 10:47:06 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jDUXd-0002Is-Ic for qemu-devel@nongnu.org; Sun, 15 Mar 2020 10:47:03 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:43605 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jDUXd-0002Gt-Au for qemu-devel@nongnu.org; Sun, 15 Mar 2020 10:47:01 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-123-6hTS8qH5OKice4sTnWS0zg-1; Sun, 15 Mar 2020 10:46:59 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 562D813F7; Sun, 15 Mar 2020 14:46:58 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-49.ams2.redhat.com [10.36.116.49]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 26F8692D41; Sun, 15 Mar 2020 14:46:58 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id C26DE1135234; Sun, 15 Mar 2020 15:46:53 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1584283620; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=MOc7HeT+1s334JGeFcRwNRegWa0ts+HD+BGwpDGZNUc=; b=hpqnt1aTi8lBrYOhZsiOBrKJ1DY+siPDXqEXN76IhJLcTFPLYePgqANdmsn9+ih5tyyVwG JfNjnJp73i91JnVsOdJ8oVzCj/cb/laepNB8dS0rm+ojGCqoEVHwX50a35UbRLLe4WI/xk vxebc7e7g5ibHdBhJO+Epdtz1JQ356c= X-MC-Unique: 6hTS8qH5OKice4sTnWS0zg-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v3 24/34] qapi: Replace qmp_dispatch()'s TODO comment by an explanation Date: Sun, 15 Mar 2020 15:46:43 +0100 Message-Id: <20200315144653.22660-25-armbru@redhat.com> In-Reply-To: <20200315144653.22660-1-armbru@redhat.com> References: <20200315144653.22660-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster --- qapi/qmp-dispatch.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/qapi/qmp-dispatch.c b/qapi/qmp-dispatch.c index 112d29a9ab..fb53687ce9 100644 --- a/qapi/qmp-dispatch.c +++ b/qapi/qmp-dispatch.c @@ -164,7 +164,11 @@ QDict *qmp_dispatch(QmpCommandList *cmds, QObject *req= uest, g_assert(!ret); return NULL; } else if (!ret) { - /* TODO turn into assertion */ + /* + * When the command's schema has no 'returns', cmd->fn() + * leaves @ret null. The QMP spec calls for an the empty + * object then; supply it. + */ ret =3D QOBJECT(qdict_new()); } =20 --=20 2.21.1