From nobody Mon May 6 02:38:01 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584069887; cv=none; d=zohomail.com; s=zohoarc; b=HxS/u50S+eGGKrEs/rM8krBhaNYYmP00/lbPdtNtmFCSzP462WyKH0o8gze13Ji33xkBGODKdB+nhXGy5SaPBMXveRdbGF7afpEuq0tIObuLzUJPq7f9z6KUmIypXPfMMQOwecmKl5FnMX68368D0i/amJEl1YMDDU1Eo/TQbLE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584069887; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=TSF8kmJ7jp4SpDe2H5ig8RexISQ5z1tTK08Oq9nmP9Y=; b=iCdqzHRdKlnwOYp31L78nlDsxOxTKhyiwEIYLvz+FO/3kBbWKlizIErZPWD3tTGxcmt7pVASEPklFmejZ7hKctxdOxhsGt5VYmOfmrO3YQ2YgfeABMyDtygv4SEZvI6jgToA7C/BpDJj0o+xaZHDOzh4aeT2faHiMdg9l9hOUuE= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584069887231555.408971542985; Thu, 12 Mar 2020 20:24:47 -0700 (PDT) Received: from localhost ([::1]:53212 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCawH-0005Ty-Ir for importer@patchew.org; Thu, 12 Mar 2020 23:24:45 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:35933) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCavU-0004dt-2n for qemu-devel@nongnu.org; Thu, 12 Mar 2020 23:23:57 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCavS-0000mf-Qx for qemu-devel@nongnu.org; Thu, 12 Mar 2020 23:23:55 -0400 Received: from szxga05-in.huawei.com ([45.249.212.191]:3282 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCavS-0000cs-Fa; Thu, 12 Mar 2020 23:23:54 -0400 Received: from DGGEMS413-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A2495D93C612C1A163E7; Fri, 13 Mar 2020 11:23:47 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS413-HUB.china.huawei.com (10.3.19.213) with Microsoft SMTP Server id 14.3.487.0; Fri, 13 Mar 2020 11:23:39 +0800 From: Chen Qun To: , Subject: [PATCH v3] hw/net/imx_fec: write TGSR and TCSR3 in imx_enet_write() Date: Fri, 13 Mar 2020 11:23:27 +0800 Message-ID: <20200313032327.7008-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , zhang.zhanghailiang@huawei.com, Jason Wang , Peter Chubb , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The current code causes clang static code analyzer generate warning: hw/net/imx_fec.c:858:9: warning: Value stored to 'value' is never read value =3D value & 0x0000000f; ^ ~~~~~~~~~~~~~~~~~~ hw/net/imx_fec.c:864:9: warning: Value stored to 'value' is never read value =3D value & 0x000000fd; ^ ~~~~~~~~~~~~~~~~~~ According to the definition of the function, the two =E2=80=9Cvalue=E2=80= =9D assignments should be written to registers. Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Peter Maydell Cc: Jason Wang Cc: Peter Chubb v1->v2: The register 'ENET_TGSR' write-1-to-clear timer flag. The register 'ENET_TCSRn' 7bit(TF) write-1-to-clear timer flag. v2->v3: Optimize code style, based on discussions with Peter. --- hw/net/imx_fec.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/hw/net/imx_fec.c b/hw/net/imx_fec.c index 6a124a154a..3547975710 100644 --- a/hw/net/imx_fec.c +++ b/hw/net/imx_fec.c @@ -854,14 +854,17 @@ static void imx_enet_write(IMXFECState *s, uint32_t i= ndex, uint32_t value) s->regs[index] =3D value & 0x00007f7f; break; case ENET_TGSR: - /* implement clear timer flag */ - value =3D value & 0x0000000f; + /* implement clear timer flag, 0-3 bits W1C, reserved bits write z= ero */ + s->regs[index] &=3D ~(value & 0x0000000f) & 0x0000000f; break; case ENET_TCSR0: case ENET_TCSR1: case ENET_TCSR2: case ENET_TCSR3: - value =3D value & 0x000000fd; + /* 7 bits W1C, reserved bits write zero */ + s->regs[index] &=3D ~(value & 0x00000080) & 0x000000ff; + s->regs[index] &=3D ~0x0000007d; /* writable fields */ + s->regs[index] |=3D (value & 0x0000007d); break; case ENET_TCCR0: case ENET_TCCR1: --=20 2.23.0