From nobody Tue Sep 23 21:36:16 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1584043385; cv=none; d=zohomail.com; s=zohoarc; b=FN92/YGS+ca614jOYAK5cbI1qEPdaFf4GZDLPzIjDvxbakwPgrWB8jk22Lwt/b1NsSaJsZ//YyDu1govftFPFYcobVPCGOKxQJH0aB3pQP1OC7lFB6cBUWHX8VrQfM2im3SJFQWJ0ItkGnppVvOxUQs2QOXxN+SEJI9WsbnflhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584043385; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=IBVWDMhA5xeJ1t7FkiUhAVEPTJaDqFXyx+BzGGFHx9I=; b=jTicKUDSbwU4cIcu9HQEDUiRWkljUg5odCRvsnR1yxB2xeY8s9GWbscCwECepE0Bu5T8H4cikhfW0u6aFVW9bnKXdP/QVwzHUpaoSACUDZupu46GlnxOq9TzRPDs93jAqhWfZmpXuj8Vr9KzMBBhagUguf3bMyFYOOikvnKj5GQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584043385151868.6427081518669; Thu, 12 Mar 2020 13:03:05 -0700 (PDT) Received: from localhost ([::1]:49820 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCU2p-0005Iq-OW for importer@patchew.org; Thu, 12 Mar 2020 16:03:03 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:45675) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCTjN-0005ve-OK for qemu-devel@nongnu.org; Thu, 12 Mar 2020 15:42:59 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCTjM-0002EP-7Q for qemu-devel@nongnu.org; Thu, 12 Mar 2020 15:42:57 -0400 Received: from mail-pf1-x442.google.com ([2607:f8b0:4864:20::442]:35309) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCTjM-0002Dp-1a for qemu-devel@nongnu.org; Thu, 12 Mar 2020 15:42:56 -0400 Received: by mail-pf1-x442.google.com with SMTP id u68so3775781pfb.2 for ; Thu, 12 Mar 2020 12:42:55 -0700 (PDT) Received: from localhost.localdomain (97-126-123-70.tukw.qwest.net. [97.126.123.70]) by smtp.gmail.com with ESMTPSA id g69sm6824842pje.34.2020.03.12.12.42.53 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 12 Mar 2020 12:42:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=IBVWDMhA5xeJ1t7FkiUhAVEPTJaDqFXyx+BzGGFHx9I=; b=olQOyDIEpo8WpX+r6UIJkPkICFM81UI0Af/iwDADKEXhFQAB0qPQ8yQLLgpnrvd0SP p9F9UmICF/fH+5rjoTcMjMYf5W8kulrmCuUeB6fVsBMyWa6e/rCsHiMyxfisVaxxW6kO LhSrWqeVjCMtuPt4lnPZxHbIPbW2RPMP5KGatX2K8dM8g0LCmIL/varkKvUA38wI6flf DwSpHOtAg/uLeecTCFmN9bNdpTQ8HIMQRRVc7WY59SI1NzGfFPk5PiZSuMBxtuF2vfAd MaTDabYjJX1FOio0CfUoTIpWu0oVPxzDpo+ZB4fscjMKMgG/1QIqSPKZkBeExBuCZ1k1 jOaQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=IBVWDMhA5xeJ1t7FkiUhAVEPTJaDqFXyx+BzGGFHx9I=; b=Z7Wz6RZGJ0Vh3yU5ih+b5nUjeSEfc2h0Tyu0r4ter0U8ZwXuuxtmFbIDc8DC4UB/4s bIPskaHRiukrSj97dAgsF8OU49SrZMq7/twBuqlHTCSPWXiLpBVRh6e2dcrqdNH0Ku+F JjEQPai7JmyZqTBF+G5uy/TnjjPw5R7siZrNdJPfEDlfIg+4kocL4ed8wYprUV7KSNmf 3z5KkhUdDMLGBHt3qA7W1+JTFFmlpb8OFCLwBC0uhIXqbVVV+BFNgn0R03yw5ihW9rFt tHkORT5ezVxf5R6TbJo90zeBsvQdroVrW7UGfXlsex8J1Vjq6SllThJ9BTmt5BeEiXBk axJg== X-Gm-Message-State: ANhLgQ32brVchYYID/kJN2t91khCKqi4cZl0p02976mn4G6nvW88TIJi +1jdYH3NY0AiveEhPXuc073LCHoAhkc= X-Google-Smtp-Source: ADFU+vsSW7bbPsLeiXqGzSw/FDnq6/ElQr5bLrccigvzc++Z332ucscmTP6Fn2jnKl20Ml/QMhCakw== X-Received: by 2002:a65:6416:: with SMTP id a22mr9888215pgv.268.1584042174648; Thu, 12 Mar 2020 12:42:54 -0700 (PDT) From: Richard Henderson To: qemu-devel@nongnu.org Subject: [PATCH v6 25/42] target/arm: Implement helper_mte_check1 Date: Thu, 12 Mar 2020 12:42:02 -0700 Message-Id: <20200312194219.24406-26-richard.henderson@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200312194219.24406-1-richard.henderson@linaro.org> References: <20200312194219.24406-1-richard.henderson@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, alex.bennee@linaro.org Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" Fill out the stub that was added earlier. Signed-off-by: Richard Henderson --- target/arm/internals.h | 47 +++++++++++++++ target/arm/mte_helper.c | 126 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 172 insertions(+), 1 deletion(-) diff --git a/target/arm/internals.h b/target/arm/internals.h index a993e8ca0a..8bbaf9b453 100644 --- a/target/arm/internals.h +++ b/target/arm/internals.h @@ -1314,6 +1314,9 @@ FIELD(MTEDESC, WRITE, 8, 1) FIELD(MTEDESC, ESIZE, 9, 5) FIELD(MTEDESC, TSIZE, 14, 10) /* mte_checkN only */ =20 +bool mte_probe1(CPUARMState *env, uint32_t desc, uint64_t ptr, uintptr_t r= a); +uint64_t mte_check1(CPUARMState *env, uint32_t desc, uint64_t ptr, uintptr= _t ra); + static inline int allocation_tag_from_addr(uint64_t ptr) { return extract64(ptr, 56, 4); @@ -1324,4 +1327,48 @@ static inline uint64_t address_with_allocation_tag(u= int64_t ptr, int rtag) return deposit64(ptr, 56, 4, rtag); } =20 +/* Return true if tbi bits mean that the access is checked. */ +static inline bool tbi_check(uint32_t desc, int bit55) +{ + return (desc >> (R_MTEDESC_TBI_SHIFT + bit55)) & 1; +} + +/* Return true if tcma bits mean that the access is unchecked. */ +static inline bool tcma_check(uint32_t desc, int bit55, int ptr_tag) +{ + /* + * We had extracted bit55 and ptr_tag for other reasons, so fold + * (ptr<59:55> =3D=3D 00000 || ptr<59:55> =3D=3D 11111) into a single = test. + */ + bool match =3D ((ptr_tag + bit55) & 0xf) =3D=3D 0; + bool tcma =3D (desc >> (R_MTEDESC_TCMA_SHIFT + bit55)) & 1; + return tcma && match; +} + +/* + * For TBI, ideally, we would do nothing. Proper behaviour on fault is + * for the tag to be present in the FAR_ELx register. But for user-only + * mode, we do not have a TLB with which to implement this, so we must + * remote the top byte. + */ +static inline uint64_t useronly_clean_ptr(uint64_t ptr) +{ + /* TBI is known to be enabled. */ +#ifdef CONFIG_USER_ONLY + ptr =3D sextract64(ptr, 0, 56); +#endif + return ptr; +} + +static inline uint64_t useronly_maybe_clean_ptr(uint32_t desc, uint64_t pt= r) +{ +#ifdef CONFIG_USER_ONLY + int64_t clean_ptr =3D sextract64(ptr, 0, 56); + if (tbi_check(desc, clean_ptr < 0)) { + ptr =3D clean_ptr; + } +#endif + return ptr; +} + #endif diff --git a/target/arm/mte_helper.c b/target/arm/mte_helper.c index 907a12b366..7a87574b35 100644 --- a/target/arm/mte_helper.c +++ b/target/arm/mte_helper.c @@ -359,12 +359,136 @@ void HELPER(stzgm_tags)(CPUARMState *env, uint64_t p= tr, uint64_t val) } } =20 +/* Record a tag check failure. */ +static void mte_check_fail(CPUARMState *env, int mmu_idx, + uint64_t dirty_ptr, uintptr_t ra) +{ + ARMMMUIdx arm_mmu_idx =3D core_to_aa64_mmu_idx(mmu_idx); + int el, reg_el, tcf, select; + uint64_t sctlr; + + reg_el =3D regime_el(env, arm_mmu_idx); + sctlr =3D env->cp15.sctlr_el[reg_el]; + + switch (arm_mmu_idx) { + case ARMMMUIdx_E10_0: + case ARMMMUIdx_E20_0: + el =3D 0; + tcf =3D extract64(sctlr, 38, 2); + break; + default: + el =3D reg_el; + tcf =3D extract64(sctlr, 40, 2); + } + + switch (tcf) { + case 1: + /* + * Tag check fail causes a synchronous exception. + * + * In restore_state_to_opc, we set the exception syndrome + * for the load or store operation. Unwind first so we + * may overwrite that with the syndrome for the tag check. + */ + cpu_restore_state(env_cpu(env), ra, true); + env->exception.vaddress =3D dirty_ptr; + raise_exception(env, EXCP_DATA_ABORT, + syn_data_abort_no_iss(el !=3D 0, 0, 0, 0, 0, 0x11), + exception_target_el(env)); + /* noreturn, but fall through to the assert anyway */ + + case 0: + /* + * Tag check fail does not affect the PE. + * We eliminate this case by not setting MTE_ACTIVE + * in tb_flags, so that we never make this runtime call. + */ + g_assert_not_reached(); + + case 2: + /* Tag check fail causes asynchronous flag set. */ + mmu_idx =3D arm_mmu_idx_el(env, el); + if (regime_has_2_ranges(mmu_idx)) { + select =3D extract64(dirty_ptr, 55, 1); + } else { + select =3D 0; + } + env->cp15.tfsr_el[el] |=3D 1 << select; + break; + + default: + /* Case 3: Reserved. */ + qemu_log_mask(LOG_GUEST_ERROR, + "Tag check failure with SCTLR_EL%d.TCF%s " + "set to reserved value %d\n", + reg_el, el ? "" : "0", tcf); + break; + } +} + /* * Perform an MTE checked access for a single logical or atomic access. */ +static bool mte_probe1_int(CPUARMState *env, uint32_t desc, uint64_t ptr, + uintptr_t ra, int bit55) +{ + int mem_tag, mmu_idx, ptr_tag, size; + MMUAccessType type; + uint8_t *mem; + + ptr_tag =3D allocation_tag_from_addr(ptr); + + if (tcma_check(desc, bit55, ptr_tag)) { + return true; + } + + mmu_idx =3D FIELD_EX32(desc, MTEDESC, MIDX); + type =3D FIELD_EX32(desc, MTEDESC, WRITE) ? MMU_DATA_STORE : MMU_DATA_= LOAD; + size =3D FIELD_EX32(desc, MTEDESC, ESIZE); + + mem =3D allocation_tag_mem(env, mmu_idx, ptr, type, size, + MMU_DATA_LOAD, 1, ra); + if (!mem) { + return true; + } + + mem_tag =3D load_tag1(ptr, mem); + return ptr_tag =3D=3D mem_tag; +} + +/* No-fault version of mte_check1, to be used by SVE for MemSingleNF. */ +bool mte_probe1(CPUARMState *env, uint32_t desc, uint64_t ptr, uintptr_t r= a) +{ + int bit55 =3D extract64(ptr, 55, 1); + + /* If TBI is disabled, the access is unchecked. */ + if (unlikely(!tbi_check(desc, bit55))) { + return true; + } + + return mte_probe1_int(env, desc, ptr, ra, bit55); +} + +uint64_t mte_check1(CPUARMState *env, uint32_t desc, uint64_t ptr, uintptr= _t ra) +{ + int bit55 =3D extract64(ptr, 55, 1); + + /* If TBI is disabled, the access is unchecked, and ptr is not dirty. = */ + if (unlikely(!tbi_check(desc, bit55))) { + return ptr; + } + + if (unlikely(!mte_probe1_int(env, desc, ptr, ra, bit55))) { + int mmu_idx =3D FIELD_EX32(desc, MTEDESC, MIDX); + mte_check_fail(env, mmu_idx, ptr, ra); + } + + return useronly_clean_ptr(ptr); +} + uint64_t HELPER(mte_check1)(CPUARMState *env, uint32_t desc, uint64_t ptr) { - return ptr; + return mte_check1(env, desc, ptr, GETPC()); } =20 /* --=20 2.20.1