From nobody Tue Feb 10 14:32:54 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=oracle.com ARC-Seal: i=1; a=rsa-sha256; t=1584033276; cv=none; d=zohomail.com; s=zohoarc; b=mEQXQdRxMZ1/aX0k+j7xmeDvl8o8rtof+htWPisXnA57tJJmK2ks2tr2EnvLnG3sbpMg/+rKTP/o0bCNMBpade+JBIQwhKQ/qN6JflwahvNq10ms4g0w683zvGFPQuOUOxYtb0mY33dKAmkXNldHvqJN9QhaM4KaGPjSLVh3LQs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584033276; h=Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=T6OnfM9mL8bKwZsAlqcLm3VW6a+DTWH7PmxEcV69qx8=; b=fF4kaWTh3gOeyngpXkmqA0nBg0Do8TWtIKjGseKC829DKaw/7rWgPJpqlA5+mxU+jzcRXF1nT1VGoQA4MH4vnD2KJ1rFj8YarCGpZibvIhPEjRDlFywc8GFKu2yoPBCmS83hJY6KK6jXr6mG3bjDMS2aixWDCivoymijQMUTm2c= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584033276331506.7569843383301; Thu, 12 Mar 2020 10:14:36 -0700 (PDT) Received: from localhost ([::1]:46318 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCRPn-0003kD-4G for importer@patchew.org; Thu, 12 Mar 2020 13:14:35 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37167) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCR52-0003ci-VD for qemu-devel@nongnu.org; Thu, 12 Mar 2020 12:53:09 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCR51-0000uE-Uw for qemu-devel@nongnu.org; Thu, 12 Mar 2020 12:53:08 -0400 Received: from userp2120.oracle.com ([156.151.31.85]:60652) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jCR51-0000s7-MJ for qemu-devel@nongnu.org; Thu, 12 Mar 2020 12:53:07 -0400 Received: from pps.filterd (userp2120.oracle.com [127.0.0.1]) by userp2120.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02CGnM3H189395; Thu, 12 Mar 2020 16:53:06 GMT Received: from userp3020.oracle.com (userp3020.oracle.com [156.151.31.79]) by userp2120.oracle.com with ESMTP id 2yqkg8a04w-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 16:53:05 +0000 Received: from pps.filterd (userp3020.oracle.com [127.0.0.1]) by userp3020.oracle.com (8.16.0.42/8.16.0.42) with SMTP id 02CGofOF055780; Thu, 12 Mar 2020 16:53:05 GMT Received: from aserv0122.oracle.com (aserv0122.oracle.com [141.146.126.236]) by userp3020.oracle.com with ESMTP id 2yqgvdb1cm-1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Thu, 12 Mar 2020 16:53:05 +0000 Received: from abhmp0011.oracle.com (abhmp0011.oracle.com [141.146.116.17]) by aserv0122.oracle.com (8.14.4/8.14.4) with ESMTP id 02CGr4Cl001027; Thu, 12 Mar 2020 16:53:04 GMT Received: from spark.ravello.local (/213.57.127.2) by default (Oracle Beehive Gateway v4.0) with ESMTP ; Thu, 12 Mar 2020 09:53:04 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oracle.com; h=from : to : cc : subject : date : message-id : in-reply-to : references : mime-version : content-transfer-encoding; s=corp-2020-01-29; bh=T6OnfM9mL8bKwZsAlqcLm3VW6a+DTWH7PmxEcV69qx8=; b=vsmsNX9eCAz28YML9diqq+Tv5+MaM2tpFOFHnnF9oX9cTwfcgrt0guAY23hHO+kEUjCw hdBXnUaOCyRRs05ZpgO0BlXnLuaKqIyp+U8KkGHov25PT75NSljWfjR4kP/fULPHf9vq wLDvB4DRr5uQ6mFRBKgb8JUm+yYatLmT8H0NHi0eTp8lHYH+O3cXrGTuB6TBan5+H7nh oBJpWZNs9MgIRx8Ri04AJs6Hplhy6/kYCkdzzkx3Ki9DVUg7e4wrnZjmSTRhBu1QjuJK RtCw6Me17ouD4t6Mzs3Icm2mpdptyx1d1dtNfC5+b7uqT/2Gizb3KGFrzGLJv8YVJ6kS 5A== From: Liran Alon To: qemu-devel@nongnu.org Subject: [PATCH v3 16/16] hw/i386/vmport: Assert vmport initialized before registering commands Date: Thu, 12 Mar 2020 18:54:31 +0200 Message-Id: <20200312165431.82118-17-liran.alon@oracle.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200312165431.82118-1-liran.alon@oracle.com> References: <20200312165431.82118-1-liran.alon@oracle.com> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 mlxscore=0 malwarescore=0 adultscore=0 phishscore=0 bulkscore=0 mlxlogscore=999 suspectscore=1 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120085 X-Proofpoint-Virus-Version: vendor=nai engine=6000 definitions=9558 signatures=668685 X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 clxscore=1015 lowpriorityscore=0 mlxlogscore=999 spamscore=0 phishscore=0 adultscore=0 impostorscore=0 malwarescore=0 priorityscore=1501 suspectscore=1 bulkscore=0 mlxscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2001150001 definitions=main-2003120085 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 3.x [generic] [fuzzy] X-Received-From: 156.151.31.85 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: ehabkost@redhat.com, mst@redhat.com, Liran Alon , Nikita Leshenko , pbonzini@redhat.com, rth@twiddle.net Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" vmport_register() is also called from other modules such as vmmouse. Therefore, these modules rely that vmport is realized before those call sites. If this is violated, vmport_register() will NULL-deref. To make such issues easier to debug, assert in vmport_register() that vmport is already realized. Reviewed-by: Nikita Leshenko Signed-off-by: Liran Alon --- hw/i386/vmport.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/hw/i386/vmport.c b/hw/i386/vmport.c index 9d3921cf418d..134d793a4c65 100644 --- a/hw/i386/vmport.c +++ b/hw/i386/vmport.c @@ -83,6 +83,8 @@ static VMPortState *port_state; void vmport_register(VMPortCommand command, VMPortReadFunc *func, void *op= aque) { assert(command < VMPORT_ENTRIES); + assert(port_state); + trace_vmport_register(command, func, opaque); port_state->func[command] =3D func; port_state->opaque[command] =3D opaque; --=20 2.20.1