From nobody Wed May 15 09:53:18 2024 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1584026226; cv=none; d=zohomail.com; s=zohoarc; b=l5vq/kPGPWNnJCWZoidIv9w7n9cuz+cZK/97VvBtfoij7pGqjAMfo1iIdXICQItzL6DZA6GcCHV+mcv2V73RS2NCvKLWvwvTbLlhrXis0Fc3X5C4v2tPQval48jVn5wFSrypYzlqx0qRTh+ktDlDJHulQw74/GWofZ7j2FwKltA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1584026226; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=+8lAeO7K59phLthh01KbziGTkWOxWNugYUbi8jTXHL0=; b=DXytJ+Z3NTN/Nhf4Lz/8ZjsXqXWVcykPIbF3NMYbMEq9lGTp4CwtNjLRFzPVV9hTdI6AvExm4yhGiGltDhjtbb1UZPZDz/do17QxrYVw34urDUXGVAr0Gj/IQwoJT3/rdysLy04kr8AjtOrHXeB/6jjjt0Gaw84kr1r1UVsdbZI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1584026226290752.1559821868099; Thu, 12 Mar 2020 08:17:06 -0700 (PDT) Received: from localhost ([::1]:43148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCPa5-0007K7-78 for importer@patchew.org; Thu, 12 Mar 2020 11:17:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:43350) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jCPYY-00060V-El for qemu-devel@nongnu.org; Thu, 12 Mar 2020 11:15:31 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jCPYX-0001CH-7P for qemu-devel@nongnu.org; Thu, 12 Mar 2020 11:15:30 -0400 Received: from mout.kundenserver.de ([217.72.192.74]:59079) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jCPYW-0001Bk-Ts for qemu-devel@nongnu.org; Thu, 12 Mar 2020 11:15:29 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MYNW8-1ipoFC2IDK-00VLwv; Thu, 12 Mar 2020 16:15:24 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 1/1] q800: fix coverity warning CID 1412799 Date: Thu, 12 Mar 2020 16:15:21 +0100 Message-Id: <20200312151521.38902-2-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200312151521.38902-1-laurent@vivier.eu> References: <20200312151521.38902-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:mSr5JU9J6VKs/z+NMujp3fMgv+EbGAWQJaUpGfqo1HvGn0+nnte iX1YFi4RPVdPSDh1TXqFfRCOkGVIkg+hrFEOqXKq+imaQtmxqtqI3hYk1zCGLnkZLHViIGK uxAGTB/vhquPM3AB4uXoP30V7VkRJ1KY/ZlYw0imm35Ie+BMeGJBWIKPEJmyOpOIfFqTw8O +/mcdRp135P8eSzygP9Ug== X-UI-Out-Filterresults: notjunk:1;V03:K0:IAuGcTvc3OI=:CwTtoWlH2yorsui2pLS3ej UHBUg+chuX18bLLFkXGWn5vGJoLOYOuyzKOUFMvZItJKQ57zZ2bjarYl24a0wtUSuG1OGYlON DqHioeUJoVsEEeda1qIGdmA7Dl6O3yAKlJXCbGcA6KO6R0zfbCdyplEbJiAyFv1HNORUuQBpe K0ubQoCZ7FVIlGKWja3O06Wk35woaBsC/KwN6f90a4sQjaJVnUDvUAQ8LK/H7M8bwKbuOMW+H pPgWI8y7XfGz9M04WisVgY2zHNdWpVs3RTMFlxM4qQhw0hmdc2RIYXH2aveN/84uOnswhNH9b CtbOrhQsn2K9tLspUogeLVjfhH+4errIhgtm2qhY+RA/ur8bILL4GE8ogZljudqDAaFj0EXxl g0xgC4CemHzeUiK2hYOo31nzHnjz2+r6+i5FeNjlve7s52eOcyi7yW31mpyPmPXJubsp9MUob 0AMQPUQDRl7gJK0PUCkntG8XnMimUsNLa585OTWYFHcWFsFEOuh2dXRqtLGg+M4IfJ15Q6Pj8 /aBNsPNX3qO40lLv3cuFTAbZU6pGBxOC65z6sesyJ4Ji8Sfbjm2pQOzwUgMJMnS2VCzyAXr7Q /yD00nxNkr/C89QL1j0bB91vKo1eQx54U/L5RbRPoJVAZpIdu+kSVpXa8N5+uu/WKqbQyzvjK hWHUj0Opg/PZJByWB/ZUcXC+dT/v9+9FfJlCtbCYvrTdQqJY+Cee6+wD24aj2xYX7waVMkboW xYHy4ghGKmblKGe5DCM5uMn85icbqxNVFwfDcEOgQGpjdS5/TJmZcmqbbrClvh8p8Zn/PK3px Hu3mT12CPsvNsE3OCGlRwst9iYVHZY8o5I0OudyY93Ykkl+/LJzQ9kK4iRkH8Vjg7AMAjTs X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 217.72.192.74 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Laurent Vivier Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Check the return value of blk_write() and log an error if any Fixes: Coverity CID 1412799 (Error handling issues) Signed-off-by: Laurent Vivier Reviewed-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200210132252.381343-1-laurent@vivier.eu> --- hw/misc/mac_via.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/hw/misc/mac_via.c b/hw/misc/mac_via.c index b7d0012794..81343301b1 100644 --- a/hw/misc/mac_via.c +++ b/hw/misc/mac_via.c @@ -30,6 +30,7 @@ #include "hw/qdev-properties.h" #include "sysemu/block-backend.h" #include "trace.h" +#include "qemu/log.h" =20 /* * VIAs: There are two in every machine, @@ -381,8 +382,10 @@ static void via2_irq_request(void *opaque, int irq, in= t level) static void pram_update(MacVIAState *m) { if (m->blk) { - blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM, - sizeof(m->mos6522_via1.PRAM), 0); + if (blk_pwrite(m->blk, 0, m->mos6522_via1.PRAM, + sizeof(m->mos6522_via1.PRAM), 0) < 0) { + qemu_log("pram_update: cannot write to file\n"); + } } } =20 --=20 2.24.1