From nobody Thu Dec 18 17:59:29 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583935155; cv=none; d=zohomail.com; s=zohoarc; b=hPgOqrUNXh1bIbWz+iXFoFiRJ/EpsrJZiyfEnlpvPe2LBO2mgsEzO/9x/rEKQL7JDvs4pJQbY12aOeqwgHF6UbfuNATIyOnvVnRHMrLOx2UGcZ50Wdwh+K+Cltd5c3n9uXSTp0g+LMio++FN+nNwF51jPi5YqJTgmpBMKe/AiJw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583935155; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=s+16saIOGAiKpnjUdMevgo7P8/ddL41+2kaIvsYz5qw=; b=fDg6hLAQ5WiAhse3SfqIIQ0QmhFacWRxAeJEcufYgoZq7ntv/Eeq7IeK9QbEHtIr/iXtlYc8nolkxQEfGL1aiaWpt6UGV8slHLa91W5AcpbTeYPDSHTCSACs1FX9ce+xn7cq23F7qfkobK6me1WSgTwwKbnXe+m9Xf7OQ/AHIuw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583935155186437.9427941058374; Wed, 11 Mar 2020 06:59:15 -0700 (PDT) Received: from localhost ([::1]:52584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC1tB-0001kX-K7 for importer@patchew.org; Wed, 11 Mar 2020 09:59:13 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:36265) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jC1n1-0004B3-09 for qemu-devel@nongnu.org; Wed, 11 Mar 2020 09:52:52 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jC1mz-0002cx-KB for qemu-devel@nongnu.org; Wed, 11 Mar 2020 09:52:50 -0400 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:55101 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jC1mz-0002bu-H8 for qemu-devel@nongnu.org; Wed, 11 Mar 2020 09:52:49 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-47-tBtvgbpANuurfCcxXA3c1w-1; Wed, 11 Mar 2020 09:52:45 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id C8F0F8017CC; Wed, 11 Mar 2020 13:52:43 +0000 (UTC) Received: from localhost (ovpn-117-216.ams2.redhat.com [10.36.117.216]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3F8BD5D9C5; Wed, 11 Mar 2020 13:52:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583934767; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=s+16saIOGAiKpnjUdMevgo7P8/ddL41+2kaIvsYz5qw=; b=EiD4Ou8JypCeNQKWlvEHnA1j+IAasdjgLOSAtM6G05wsxmbG2IbU1JBg2+BHCYhvfMFJjL 5OfNTgzEI80aEmVJKCqXExDjesQ0oIyWuYcHhcIc6MfMB88F4rcug0TXvGFJNnlDuOieyb hGJToLpgDQG8L1dY1x6fXBLfXbmlU+4= X-MC-Unique: tBtvgbpANuurfCcxXA3c1w-1 From: Max Reitz To: qemu-block@nongnu.org Subject: [PULL 09/19] qemu-img: free memory before re-assign Date: Wed, 11 Mar 2020 14:52:03 +0100 Message-Id: <20200311135213.1242028-10-mreitz@redhat.com> In-Reply-To: <20200311135213.1242028-1-mreitz@redhat.com> References: <20200311135213.1242028-1-mreitz@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Peter Maydell , qemu-devel@nongnu.org, Max Reitz Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan collect_image_check() is called twice in img_check(), the filename/format w= ill be alloced without free the original memory. It is not a big deal since the process will exit anyway, but seems like a c= lean code and it will remove the warning spotted by asan. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Message-Id: <20200227012950.12256-3-pannengyuan@huawei.com> Signed-off-by: Max Reitz --- qemu-img.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/qemu-img.c b/qemu-img.c index 4bc40df6d2..7b7087dd60 100644 --- a/qemu-img.c +++ b/qemu-img.c @@ -817,6 +817,8 @@ static int img_check(int argc, char **argv) check->corruptions_fixed); } =20 + qapi_free_ImageCheck(check); + check =3D g_new0(ImageCheck, 1); ret =3D collect_image_check(bs, check, filename, fmt, 0); =20 check->leaks_fixed =3D leaks_fixed; --=20 2.24.1