From nobody Fri Nov 14 00:50:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583897445; cv=none; d=zohomail.com; s=zohoarc; b=SiYTq062TFvzM9njHtqlVeWip2jKBFyPYmy2AUvsXPrBYGN51/NuHx2DFhABeWOxzpHx4fhYB5z5G4gDvJqxHkE9U5F3Cyuipq12Ab9HmNJ3S8rr4TMoosZbQdEq3tTuLuvNGUemT4TSfsuk1x5b20ZuJmG7Z+k/y06BMCrpRiA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583897445; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=rV1MfqIM63VgKeX4JInFiSaUmowsQq2h3r3ZroAp4Aw=; b=bVICH8up4uw7ImGjzaeedJTyX0w5hpK4cf6Qjesv1rOAYb/4VCB+7o83r28pnvo3H+Mm0t0WQorrX0OIpnIsw572JqHZYeQ1iRoMRkNfTD5r14JhbD3tx92hRdwq1pqFQCL8/U6jsNwF7Ol+D5+W54vcIEb3NNGEEkLcc551t9I= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583897445678365.6289070419143; Tue, 10 Mar 2020 20:30:45 -0700 (PDT) Received: from localhost ([::1]:43308 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBs4x-0002HG-H3 for importer@patchew.org; Tue, 10 Mar 2020 23:30:43 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:54313) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBs4D-0001el-JY for qemu-devel@nongnu.org; Tue, 10 Mar 2020 23:29:58 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBs4C-0001Nx-Dv for qemu-devel@nongnu.org; Tue, 10 Mar 2020 23:29:57 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3196 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBs4C-0001Bh-20; Tue, 10 Mar 2020 23:29:56 -0400 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 5643B4A7CBD4F5EEDE15; Wed, 11 Mar 2020 11:29:49 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.487.0; Wed, 11 Mar 2020 11:29:38 +0800 From: Chen Qun To: , Subject: [PATCH v3] block/iscsi:use the flags in iscsi_open() prevent Clang warning Date: Wed, 11 Mar 2020 11:29:27 +0800 Message-ID: <20200311032927.35092-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , zhang.zhanghailiang@huawei.com, Euler Robot , Peter Lieven , Laurent Vivier , Max Reitz , Ronnie Sahlberg , Paolo Bonzini , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read flags &=3D ~BDRV_O_RDWR; ^ ~~~~~~~~~~~~ In iscsi_allocmap_init() only checks BDRV_O_NOCACHE, which is the same in both of flags and bs->open_flags. We can use the flags instead bs->open_flags to prevent Clang warning. Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Kevin Wolf --- Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Kevin Wolf Cc: Max Reitz Cc: Laurent Vivier v1->v2: Keep the 'flags' then use it(Base on Kevin's comments). v2->v3: Modify subject and commit messages(Base on Kevin's and Laurent's comments). --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..50bae51700 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *op= tions, int flags, iscsilun->cluster_size =3D iscsilun->bl.opt_unmap_gran * iscsilun->block_size; if (iscsilun->lbprz) { - ret =3D iscsi_allocmap_init(iscsilun, bs->open_flags); + ret =3D iscsi_allocmap_init(iscsilun, flags); } } =20 --=20 2.23.0