From nobody Fri Nov 14 00:46:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583863686; cv=none; d=zohomail.com; s=zohoarc; b=hncBWFcDn73RXwW0C9SosHZTUtQszX1isnlZFV3qBuK/uzTshiVvtuayT6lJ7xzVgpx2t/upNEWUeHZ6WKCX9ROKDTg+KvAUVnw9qwSUzTcQNhXW9yY5GbzB9gEms4TtuagGCjPEUU/gPnsvYGM+VojEYOSFK4SIq3Y+HtPeLvs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583863686; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=/IavJEhyr76wx/WQVJrlu2MafjZF0yd8qqzcsHJBa0k=; b=mNkW82nh2ayr8a8iUefQsYP/qPWNGNi2SzclfPdUw9FSxgEQJ1HuUATOP5i0esuEhY8vrRJSbRb7v4k99EmoiI06rcLZc30wOlG+NsOiYJy/ZJqB8eltQGb3tXeKa9vsixOhqedo5QE+kZO4jObTvuITa2NlnnPYpHIf4aNqMh0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583863686626685.6758654826205; Tue, 10 Mar 2020 11:08:06 -0700 (PDT) Received: from localhost ([::1]:38066 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBjIT-00031J-H3 for importer@patchew.org; Tue, 10 Mar 2020 14:08:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51613) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBjFs-0007db-GJ for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:25 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBjFr-00054G-FQ for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:24 -0400 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:39258 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBjFr-0004yG-9G for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:23 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-401-AvrKYZPrPyOJgqPBXMIrrg-1; Tue, 10 Mar 2020 14:05:21 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 030398017CC; Tue, 10 Mar 2020 18:05:20 +0000 (UTC) Received: from localhost.localdomain (ovpn-125-115.rdu2.redhat.com [10.10.125.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6F52727184; Tue, 10 Mar 2020 18:05:18 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583863522; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/IavJEhyr76wx/WQVJrlu2MafjZF0yd8qqzcsHJBa0k=; b=NYfupQJX2vYvD6gaeEiwjyKpQnraoDU69OgHeOejjXwF4RuY6cgpEw1ON1pEJkQ2YOF8ep 7g4a+lt/XAsN/ZFJLKjsKLMsGrikTPPKtLl3Vxktgt0V48cOs71qLMtxSsXFVArWRNltJT kTZ7ed5qpwJ1bPbtofXEyZmzX/Zwn50= X-MC-Unique: AvrKYZPrPyOJgqPBXMIrrg-1 From: Wainer dos Santos Moschetta To: qemu-devel@nongnu.org Subject: [PATCH 1/2] hw/mem/pc-dimm: Print slot number on error at pc_dimm_pre_plug() Date: Tue, 10 Mar 2020 15:05:09 -0300 Message-Id: <20200310180510.19489-2-wainersm@redhat.com> In-Reply-To: <20200310180510.19489-1-wainersm@redhat.com> References: <20200310180510.19489-1-wainersm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, imammedo@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The error report in pc_dimm_pre_plug() now has the slot number printed. Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Stefano Garzarella --- hw/mem/pc-dimm.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 8f50b8afea..36edfcf467 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -44,8 +44,8 @@ void pc_dimm_pre_plug(PCDIMMDevice *dimm, MachineState *m= achine, &error_abort); if ((slot < 0 || slot >=3D machine->ram_slots) && slot !=3D PC_DIMM_UNASSIGNED_SLOT) { - error_setg(&local_err, "invalid slot number, valid range is [0-%" - PRIu64 "]", machine->ram_slots - 1); + error_setg(&local_err, "invalid slot number %d, valid range is [0-= %" + PRIu64 "]", slot, machine->ram_slots - 1); goto out; } =20 --=20 2.24.1 From nobody Fri Nov 14 00:46:51 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583863663; cv=none; d=zohomail.com; s=zohoarc; b=M1T0tb1Ch0+pPqbqs2miEDNQyORzFnmn4F/ml7nfZl73O03E/YWCxBIZuDKlM6egyculqswNLI1nPUkQ5YkaMTV9pmPSXmbA17NSUAITODLQdgmX0Oyp710O5TIT14wvmltDiuxoy4jlerstG8MUEno2FZTt2XebmcPhwDspqsw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583863663; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=27otnlpCCc6Oj80P4U1wJDCLkbDt2NBJY+YO7yC4c2Q=; b=j0+IRjlHwNbaVIT8egXP6/GO3rSQd5xFtlBFL6WnFZ3Vayd3jIA0r9oZYsS9BGWf4Np60OlRpKhT+yenT/vEx3McFKKpeaB98WlHbO1J/AQEZB6L3toJLvBegb/vH1QUrHHpZNcarMhS+4l3pKUP7hkw1iLen0sJL7Ktw0KEZmw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583863663260431.8232434215938; Tue, 10 Mar 2020 11:07:43 -0700 (PDT) Received: from localhost ([::1]:38064 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBjI6-0002W8-0c for importer@patchew.org; Tue, 10 Mar 2020 14:07:42 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:51722) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBjFx-0007o1-5Q for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:30 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBjFw-0005WJ-4P for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:29 -0400 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:56714 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBjFw-0005Tj-04 for qemu-devel@nongnu.org; Tue, 10 Mar 2020 14:05:28 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-171-7VVRL2bfPayd7ql-Cy4jzw-1; Tue, 10 Mar 2020 14:05:23 -0400 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 19FDC13EA; Tue, 10 Mar 2020 18:05:22 +0000 (UTC) Received: from localhost.localdomain (ovpn-125-115.rdu2.redhat.com [10.10.125.115]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9688519C7F; Tue, 10 Mar 2020 18:05:20 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583863527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=27otnlpCCc6Oj80P4U1wJDCLkbDt2NBJY+YO7yC4c2Q=; b=UmG1B1ubsfkdIgiufs6CDrmucLCNkVwNYvXRGDtnfCFkaF9gWqyHDX8eTHGjC/mH44YlFC 8nWgtrKWD+ZiNTl3A8l/7TYnGLytVw4a8IXPIBH8a459pb0XVSocpXpFowQPKLhk0iKIIe 1GJWoi7d9F7LYFzlDzZgMLJ5wIXjjZE= X-MC-Unique: 7VVRL2bfPayd7ql-Cy4jzw-1 From: Wainer dos Santos Moschetta To: qemu-devel@nongnu.org Subject: [PATCH 2/2] hw/mem/pc-dimm: Fix line over 80 characters warning Date: Tue, 10 Mar 2020 15:05:10 -0300 Message-Id: <20200310180510.19489-3-wainersm@redhat.com> In-Reply-To: <20200310180510.19489-1-wainersm@redhat.com> References: <20200310180510.19489-1-wainersm@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: qemu-trivial@nongnu.org, imammedo@redhat.com, mst@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Wainer dos Santos Moschetta Reviewed-by: Stefano Garzarella --- hw/mem/pc-dimm.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/mem/pc-dimm.c b/hw/mem/pc-dimm.c index 36edfcf467..6d62588fea 100644 --- a/hw/mem/pc-dimm.c +++ b/hw/mem/pc-dimm.c @@ -218,7 +218,8 @@ static MemoryRegion *pc_dimm_get_memory_region(PCDIMMDe= vice *dimm, Error **errp) =20 static uint64_t pc_dimm_md_get_addr(const MemoryDeviceState *md) { - return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, &error_= abort); + return object_property_get_uint(OBJECT(md), PC_DIMM_ADDR_PROP, + &error_abort); } =20 static void pc_dimm_md_set_addr(MemoryDeviceState *md, uint64_t addr, --=20 2.24.1