From nobody Thu Nov 13 23:29:49 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583846681; cv=none; d=zohomail.com; s=zohoarc; b=gQqUwhAXS1/etPvvJL0TnPmsUm3ffVUZUF3LYYElQ1z2zfGoIl0eYMzB1kN/I0vfVyqQ5etnppl0TvozwqRX2oe4+BRF07+oxRMpgsHPFzCGzeQCWmdPA5kHDDtc5/tmHyoIqbONMjgYv4MHPdmE2lkZd/wT5T7JXx/jzwq7vDA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583846681; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=n0Qye6UFUpyykYX99akYzNgKb0m3lFBqnkeN2lwEXJQ=; b=JZGGawowazcqarMHIZ6NZDozFkGSrv9kogk4AgXsPxJdUBVXvsEvQ0v5RcW2j510WhmUIpXfnVKzxFLKbP8prQ511Osu1Ox3j3QLDyNIUQ/2/p8IM7ppSao2jSANfz6QS+Tu/6Y1W1rgKInmUSj1GHhW4iUp2OqXxMa0uBDjvzw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158384668102611.596193509296768; Tue, 10 Mar 2020 06:24:41 -0700 (PDT) Received: from localhost ([::1]:60644 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBeeV-0000R0-Qg for importer@patchew.org; Tue, 10 Mar 2020 09:10:31 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:49065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBedU-0007rU-AF for qemu-devel@nongnu.org; Tue, 10 Mar 2020 09:09:29 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBedT-0007bJ-8h for qemu-devel@nongnu.org; Tue, 10 Mar 2020 09:09:28 -0400 Received: from szxga04-in.huawei.com ([45.249.212.190]:3195 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBedQ-0007A7-Jp; Tue, 10 Mar 2020 09:09:24 -0400 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8E56AFBD1529C551D146; Tue, 10 Mar 2020 21:09:13 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.487.0; Tue, 10 Mar 2020 21:09:07 +0800 From: Chen Qun To: , Subject: [PATCH] hw/scsi/megasas:Clean up some redundant code fix Clang warnings Date: Tue, 10 Mar 2020 21:08:44 +0800 Message-ID: <20200310130844.30076-1-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Hannes Reinecke , zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Euler Robot , Paolo Bonzini , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Here are some redundant statements, we can clean them up. Clang static code analyzer show warning: hw/scsi/megasas.c:1175:32: warning: Value stored to 'max_ld_disks' during i= ts initialization is never read uint32_t num_ld_disks =3D 0, max_ld_disks =3D s->fw_luns; ^~~~~~~~~~~~ ~~~~~~~~~~ hw/scsi/megasas.c:1183:9: warning: Value stored to 'max_ld_disks' is never = read max_ld_disks =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng Cc: Hannes Reinecke Cc: qemu-block@nongnu.org --- hw/scsi/megasas.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/hw/scsi/megasas.c b/hw/scsi/megasas.c index af18c88b65..3f982e1d3b 100644 --- a/hw/scsi/megasas.c +++ b/hw/scsi/megasas.c @@ -1172,7 +1172,7 @@ static int megasas_dcmd_ld_list_query(MegasasState *s= , MegasasCmd *cmd) uint16_t flags; struct mfi_ld_targetid_list info; size_t dcmd_size =3D sizeof(info), resid; - uint32_t num_ld_disks =3D 0, max_ld_disks =3D s->fw_luns; + uint32_t num_ld_disks =3D 0, max_ld_disks; BusChild *kid; =20 /* mbox0 contains flags */ @@ -1180,7 +1180,6 @@ static int megasas_dcmd_ld_list_query(MegasasState *s= , MegasasCmd *cmd) trace_megasas_dcmd_ld_list_query(cmd->index, flags); if (flags !=3D MR_LD_QUERY_TYPE_ALL && flags !=3D MR_LD_QUERY_TYPE_EXPOSED_TO_HOST) { - max_ld_disks =3D 0; } =20 memset(&info, 0, dcmd_size); --=20 2.23.0