From nobody Fri Nov 14 01:05:02 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583767829; cv=none; d=zohomail.com; s=zohoarc; b=RYhvKZOJhor2Ky+xcBRS2yq5K2q/JHuLQZ+k/JOwLwV9jPuqN97C82FQWKf1WL8MzrieXEBMILf5GKmfiIDILZpoijg4Jc+G4BZxpmlzuaf60se3taj38BpaSPAsXczWbQ5C1MwnRbZBwGnVJVCzza7F+cwpKqTEQyZ3n7ZTano= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583767829; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=GaegJFcvNA6SPAwxzq+V8HyssZanPbiHcJyOl48XlYY=; b=ERFlKFlNSuMuF9cHpWMn22V1J+FLNj6HnyqUb1nSwDp2P/gvR22j3Kh7RQgs9axodczcnEvHds2UCMshcc7p9htMiFiZWeoJEGxf1pr3bUK9yBdKvZLfgCplV+r0QBLZSXlP6Vb9RHwLgfCc6oX0bpkI8CnJVGTJ0HqmeO9JQPo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583767829239280.635537214269; Mon, 9 Mar 2020 08:30:29 -0700 (PDT) Received: from localhost ([::1]:44934 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBKMN-0004i9-Qj for importer@patchew.org; Mon, 09 Mar 2020 11:30:27 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34667) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBK3e-0001LQ-2Z for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:11:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBK3c-0000Al-Tq for qemu-devel@nongnu.org; Mon, 09 Mar 2020 11:11:05 -0400 Received: from mout.kundenserver.de ([212.227.17.24]:32827) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1jBK3a-00007m-6F; Mon, 09 Mar 2020 11:11:02 -0400 Received: from localhost.localdomain ([82.252.135.106]) by mrelayeu.kundenserver.de (mreue109 [212.227.15.183]) with ESMTPSA (Nemesis) id 1MxUfn-1jZqAI2tKr-00xr6l; Mon, 09 Mar 2020 16:09:51 +0100 From: Laurent Vivier To: qemu-devel@nongnu.org Subject: [PULL 29/33] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Date: Mon, 9 Mar 2020 16:08:33 +0100 Message-Id: <20200309150837.3193387-30-laurent@vivier.eu> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200309150837.3193387-1-laurent@vivier.eu> References: <20200309150837.3193387-1-laurent@vivier.eu> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:VR7JvRspay92/RpC3019xh/+yKSsaZhhChauw/DzrILMmPwVQbl KT4mJuwv7zsMg8kFmidAhL99c1eGnnbg5NNW/kWiba09T5ch/Xk+uCGHmODaXNx4gqY9foN MHoIHGw1idZjYnPtI+UwJ0/GC0NKFMGfrCLc4/0mWRW2Ci0UJzNhUSWtgfS1YWnWTBrFo5J WgnNnY1Gd1b1rSq0R9iNw== X-UI-Out-Filterresults: notjunk:1;V03:K0:d/Zn4yl+QlE=:bGwabL+x5posZ6fqHJw5as cbs5eAUKfZbTwBoLi20DntdUpuY1+oivFuvbLrQ3Sqy7FFk6BSHr1InaA+3IInPAYXrYZObX6 Ss7HORg+et8/6Ve5saonFY7g+ytd6/EthYjPSeE0Ot9S1VmimpI2JVz0zNdBZESUrulqkrBVR ZULkjXUwca+BMN1wUILV/jYp+hGhsc2nMa4ZYWgVBtqOjCX0z0dg7+9pcAZIa/UjtI3Kg3LRJ Y2J9VZ1UcEbEllt/+H3gkuwni7WU0+c4IQTw7lYV2wdWpHN6y0IITPCbCAPRNimU/JEnVe2mH Qbb15PdX8Scgp0zU6WxwjhCXQAdifK2y3I0CQBdpac4sRwX9fbzjMS0XLY+S1L27FHyS3S+Wi 7kqNnpN6n4uNt65GW1Y2xpyjFZ5gQcRajJ/BVAr9HLZrxHpoFi+GtjPvaGRD9U+DbfVxisMLM VPhupl0DIfC67sSmh91aao/kkmxhD1ie+stKIgVMI7Oobcrr61Ntl/I5ZW3o10meYsZ/Cz5Gg 5z2QnwAUwXpg9OXWYIOlVhBwhzroe2TZvzOoNQu8dM0zSHpH+Vvhg4/hOYSHMp1b15N1nLmVl hYuUxGiE/XVYIid6DntY0XMzHlaToiQ9QkaH7gSawR+FmKpopFR+T253t2zKGlNHdH5Miw7ke kP04ynScr7SwHy0/ZAT1iFfGrRd2dqOSm4hbV9EY0g4Eo1ysEjYzYbspsc0HplGPYqFb6vBmI pguoy+EqZy+Ll4xvB6p1meABu/CAZ8YvuLf0DofO2CeWnvyXOxlHDrRJgTpRm2L10mGjqIvmT dAQR4AAmHLyZiElb9iF33OIfDetvDh/kRUEI7e/yDVhNkVQ2tvMCozg2+AsKadReuG9lIt4 X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 212.227.17.24 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , Peter Maydell , Dmitry Fleytman , "Michael S. Tsirkin" , Jason Wang , Christian Schoenebeck , Alistair Francis , Gerd Hoffmann , "Edgar E. Iglesias" , "Edgar E . Iglesias" , qemu-block@nongnu.org, qemu-trivial@nongnu.org, Francisco Iglesias , Helge Deller , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Eduardo Habkost , Michael Tokarev , Alistair Francis , Greg Kurz , "Dr. David Alan Gilbert" , qemu-arm@nongnu.org, Paolo Bonzini , Chen Qun , John Snow , Richard Henderson , Kevin Wolf , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Igor Mitsyanko , Laurent Vivier , Max Reitz , Aleksandar Markovic , Euler Robot , Igor Mammedov , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" From: Chen Qun Clang static code analyzer show warning: hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_W= ORD3, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Francisco Iglesias Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias Message-Id: <20200302130715.29440-11-kuhn.chenqun@huawei.com> Signed-off-by: Laurent Vivier --- hw/dma/xlnx-zdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c index 1c1b142293a6..2d9c0a0d5e19 100644 --- a/hw/dma/xlnx-zdma.c +++ b/hw/dma/xlnx-zdma.c @@ -372,7 +372,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, boo= l type, static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len) { uint32_t dst_size, dlen; - bool dst_intr, dst_type; + bool dst_intr; unsigned int ptype =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_= TYPE); unsigned int rw_mode =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE= ); unsigned int burst_type =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATT= R, @@ -386,17 +386,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf,= uint32_t len) while (len) { dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD= 2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD= 3, - TYPE); if (dst_size =3D=3D 0 && ptype =3D=3D PT_MEM) { uint64_t next; + bool dst_type =3D FIELD_EX32(s->dsc_dst.words[3], + ZDMA_CH_DST_DSCR_WORD3, + TYPE); + next =3D zdma_update_descr_addr(s, dst_type, R_ZDMA_CH_DST_CUR_DSCR_LSB); zdma_load_descriptor(s, next, &s->dsc_dst); dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_= WORD2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_= WORD3, - TYPE); } =20 /* Match what hardware does by ignoring the dst_size and only using --=20 2.24.1