From nobody Fri Nov 14 00:46:48 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583758215; cv=none; d=zohomail.com; s=zohoarc; b=c0aHbtgxuZfN19b3Sri+vOzgtTcLdAWj/hfSO9SX1GyZmSO+JVxpFkX5R47l09/haRD51D4lr5v60fFX2fTnl1pAeUiGETLTk1aV0IDvU6FWzjmMmNdXNNOGuXo1FthhnOMPlWW6t4VUE2GCzA2U/lWOrnuCgEqwepdoKPm5J90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583758215; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L8tKS53m/iCX/+e3eTiv7utNTL7Cedo93PaSY2b3hTE=; b=Za3N+fJpAgQCITwX6UguqpEGtLVY9lAG9J387i6+xQJxQIo8Ags+7aH+40U3l2zZ72iScFoch4oH/RjqVaIt7Eh/qnYIJR2TEMNbhlZKLUTH5agGKPFO+ZKuR8EzXce2mpmosSdrtgtTzj5ybXxLK9nhR7bN+VESkN5cT2uk7AQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583758215752160.5233516350154; Mon, 9 Mar 2020 05:50:15 -0700 (PDT) Received: from localhost ([::1]:42626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHrK-0007Cu-1u for importer@patchew.org; Mon, 09 Mar 2020 08:50:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34097) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHne-0003Li-G0 for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHnd-0003kX-AT for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:45066 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBHnd-0003jJ-6B for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:25 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-9OEzc6jDOLCG2LOoTIYPsw-1; Mon, 09 Mar 2020 08:46:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 463CA1084441 for ; Mon, 9 Mar 2020 12:46:22 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAC4C91D84; Mon, 9 Mar 2020 12:46:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3A3EE1138611; Mon, 9 Mar 2020 13:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583757984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8tKS53m/iCX/+e3eTiv7utNTL7Cedo93PaSY2b3hTE=; b=dob72mqr0k9JBq87yJUerHxWSN8ob8TL1r9XBg7WrDep6xHmMm/HPcVbj7t/kvfezJucf8 OJB3Md+JZ4rDg59HTa0s+y26p7+fuXAreuMxi+tW94YYpkwfK7iXkHmxHMfSi8Y8vrq8eC Ipw+aGher+zQRpZQBheKJTbt9Q6ymLY= X-MC-Unique: 9OEzc6jDOLCG2LOoTIYPsw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 3/4] qga: Improve error report by calling error_setg_win32() Date: Mon, 9 Mar 2020 13:46:15 +0100 Message-Id: <20200309124616.4372-4-armbru@redhat.com> In-Reply-To: <20200309124616.4372-1-armbru@redhat.com> References: <20200309124616.4372-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Use error_setg_win32() which adds a hint similar to strerror(errno)). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200228100726.8414-4-philmd@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Markus Armbruster --- qga/channel-win32.c | 3 ++- qga/commands-win32.c | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index c86f4388db..99648c95b6 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -308,7 +308,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, } =20 if (method =3D=3D GA_CHANNEL_ISA_SERIAL && !SetCommTimeouts(c->handle,= &comTimeOut)) { - g_critical("error setting timeout for com port: %lu",GetLastError(= )); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error setting timeout for com port: %s", emsg); CloseHandle(c->handle); return false; } diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 2461fd19bf..9c744d6405 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -315,8 +315,9 @@ void qmp_guest_shutdown(bool has_mode, const char *mode= , Error **errp) } =20 if (!ExitWindowsEx(shutdown_flag, SHTDN_REASON_FLAG_PLANNED)) { - slog("guest-shutdown failed: %lu", GetLastError()); - error_setg(errp, QERR_UNDEFINED_ERROR); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("guest-shutdown failed: %s", emsg); + error_setg_win32(errp, GetLastError(), "guest-shutdown failed"); } } =20 @@ -1319,7 +1320,8 @@ static DWORD WINAPI do_suspend(LPVOID opaque) DWORD ret =3D 0; =20 if (!SetSuspendState(*mode =3D=3D GUEST_SUSPEND_MODE_DISK, TRUE, TRUE)= ) { - slog("failed to suspend guest, %lu", GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("failed to suspend guest: %s", emsg); ret =3D -1; } g_free(mode); --=20 2.21.1