From nobody Thu Nov 13 23:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583758389; cv=none; d=zohomail.com; s=zohoarc; b=S+NFLu6w07ME9RqutABfw91B/rocnKPfg7KgkCvovn4X/I7LsuNlV5QD/IFe1qN0x4SrJVB2Qyecc5cJcCH9x6wrUR2eTdU7oOn5nGKjfUD09yZEhMylANVybNkGi959GJ+Eo6L5lgkkdypa+2CLi44CjVRZjELCzQs7oU1TdMo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583758389; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ghUUbHBLeJfPjhw9Xr3hpb5Q5fUdpl7pzHb43rVSMCE=; b=bngbsm0wuvUNE//DXB1kD8erjgYj+C43/HKQkveCQVfzETVJav1FHXLso2qCC51eG4e0mhlzYd2SlXRP8xvOR1w+DgcZXU/FaK5j0lAWoQ/u0pY6/x4yaXaBJWCXSTJQo/PpQA9i9/mE/pgn8KyTtP3QEWuWA/XGPrIWqYCjuSw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583758389325978.3531003287944; Mon, 9 Mar 2020 05:53:09 -0700 (PDT) Received: from localhost ([::1]:42714 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHu8-0002yF-41 for importer@patchew.org; Mon, 09 Mar 2020 08:53:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34095) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHne-0003LY-DS for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHnc-0003ih-Mq for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:40459 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBHnb-0003gT-IJ for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-44-MG2fgR2lOguZEz2VkmzmFA-1; Mon, 09 Mar 2020 08:46:21 -0400 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 740551084437 for ; Mon, 9 Mar 2020 12:46:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A3D3760C87; Mon, 9 Mar 2020 12:46:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 2E37511385ED; Mon, 9 Mar 2020 13:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583757983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ghUUbHBLeJfPjhw9Xr3hpb5Q5fUdpl7pzHb43rVSMCE=; b=Y10lM/rgpVdoUViXmLfdu4yWasA/ejJQE0Jnw5udBnhgGdZ54Fux/9W51IsWFPDJVNvyoJ GPfJwZAiOg4k+hCvk08j+O9M0ZsUS24dmlnZ12zddHExMgmUuEnl18feH4i6B/QXIuczZx 0e+C0GdxUPB/LXfiFP1k0lmuiMetuKY= X-MC-Unique: MG2fgR2lOguZEz2VkmzmFA-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 1/4] chardev: Improve error report by calling error_setg_win32() Date: Mon, 9 Mar 2020 13:46:13 +0100 Message-Id: <20200309124616.4372-2-armbru@redhat.com> In-Reply-To: <20200309124616.4372-1-armbru@redhat.com> References: <20200309124616.4372-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Daniel=20P=20=2E=20Berrang=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Daniel P. Berrang=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200228100726.8414-2-philmd@redhat.com> Signed-off-by: Markus Armbruster --- chardev/char-pipe.c | 2 +- chardev/char-win.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/chardev/char-pipe.c b/chardev/char-pipe.c index 94d714ffcd..fd12c9e63b 100644 --- a/chardev/char-pipe.c +++ b/chardev/char-pipe.c @@ -70,7 +70,7 @@ static int win_chr_pipe_init(Chardev *chr, const char *fi= lename, MAXCONNECT, NSENDBUF, NRECVBUF, NTIMEOUT, NU= LL); g_free(openname); if (s->file =3D=3D INVALID_HANDLE_VALUE) { - error_setg(errp, "Failed CreateNamedPipe (%lu)", GetLastError()); + error_setg_win32(errp, GetLastError(), "Failed CreateNamedPipe"); s->file =3D NULL; goto fail; } diff --git a/chardev/char-win.c b/chardev/char-win.c index 34825f683d..d4fb44c4dc 100644 --- a/chardev/char-win.c +++ b/chardev/char-win.c @@ -96,7 +96,7 @@ int win_chr_serial_init(Chardev *chr, const char *filenam= e, Error **errp) s->file =3D CreateFile(filename, GENERIC_READ | GENERIC_WRITE, 0, NULL, OPEN_EXISTING, FILE_FLAG_OVERLAPPED, 0); if (s->file =3D=3D INVALID_HANDLE_VALUE) { - error_setg(errp, "Failed CreateFile (%lu)", GetLastError()); + error_setg_win32(errp, GetLastError(), "Failed CreateFile"); s->file =3D NULL; goto fail; } --=20 2.21.1 From nobody Thu Nov 13 23:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583758289; cv=none; d=zohomail.com; s=zohoarc; b=lZd/uMO9HvmY/32VnbFVw9MqGvFFcejBE/UKD73yEQCvfRDNPnIFpqP1UlxeTveRuD8upB+dQNUXc39xeYpSxMOM5J8biWsuquBBfQrxhmEEiTpemQmMdL0rx0ibrwv8c/JmyHabI2EFk7mt9Fx0gAXRWk4/C29WKH5QonhRlvo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583758289; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Pa8QNbeLcCahskW5w7Cch3+nbAdBehrY2rXYQPR64YA=; b=hIH+5deZbT33fkFrCfYriDgSLbik697HzUq1AkslxC/WQ7DlGTa/Z9G9SLuml1w+xPOFprzCqJSEUEUNGUIi+gqargjeCq4hW0gKjB7qulFkcVfWm48JWLCBlEQOJJ4fkkf8/H5b+CmBU6EzPqULbwabO6/CruSfuQ8Silbo8Qg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583758289719669.0849435199653; Mon, 9 Mar 2020 05:51:29 -0700 (PDT) Received: from localhost ([::1]:42672 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHsW-0000y8-Ke for importer@patchew.org; Mon, 09 Mar 2020 08:51:28 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34090) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHne-0003Ky-39 for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHnc-0003j1-Ns for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:24201 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBHnc-0003gq-JF for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-350-yJ2975WcP_S90FApG6NlaQ-1; Mon, 09 Mar 2020 08:46:21 -0400 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 8C92F801F75 for ; Mon, 9 Mar 2020 12:46:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id A65C28FBE0; Mon, 9 Mar 2020 12:46:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3087D11385F4; Mon, 9 Mar 2020 13:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583757983; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=Pa8QNbeLcCahskW5w7Cch3+nbAdBehrY2rXYQPR64YA=; b=ikJnUv4XieNpfkxpOYKAVtdQpfn3ngCqZuiYrUZuXLcr9jbdcP/Aq6OEeAMgjv8KZiR09e w/eyD9J+hC28yFefRXn6R0CTy9gyV3olW2tOnnEL6Xvyy5a9wblvRPtuK+ykMLPjPUEGQs xnyuOsUt1zIb8GpqQa9qKO6ztixUXkE= X-MC-Unique: yJ2975WcP_S90FApG6NlaQ-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 2/4] util/osdep: Improve error report by calling error_setg_win32() Date: Mon, 9 Mar 2020 13:46:14 +0100 Message-Id: <20200309124616.4372-3-armbru@redhat.com> In-Reply-To: <20200309124616.4372-1-armbru@redhat.com> References: <20200309124616.4372-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200228100726.8414-3-philmd@redhat.com> Signed-off-by: Markus Armbruster --- util/osdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index f7d06050f7..4829c07ff6 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -82,8 +82,8 @@ static int qemu_mprotect__osdep(void *addr, size_t size, = int prot) DWORD old_protect; =20 if (!VirtualProtect(addr, size, prot, &old_protect)) { - error_report("%s: VirtualProtect failed with error code %ld", - __func__, GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + error_report("%s: VirtualProtect failed: %s", __func__, emsg); return -1; } return 0; --=20 2.21.1 From nobody Thu Nov 13 23:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583758215; cv=none; d=zohomail.com; s=zohoarc; b=c0aHbtgxuZfN19b3Sri+vOzgtTcLdAWj/hfSO9SX1GyZmSO+JVxpFkX5R47l09/haRD51D4lr5v60fFX2fTnl1pAeUiGETLTk1aV0IDvU6FWzjmMmNdXNNOGuXo1FthhnOMPlWW6t4VUE2GCzA2U/lWOrnuCgEqwepdoKPm5J90= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583758215; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=L8tKS53m/iCX/+e3eTiv7utNTL7Cedo93PaSY2b3hTE=; b=Za3N+fJpAgQCITwX6UguqpEGtLVY9lAG9J387i6+xQJxQIo8Ags+7aH+40U3l2zZ72iScFoch4oH/RjqVaIt7Eh/qnYIJR2TEMNbhlZKLUTH5agGKPFO+ZKuR8EzXce2mpmosSdrtgtTzj5ybXxLK9nhR7bN+VESkN5cT2uk7AQ= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583758215752160.5233516350154; Mon, 9 Mar 2020 05:50:15 -0700 (PDT) Received: from localhost ([::1]:42626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHrK-0007Cu-1u for importer@patchew.org; Mon, 09 Mar 2020 08:50:14 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34097) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHne-0003Li-G0 for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:27 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHnd-0003kX-AT for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:26 -0400 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:45066 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBHnd-0003jJ-6B for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:25 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-62-9OEzc6jDOLCG2LOoTIYPsw-1; Mon, 09 Mar 2020 08:46:23 -0400 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 463CA1084441 for ; Mon, 9 Mar 2020 12:46:22 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id AAC4C91D84; Mon, 9 Mar 2020 12:46:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3A3EE1138611; Mon, 9 Mar 2020 13:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583757984; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=L8tKS53m/iCX/+e3eTiv7utNTL7Cedo93PaSY2b3hTE=; b=dob72mqr0k9JBq87yJUerHxWSN8ob8TL1r9XBg7WrDep6xHmMm/HPcVbj7t/kvfezJucf8 OJB3Md+JZ4rDg59HTa0s+y26p7+fuXAreuMxi+tW94YYpkwfK7iXkHmxHMfSi8Y8vrq8eC Ipw+aGher+zQRpZQBheKJTbt9Q6ymLY= X-MC-Unique: 9OEzc6jDOLCG2LOoTIYPsw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 3/4] qga: Improve error report by calling error_setg_win32() Date: Mon, 9 Mar 2020 13:46:15 +0100 Message-Id: <20200309124616.4372-4-armbru@redhat.com> In-Reply-To: <20200309124616.4372-1-armbru@redhat.com> References: <20200309124616.4372-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Use error_setg_win32() which adds a hint similar to strerror(errno)). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200228100726.8414-4-philmd@redhat.com> Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Markus Armbruster --- qga/channel-win32.c | 3 ++- qga/commands-win32.c | 8 +++++--- 2 files changed, 7 insertions(+), 4 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index c86f4388db..99648c95b6 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -308,7 +308,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, } =20 if (method =3D=3D GA_CHANNEL_ISA_SERIAL && !SetCommTimeouts(c->handle,= &comTimeOut)) { - g_critical("error setting timeout for com port: %lu",GetLastError(= )); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error setting timeout for com port: %s", emsg); CloseHandle(c->handle); return false; } diff --git a/qga/commands-win32.c b/qga/commands-win32.c index 2461fd19bf..9c744d6405 100644 --- a/qga/commands-win32.c +++ b/qga/commands-win32.c @@ -315,8 +315,9 @@ void qmp_guest_shutdown(bool has_mode, const char *mode= , Error **errp) } =20 if (!ExitWindowsEx(shutdown_flag, SHTDN_REASON_FLAG_PLANNED)) { - slog("guest-shutdown failed: %lu", GetLastError()); - error_setg(errp, QERR_UNDEFINED_ERROR); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("guest-shutdown failed: %s", emsg); + error_setg_win32(errp, GetLastError(), "guest-shutdown failed"); } } =20 @@ -1319,7 +1320,8 @@ static DWORD WINAPI do_suspend(LPVOID opaque) DWORD ret =3D 0; =20 if (!SetSuspendState(*mode =3D=3D GUEST_SUSPEND_MODE_DISK, TRUE, TRUE)= ) { - slog("failed to suspend guest, %lu", GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + slog("failed to suspend guest: %s", emsg); ret =3D -1; } g_free(mode); --=20 2.21.1 From nobody Thu Nov 13 23:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583758102; cv=none; d=zohomail.com; s=zohoarc; b=mhT//A+mRwihz6bFQq8CA8TW3d13Ci39tGnIOFMQGY4wG82sgA/HIJ/qfFfeG+hUIyuEsKeNLh1UmcjNYw2vQvBexh5wXTLpPnvggtq/C6XyD1fOsflyTOw0httWgBnZEWcZQ3NOMu8M7uFxuaHE7J4tSyVWD7ckrmhyZrsKKhY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583758102; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lPQjXK5ETHlYkUMI1elw/jGPVQSoRwHq5UhQCxjmK6o=; b=Cree4AlbgOgkMwf3ghy2kj+pI1LbbvBOPgXkx5NBR3rIvUi6Y0lq+ihcJPoZTBkqdR1okRQ5i4MQaqNHRgzfwKDfaTCDtzDmuNW/paaoUvC0eyEnMde9gZ/PfiVtlYTTgkP5rnWVU8Nz+oDtGVxzzo52ACkgBOkowIBxS6fSxjw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583758102984251.41443502726872; Mon, 9 Mar 2020 05:48:22 -0700 (PDT) Received: from localhost ([::1]:42584 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHpV-0004bp-TV for importer@patchew.org; Mon, 09 Mar 2020 08:48:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34065) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jBHnd-0003Jb-7R for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1jBHnc-0003hm-5X for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:25 -0400 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:23986 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1jBHnc-0003fm-1p for qemu-devel@nongnu.org; Mon, 09 Mar 2020 08:46:24 -0400 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-312-8ivVQmBdPeSwMIFoHxS8gw-1; Mon, 09 Mar 2020 08:46:21 -0400 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 697FD18A6EC1 for ; Mon, 9 Mar 2020 12:46:20 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-34.ams2.redhat.com [10.36.116.34]) by smtp.corp.redhat.com (Postfix) with ESMTPS id ACD935DA2C; Mon, 9 Mar 2020 12:46:17 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 3EB3311366CB; Mon, 9 Mar 2020 13:46:16 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583757982; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lPQjXK5ETHlYkUMI1elw/jGPVQSoRwHq5UhQCxjmK6o=; b=RNg+eJq4cViT+Kplg6E4oYaBeWcE/LN+J+W912zjYkOvkciqnAa7g4JWBpcscw1WQEDC0b 2YFH8HNAj+yO/7bjx//nTC8vb61uKVSDMrx6eqbkRLxWvvKL+eQDIr+Qow2o7RUg09WLID yS6FV0V/tf4i4rlllJvAMUexsDp/i18= X-MC-Unique: 8ivVQmBdPeSwMIFoHxS8gw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PULL 4/4] qga: Fix a memory leak Date: Mon, 9 Mar 2020 13:46:16 +0100 Message-Id: <20200309124616.4372-5-armbru@redhat.com> In-Reply-To: <20200309124616.4372-1-armbru@redhat.com> References: <20200309124616.4372-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 The string returned by g_win32_error_message() has to be deallocated with g_free(). Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 Message-Id: <20200228100726.8414-5-philmd@redhat.com> Signed-off-by: Markus Armbruster --- qga/channel-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index 99648c95b6..4f04868a76 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -302,8 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, OPEN_EXISTING, FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, = NULL); if (c->handle =3D=3D INVALID_HANDLE_VALUE) { - g_critical("error opening path %s: %s", newpath, - g_win32_error_message(GetLastError())); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error opening path %s: %s", newpath, emsg); return false; } =20 --=20 2.21.1