From nobody Thu Nov 13 23:25:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=reject dis=none) header.from=google.com ARC-Seal: i=1; a=rsa-sha256; t=1583438848; cv=none; d=zohomail.com; s=zohoarc; b=mATnunez0y3t3fVlCG3jARiY9p4aeJ98Y8pI2WK36uR58jMQqmIahCjgNKbT0vlwtLRnyOk2XXJYDIWhfDNRVOJ2VD7Y9vigfbItHimw9Zqp+I3cnu3Vmf9quDJpfat5uStdxoOI/TnqqD7Q6GZl0w0Xyxlz8v+Yh/AEtvhdhfc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583438848; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=b63i01lsSfJx7hLAgSRmKetc+8kJVR1BV3dRy9ZDD/M=; b=ZvR3LW9qvXjx0cVORMLfy3KOsfpBCsqmhQddoufvLSgUoT89eH7fgRasxAfglPOsV7iu/9yreHzq3O74ibR54Z2Q7MD7c08H0zWe0hOkLFze+jiGyeNR8si+o7PyhnKyIgTM+eljzjxuIY76iQXD2PG3uywEux/R9XrH1Njb/tw= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=reject dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583438848503352.54807478648013; Thu, 5 Mar 2020 12:07:28 -0800 (PST) Received: from localhost ([::1]:55698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9wmE-0002qk-Gf for importer@patchew.org; Thu, 05 Mar 2020 15:07:26 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40269) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9wlF-0001ao-4r for qemu-devel@nongnu.org; Thu, 05 Mar 2020 15:06:26 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9wlE-0000PG-5G for qemu-devel@nongnu.org; Thu, 05 Mar 2020 15:06:25 -0500 Received: from mail-pj1-x1036.google.com ([2607:f8b0:4864:20::1036]:40338) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9wlD-0000Nc-VU for qemu-devel@nongnu.org; Thu, 05 Mar 2020 15:06:24 -0500 Received: by mail-pj1-x1036.google.com with SMTP id gv19so42591pjb.5 for ; Thu, 05 Mar 2020 12:06:23 -0800 (PST) Received: from localhost ([2620:0:1000:2514:23a5:d584:6a92:3e3c]) by smtp.gmail.com with ESMTPSA id a31sm17720146pgl.58.2020.03.05.12.06.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 12:06:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding:cc:from:to; bh=b63i01lsSfJx7hLAgSRmKetc+8kJVR1BV3dRy9ZDD/M=; b=I209DxEjoQUE/FsCcOD1BKvPwiq27ntLeqSCSKiXP9UFemQCPZaiSxNUjwfDarSinZ udjxSGaintD9P1Z0/QfIJhA0eYUhQtsZobVl8sC5yhIviolU0m0Qs7WU1+8MZkkfRGzl gQ9g3Ca5x64Od6Drq6cNaaUs4RjYAp/zi27Rm/p0fBGUhR06DrzVeP/JYz50daL2bbk1 2w+ErsARypoOhaawzQCs0wdreleNvQ0Iy/417cDHocdukvNkw9Qv/mOy1cSouiuOjSo1 l8pnyCIJWMo7/5+/NdsheNGykkKH3zv3XzXWdu0+zsJ/LkzXCyMp1YtF5PZ6CJsQShzi NBkg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:cc:from:to; bh=b63i01lsSfJx7hLAgSRmKetc+8kJVR1BV3dRy9ZDD/M=; b=sfAvB/12WwdmsuqdlFAJgMNgia4J62CjHgci36diGpeczf+XmluWVi3hZSPAM9ycc8 Or2oic/ehbGyYljUaQIff+QMy9DM9NSVmqp7WiphrGLuZahtDmUKaD+IgPNGoXqbP8b+ 2NK7hvhnaUU+pBdgFocWp/29W2NrBVaU+mQBHXsdxV76CG6c0Jk5HNXcBuy1GjLaOaMG BuFpZseGQ15mep+Eu5w0Zzptd7pGTtZwhRaIOlXvePmcrsb/XHB2QIsYDHRcAFAnGkpg MFTEfTwUQEHRuuq/0EEvvNH0Js7b3bUCFm9d6xCRaJ/JueBeLuZQ5V5cHnTpPTQGbJNY 5fBA== X-Gm-Message-State: ANhLgQ1OaBQgve6kkxgwyssdF9N1daC5GZ1Vc0GnaIL7YX2+qk89w4mZ CumzvAwZh3zRWcH65JDs+PF4IQ== X-Google-Smtp-Source: ADFU+vsPippyY3Nu2KwbDC+8ysPr6KXyNijNGebG4nkVJrKrUv0ktWRusvpCpuibKSa7I2l/npMyNA== X-Received: by 2002:a17:902:6bcb:: with SMTP id m11mr567459plt.10.1583438782876; Thu, 05 Mar 2020 12:06:22 -0800 (PST) Subject: [PULL] RISC-V: Add a missing "," in riscv_excp_names Date: Thu, 5 Mar 2020 12:05:58 -0800 Message-Id: <20200305200558.71104-2-palmerdabbelt@google.com> X-Mailer: git-send-email 2.25.0.265.gbab2e86ba0-goog In-Reply-To: <20200305200558.71104-1-palmerdabbelt@google.com> References: <20200305200558.71104-1-palmerdabbelt@google.com> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable Cc: qemu-riscv@nongnu.org, qemu-devel@nongnu.org, Palmer Dabbelt , ilippe=20Mathieu-Daud=C3=A9?= From: Palmer Dabbelt To: Peter Maydell X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::1036 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @google.com) This would almost certainly cause the exception names to be reported incorrectly. Coverity found the issue (CID 1420223). As per Peter's suggestion, I've also added a comma at the end of the list to avoid the iss= ue reappearing in the future. Fixes: ab67a1d07a ("target/riscv: Add support for the new execption numbers= ") Reviewed-by: Philippe Mathieu-Daud=C3=A9 Signed-off-by: Palmer Dabbelt --- target/riscv/cpu.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target/riscv/cpu.c b/target/riscv/cpu.c index c47d10b739..c0b7023100 100644 --- a/target/riscv/cpu.c +++ b/target/riscv/cpu.c @@ -66,7 +66,7 @@ const char * const riscv_excp_names[] =3D { "exec_page_fault", "load_page_fault", "reserved", - "store_page_fault" + "store_page_fault", "reserved", "reserved", "reserved", @@ -74,7 +74,7 @@ const char * const riscv_excp_names[] =3D { "guest_exec_page_fault", "guest_load_page_fault", "reserved", - "guest_store_page_fault" + "guest_store_page_fault", }; =20 const char * const riscv_intr_names[] =3D { --=20 2.25.0.265.gbab2e86ba0-goog