From nobody Fri Dec 19 14:32:18 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1583426985; cv=none; d=zohomail.com; s=zohoarc; b=lSoFOpzVoPyyfAUzOkNaLYxlV/OHADXo/KE11irJb1LpMPXDmqQG755fwP6T/krw5YIY3bWB4ynpSPYpJiCA2J49qKYqSYMqzKS0yplZD8z29EmJbio5Y0n9NN8evFE8ZvcEszHbqZP2jnlj6dnYztQZZ33zqvkAnWqSOO7lxHA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583426985; h=Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=WO6MlmMNplhxoUnWkFVSAFSYs5grFV+Q/M4i3h2rCwI=; b=PzCy8tnOldk8bKrmk/fdSxcR2hNGXSPzraVt1u/Pl+PiIGsocE+RCayUfvO+Og0yWsGsEEvUgV3Ef47nu+ZJQEuwfdnwlZJNfNstuinKZtjXHiUjbOe3BH2b/ejz6Fsd75vej6Ut2I6w6ThTNwx7vZd3ut3eB0OPRvVXSwu4nf4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583426985754859.1198520314655; Thu, 5 Mar 2020 08:49:45 -0800 (PST) Received: from localhost ([::1]:52852 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9tgu-0007vL-EO for importer@patchew.org; Thu, 05 Mar 2020 11:49:44 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:59206) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9tP5-0003RA-Hu for qemu-devel@nongnu.org; Thu, 05 Mar 2020 11:31:21 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9tP4-0002G6-C4 for qemu-devel@nongnu.org; Thu, 05 Mar 2020 11:31:19 -0500 Received: from mail-wm1-x32b.google.com ([2a00:1450:4864:20::32b]:36171) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9tP3-0002Du-Dq for qemu-devel@nongnu.org; Thu, 05 Mar 2020 11:31:17 -0500 Received: by mail-wm1-x32b.google.com with SMTP id g83so6437339wme.1 for ; Thu, 05 Mar 2020 08:31:16 -0800 (PST) Received: from orth.archaic.org.uk (orth.archaic.org.uk. [81.2.115.148]) by smtp.gmail.com with ESMTPSA id w22sm10310729wmk.34.2020.03.05.08.31.14 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Mar 2020 08:31:15 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:subject:date:message-id:in-reply-to:references:mime-version :content-transfer-encoding; bh=WO6MlmMNplhxoUnWkFVSAFSYs5grFV+Q/M4i3h2rCwI=; b=NVmGKZWSoiLVIP8O3WoaGkAUz+Cwo9gHnE4fr602Lc/OPm1pksvXMY/AmTmPX5ZvY1 kGUntyocYKQJmSPgwceDbWAc2A2oxUSvp2EWDW/xPqtc5KJDkzmx3luWbEh9j+P+AVVT CvmAIm5J50OcqxVuLdywePGr4YURErBGZ6TWIlwUkKRRPusg6gKgWqjIxWSK1iIDo+5W OycPUMwGehkXZUy6RVYs2mqN9//NZAHolvOdV+gm8wJgyFgSmYBi1dAsdSdicGnB/cqy 74xDOTMVtjq/4bVIaD32P+oJYTXA2GC6JEyUVsn3FYKqpl1kRGgUqnx+pQJt4sOaTNa5 S6eA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=WO6MlmMNplhxoUnWkFVSAFSYs5grFV+Q/M4i3h2rCwI=; b=Si9NUW3CHwZRfKiS/ssb6JO1v+AEFI+qt2YDbqmFPTaK4QkaGZuosw6hR/oYkytk/g uX2U1m91cfA+K430/LaFMkRMHBTj6YB0c3zhbMjK3wJ1VbFW0dZrPw3myrhWCvroweCR 2GKfe3ZbW9dTyspIfBk7zm02dQgW6jsr6ZpzJTeZEuCJ3wT9XDOWwDTOYKWWGo9ppPec eDXEgixtm75PTmOKR9GoloMXe/TIYBDWCMUCCe4SGnsY2p1zPdURWLZbXw54s0PsLOu1 k6DPKhH4eo6uy5hzWcrIBYtPJgYhUnP2Ks1GpJVMtEF3RUwE3/21cS9cy80yclSBXzjB NPPg== X-Gm-Message-State: ANhLgQ3meMMBqWbalm/x5F6XmeYIL0cT+bmNJmp+3B24pFj0elfgUlIL f9gh2X+b9xBF0mbLws0YHvSjSPjvzE88RQ== X-Google-Smtp-Source: ADFU+vu04e27+PF5VuIm571xYGq16mhP3QUoIWGP8gj7MiYzTCrSndGbPW3PL3pvfs1e5HUcC1L2ow== X-Received: by 2002:a05:600c:4108:: with SMTP id j8mr10357134wmi.188.1583425875784; Thu, 05 Mar 2020 08:31:15 -0800 (PST) From: Peter Maydell To: qemu-devel@nongnu.org Subject: [PULL 12/37] hw/arm/spitz: move timer_new from init() into realize() to avoid memleaks Date: Thu, 5 Mar 2020 16:30:35 +0000 Message-Id: <20200305163100.22912-13-peter.maydell@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200305163100.22912-1-peter.maydell@linaro.org> References: <20200305163100.22912-1-peter.maydell@linaro.org> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::32b X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @linaro.org) Content-Type: text/plain; charset="utf-8" From: Pan Nengyuan There are some memleaks when we call 'device_list_properties'. This patch m= ove timer_new from init into realize to fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Message-id: 20200227025055.14341-4-pannengyuan@huawei.com Reviewed-by: Peter Maydell Signed-off-by: Peter Maydell --- hw/arm/spitz.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index e0010881038..cbfa6934cfd 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -524,11 +524,16 @@ static void spitz_keyboard_init(Object *obj) =20 spitz_keyboard_pre_map(s); =20 - s->kbdtimer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, spitz_keyboard_tick, = s); qdev_init_gpio_in(dev, spitz_keyboard_strobe, SPITZ_KEY_STROBE_NUM); qdev_init_gpio_out(dev, s->sense, SPITZ_KEY_SENSE_NUM); } =20 +static void spitz_keyboard_realize(DeviceState *dev, Error **errp) +{ + SpitzKeyboardState *s =3D SPITZ_KEYBOARD(dev); + s->kbdtimer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, spitz_keyboard_tick, = s); +} + /* LCD backlight controller */ =20 #define LCDTG_RESCTL 0x00 @@ -1115,6 +1120,7 @@ static void spitz_keyboard_class_init(ObjectClass *kl= ass, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_spitz_kbd; + dc->realize =3D spitz_keyboard_realize; } =20 static const TypeInfo spitz_keyboard_info =3D { --=20 2.20.1