From nobody Thu Nov 13 23:13:05 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583358095; cv=none; d=zohomail.com; s=zohoarc; b=ExlfigdisGBv1Gz0oGeoRnRf09kFQ4IvS8rv/jZu+OjtnrFOmz754XhmUwQSn1IUuGFh+OTlq1HCIs97evSiDHQo6FSabiON8Qc6ooqRYtmKrEcALvyZIvx8LBYkVxZg1sN8f2lbYB+20dYHVuUDFGenZg3fpcu0u7AQlie8p9Y= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583358095; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=TyrFi/qrlOUtisnFzCsxIVGnd6k+XlrWXOj3/Nom2UQ=; b=fFDxmDOQPiueMrBH29uVauiBb/q5s7zm4DdZbn2XHybmEQd/LIgt3Bv5Sx+15810gD3DLMdjC75Wv1DmqGLKfcy6Xqe1QdxPdo2tfZ3csL5SxDkL4TjmRTzPmRoWMNIAJqYwdzJG+Vask59eL2uFVcIfvAjGENrbaMv9vzPYZ38= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583358095744962.0401581625358; Wed, 4 Mar 2020 13:41:35 -0800 (PST) Received: from localhost ([::1]:40138 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9blm-00033f-P0 for importer@patchew.org; Wed, 04 Mar 2020 16:41:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:52143) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9bio-0006CV-7b for qemu-devel@nongnu.org; Wed, 04 Mar 2020 16:38:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9bim-0007Z7-UY for qemu-devel@nongnu.org; Wed, 04 Mar 2020 16:38:30 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:51479 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9bim-0007Yj-Qh for qemu-devel@nongnu.org; Wed, 04 Mar 2020 16:38:28 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-432-DDopLU4xMRO03ackKCqaeA-1; Wed, 04 Mar 2020 16:38:25 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EB89A107ACCA; Wed, 4 Mar 2020 21:38:24 +0000 (UTC) Received: from probe.redhat.com (ovpn-120-212.rdu2.redhat.com [10.10.120.212]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9D06A5C1D4; Wed, 4 Mar 2020 21:38:23 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583357908; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=TyrFi/qrlOUtisnFzCsxIVGnd6k+XlrWXOj3/Nom2UQ=; b=gT2ePug7I01H5aJ448ZqvSWTw8NBnNLGUHSdBc14fRW6vhknl0OigQEQM0QUFuv9evvfv/ kn9gLipBm8ugvih9nxg+Xd/hRljYPwlPUOqiksy4QbnYbzFPV04XcGfcG+I1GdAWy0IQJo c4iFUopQMlSbERUMGbUnhn9Mce7jjaA= X-MC-Unique: DDopLU4xMRO03ackKCqaeA-1 From: John Snow To: qemu-devel@nongnu.org Subject: [PATCH v7 04/10] iotests: replace mutable list default args Date: Wed, 4 Mar 2020 16:38:12 -0500 Message-Id: <20200304213818.15341-5-jsnow@redhat.com> In-Reply-To: <20200304213818.15341-1-jsnow@redhat.com> References: <20200304213818.15341-1-jsnow@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , qemu-block@nongnu.org, armbru@redhat.com, Max Reitz , John Snow , philmd@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" It's bad hygiene: if we modify this list, it will be modified across all invocations. (Remaining bad usages are fixed in a subsequent patch which changes the function signature anyway.) Signed-off-by: John Snow Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- tests/qemu-iotests/iotests.py | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-) diff --git a/tests/qemu-iotests/iotests.py b/tests/qemu-iotests/iotests.py index fd65b90691..54d68774e1 100644 --- a/tests/qemu-iotests/iotests.py +++ b/tests/qemu-iotests/iotests.py @@ -136,7 +136,7 @@ def qemu_img_log(*args): log(result, filters=3D[filter_testfiles]) return result =20 -def img_info_log(filename, filter_path=3DNone, imgopts=3DFalse, extra_args= =3D[]): +def img_info_log(filename, filter_path=3DNone, imgopts=3DFalse, extra_args= =3D()): args =3D ['info'] if imgopts: args.append('--image-opts') @@ -350,7 +350,7 @@ def _filter(_key, value): return value return filter_qmp(qmsg, _filter) =20 -def log(msg, filters=3D[], indent=3DNone): +def log(msg, filters=3D(), indent=3DNone): '''Logs either a string message or a JSON serializable message (like Q= MP). If indent is provided, JSON serializable messages are pretty-printed.'= '' for flt in filters: @@ -566,7 +566,7 @@ def get_qmp_events_filtered(self, wait=3D60.0): result.append(filter_qmp_event(ev)) return result =20 - def qmp_log(self, cmd, filters=3D[], indent=3DNone, **kwargs): + def qmp_log(self, cmd, filters=3D(), indent=3DNone, **kwargs): full_cmd =3D OrderedDict(( ("execute", cmd), ("arguments", ordered_qmp(kwargs)) @@ -967,7 +967,7 @@ def case_notrun(reason): open('%s/%s.casenotrun' % (output_dir, seq), 'a').write( ' [case not run] ' + reason + '\n') =20 -def verify_image_format(supported_fmts=3D[], unsupported_fmts=3D[]): +def verify_image_format(supported_fmts=3D(), unsupported_fmts=3D()): assert not (supported_fmts and unsupported_fmts) =20 if 'generic' in supported_fmts and \ @@ -981,7 +981,7 @@ def verify_image_format(supported_fmts=3D[], unsupporte= d_fmts=3D[]): if not_sup or (imgfmt in unsupported_fmts): notrun('not suitable for this image format: %s' % imgfmt) =20 -def verify_protocol(supported=3D[], unsupported=3D[]): +def verify_protocol(supported=3D(), unsupported=3D()): assert not (supported and unsupported) =20 if 'generic' in supported: @@ -1000,11 +1000,11 @@ def verify_platform(supported=3DNone, unsupported= =3DNone): if not any((sys.platform.startswith(x) for x in supported)): notrun('not suitable for this OS: %s' % sys.platform) =20 -def verify_cache_mode(supported_cache_modes=3D[]): +def verify_cache_mode(supported_cache_modes=3D()): if supported_cache_modes and (cachemode not in supported_cache_modes): notrun('not suitable for this cache mode: %s' % cachemode) =20 -def verify_aio_mode(supported_aio_modes=3D[]): +def verify_aio_mode(supported_aio_modes=3D()): if supported_aio_modes and (aiomode not in supported_aio_modes): notrun('not suitable for this aio mode: %s' % aiomode) =20 @@ -1044,7 +1044,7 @@ def supported_formats(read_only=3DFalse): =20 return supported_formats.formats[read_only] =20 -def skip_if_unsupported(required_formats=3D[], read_only=3DFalse): +def skip_if_unsupported(required_formats=3D(), read_only=3DFalse): '''Skip Test Decorator Runs the test if all the required formats are whitelisted''' def skip_test_decorator(func): @@ -1095,11 +1095,11 @@ def execute_unittest(output, verbosity, debug): sys.stderr.write(out) =20 def execute_test(test_function=3DNone, - supported_fmts=3D[], + supported_fmts=3D(), supported_platforms=3DNone, - supported_cache_modes=3D[], supported_aio_modes=3D{}, - unsupported_fmts=3D[], supported_protocols=3D[], - unsupported_protocols=3D[]): + supported_cache_modes=3D(), supported_aio_modes=3D(), + unsupported_fmts=3D(), supported_protocols=3D(), + unsupported_protocols=3D()): """Run either unittest or script-style tests.""" =20 # We are using TEST_DIR and QEMU_DEFAULT_MACHINE as proxies to --=20 2.21.1