From nobody Thu Nov 13 22:05:38 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1583337784; cv=none; d=zohomail.com; s=zohoarc; b=aAgAZTtI4QS9u5VKQvsS1ecJXIlRfVsRzbN3x5+PuuOG1axs6McIkONkRRnvZHiaOT0ETHVcm3XlmZAgqNo2fFnZzX1aBh9qbzrAi3iL4f8tsGPH5jSVcSaD3rn7nRW+/d/C1DdcJhp5Zs+OUhVkgCkSA/2UHnDLZTquKTYt81s= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583337784; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=06zdHOw+xSmaPYF8c1OfxmcdcNYvsYDvK3aPeEqAKAA=; b=J1vloY5Zxi5VtbpfPxtfhEeqUAR/rqKB6xcqr4Z0VoYSmWxVwV/IPStBkHvVd5tG/fAE6LLAR5//EOKNQxdFmaYhyWZ4br312qOWVEc4ISDiu8ceFOaszED6L0XOFw1L/wGRxY8P1V1gzrcoirUgJOEgwQpoP5IL2eAPmmf1vzc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583337784531877.2086907302119; Wed, 4 Mar 2020 08:03:04 -0800 (PST) Received: from localhost ([::1]:36190 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9WUB-0005H6-Cw for importer@patchew.org; Wed, 04 Mar 2020 11:03:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:51828) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9WQv-00013T-Vq for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:59:43 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9WQu-0007Vd-Pq for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:59:41 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:59736 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j9WQu-0007VA-MJ for qemu-devel@nongnu.org; Wed, 04 Mar 2020 10:59:40 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-204-ZgbNaz40NCeBU3Hx522hBw-1; Wed, 04 Mar 2020 10:59:36 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6BAFA8024DF; Wed, 4 Mar 2020 15:59:35 +0000 (UTC) Received: from blackfin.pond.sub.org (ovpn-116-129.ams2.redhat.com [10.36.116.129]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 11B9691D93; Wed, 4 Mar 2020 15:59:34 +0000 (UTC) Received: by blackfin.pond.sub.org (Postfix, from userid 1000) id 909BF11385F4; Wed, 4 Mar 2020 16:59:32 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1583337580; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=06zdHOw+xSmaPYF8c1OfxmcdcNYvsYDvK3aPeEqAKAA=; b=alQll1LX+gfO6HLz5NrZiKIIB42Wp1gdbXR6foqi3OGuic9Y4x67tqHGlHB/QwINpeKfn0 ZKC/0qziHQyAfwh6HTrm/xNYdLMK7bH6HvjAtB1yqtpLT54u15hYKNZLbkFwg1JlEihfoQ Qjmq8as4IEKar4sJOXwoThYJnAr+rlA= X-MC-Unique: ZgbNaz40NCeBU3Hx522hBw-1 From: Markus Armbruster To: qemu-devel@nongnu.org Subject: [PATCH v2 2/4] qapi: Drop conditionals for Python 2 Date: Wed, 4 Mar 2020 16:59:30 +0100 Message-Id: <20200304155932.20452-3-armbru@redhat.com> In-Reply-To: <20200304155932.20452-1-armbru@redhat.com> References: <20200304155932.20452-1-armbru@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: mdroth@linux.vnet.ibm.com, philmd@redhat.com, jsnow@redhat.com, ehabkost@redhat.com, crosa@redhat.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Signed-off-by: Markus Armbruster Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: John Snow --- scripts/qapi/common.py | 6 +----- scripts/qapi/gen.py | 6 +----- scripts/qapi/parser.py | 6 +----- tests/qapi-schema/test-qapi.py | 6 +----- 4 files changed, 4 insertions(+), 20 deletions(-) diff --git a/scripts/qapi/common.py b/scripts/qapi/common.py index e00dcafce7..ba35abea47 100644 --- a/scripts/qapi/common.py +++ b/scripts/qapi/common.py @@ -12,7 +12,6 @@ # See the COPYING file in the top-level directory. =20 import re -import string =20 =20 # ENUMName -> ENUM_NAME, EnumName1 -> ENUM_NAME1 @@ -43,10 +42,7 @@ def c_enum_const(type_name, const_name, prefix=3DNone): return camel_to_upper(type_name) + '_' + c_name(const_name, False).upp= er() =20 =20 -if hasattr(str, 'maketrans'): - c_name_trans =3D str.maketrans('.-', '__') -else: - c_name_trans =3D string.maketrans('.-', '__') +c_name_trans =3D str.maketrans('.-', '__') =20 =20 # Map @name to a valid C identifier. diff --git a/scripts/qapi/gen.py b/scripts/qapi/gen.py index a53a705c73..317cd72601 100644 --- a/scripts/qapi/gen.py +++ b/scripts/qapi/gen.py @@ -15,7 +15,6 @@ import errno import os import re -import sys from contextlib import contextmanager =20 from qapi.common import * @@ -54,10 +53,7 @@ class QAPIGen: if e.errno !=3D errno.EEXIST: raise fd =3D os.open(pathname, os.O_RDWR | os.O_CREAT, 0o666) - if sys.version_info[0] >=3D 3: - f =3D open(fd, 'r+', encoding=3D'utf-8') - else: - f =3D os.fdopen(fd, 'r+') + f =3D open(fd, 'r+', encoding=3D'utf-8') text =3D self.get_content() oldtext =3D f.read(len(text) + 1) if text !=3D oldtext: diff --git a/scripts/qapi/parser.py b/scripts/qapi/parser.py index 2e3a3c5d76..cf14e5426c 100644 --- a/scripts/qapi/parser.py +++ b/scripts/qapi/parser.py @@ -16,7 +16,6 @@ =20 import os import re -import sys from collections import OrderedDict =20 from qapi.error import QAPIParseError, QAPISemError @@ -30,10 +29,7 @@ class QAPISchemaParser: previously_included.add(os.path.abspath(fname)) =20 try: - if sys.version_info[0] >=3D 3: - fp =3D open(fname, 'r', encoding=3D'utf-8') - else: - fp =3D open(fname, 'r') + fp =3D open(fname, 'r', encoding=3D'utf-8') self.src =3D fp.read() except IOError as e: raise QAPISemError(incl_info or QAPISourceInfo(None, None, Non= e), diff --git a/tests/qapi-schema/test-qapi.py b/tests/qapi-schema/test-qapi.py index 41232c11a3..bee18ee344 100755 --- a/tests/qapi-schema/test-qapi.py +++ b/tests/qapi-schema/test-qapi.py @@ -16,15 +16,11 @@ import argparse import difflib import os import sys +from io import StringIO =20 from qapi.error import QAPIError from qapi.schema import QAPISchema, QAPISchemaVisitor =20 -if sys.version_info[0] < 3: - from cStringIO import StringIO -else: - from io import StringIO - =20 class QAPISchemaTestVisitor(QAPISchemaVisitor): =20 --=20 2.21.1