From nobody Thu Nov 13 21:53:32 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583260441; cv=none; d=zohomail.com; s=zohoarc; b=nEFnKT3RBra7ld3/RTy//ZgxVXNfL+uEis2EceYGua3rtRHlYpQhb6vB4jv3dcXOACKwXw7OkZbUsol9Nldz/nmxXQjAq9mvoInOUSWY/OSjafxMu3VRtC8Ys1hzUmpH0nFWcban6Ank+CyQT6NcC4BXS5V3qNY/TPFkmfbYQNs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583260441; h=Content-Transfer-Encoding:Cc:Date:From:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:Sender:Subject:To; bh=Kyh53JczQ540B6ROGldcn//ND2e8k3HqYjeQ0Xz6uts=; b=IdzaGsEf0yk4m4U2lNoTYNN5tejAs75RsumV3yNxs33cdpEyrD3qkjrZDLhbLAycejZZ4aQy+Hu7H1qy7hfDQN9sQ2GK06HKrSl8ej5zOugZNpq4ZHUuICo6xwP71GjMDcTnwSZkmJcgaWhPf1WB44JFCLpdQpcX6fCykEezBX4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583260440806377.0701533810592; Tue, 3 Mar 2020 10:34:00 -0800 (PST) Received: from localhost ([::1]:51632 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9CMg-0003x7-Ow for importer@patchew.org; Tue, 03 Mar 2020 13:33:58 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:43875) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j9Bt1-0008Gv-4l for qemu-devel@nongnu.org; Tue, 03 Mar 2020 13:03:20 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j9Bsz-0005Du-P8 for qemu-devel@nongnu.org; Tue, 03 Mar 2020 13:03:19 -0500 Received: from mail-lf1-x142.google.com ([2a00:1450:4864:20::142]:38118) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j9Bsz-0005Cz-6Q for qemu-devel@nongnu.org; Tue, 03 Mar 2020 13:03:17 -0500 Received: by mail-lf1-x142.google.com with SMTP id x22so2520887lff.5 for ; Tue, 03 Mar 2020 10:03:16 -0800 (PST) Received: from navi.cosmonova.net.ua ([95.67.24.131]) by smtp.gmail.com with ESMTPSA id k11sm1389872lfd.17.2020.03.03.10.03.13 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 03 Mar 2020 10:03:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=daynix-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Kyh53JczQ540B6ROGldcn//ND2e8k3HqYjeQ0Xz6uts=; b=RJyc1LixzgMuCad9/rMsQrtqzRUxqfPsIBPKFumd1J6PSUmiHVCOW6OS9Kr/He0dBV mS8zm8vlwzB41KuIiAqrEgcWcmlLOsIS/3GxH7icPllZzTES2NJuTPouwS1CGUAuJZzh N4yaAOHcMPjzTfQmnowZlnLkQMoVmHxTVmYU8cJjbh+mj26YJAuyXMg63XkNa6tNGO4J cHza++fxTxEL+QfvZuEgssXF6kSf7JicAA8t2NMbqxL1jKAC3rCDtd89+WlP2L7gcHwp /MdMBxXxUQy5VBchhsCoDw3yYomgTBqpqZpufcdCYdhU2sZ50REq9wWsXkOukR6if2Jh SBxQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Kyh53JczQ540B6ROGldcn//ND2e8k3HqYjeQ0Xz6uts=; b=J26G4qpWe4BI+AXHLU1miqB1lqxmTH3z3qxZkTOnm9HEdBcZnmAQZT5qHg0CNh66jz kxPsKNniisG7WhNWCbUxgndbgABDHCmbpQlXgMC5p8XS3XJMWHjKqffsI7tdzrnqBN+p g/f9spapRrUpnlIoBRHN1lptI9rRMqMbo17xrMsQ2aCKoAkLHeAEDTVPW5/7Ejxqh8CH 9rabEyWDTtbj0QFhMsHMu9o0iyzKysYXgEn6WWjaCfSzpNOPr/kHgHwWGxlWl3FlYvx5 NhXcMJctIWsy5dN3zUOHFc8id0Szup3RbJFj0b3q+IgcrrSpkMw4reUWj61i2wfpApoA g+6A== X-Gm-Message-State: ANhLgQ2016k67UYDpc6O0WFEkG6NLKZxE3UxWqY/XAdOVrTYs4DuCPlt NuzEhjpW/VjozHJ/XHJ5OpOv7si9+Nw= X-Google-Smtp-Source: ADFU+vs2ZYZCZk6hqWh1zCcW4xn3kM2YdgG7tCCeNe7mwL6++Zez7i5ZPylSOd3T673bkDurBTfN4w== X-Received: by 2002:a19:ee0a:: with SMTP id g10mr3528408lfb.182.1583258594771; Tue, 03 Mar 2020 10:03:14 -0800 (PST) From: andrew@daynix.com To: qemu-devel@nongnu.org Subject: [PATCH] Fixed integer overflow in e1000e Date: Tue, 3 Mar 2020 20:29:25 +0200 Message-Id: <20200303182925.39419-1-andrew@daynix.com> X-Mailer: git-send-email 2.24.1 MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::142 X-Mailman-Approved-At: Tue, 03 Mar 2020 13:32:50 -0500 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: dmitry.fleytman@gmail.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @daynix-com.20150623.gappssmtp.com) Content-Type: text/plain; charset="utf-8" From: Andrew Melnychenko https://bugzilla.redhat.com/show_bug.cgi?id=3D1737400 Fixed setting max_queue_num if there are no peers in NICConf. qemu_new_nic(= ) creates NICState with 1 NetClientState(index 0) without peers, set max_qu= eue_num to 0 - It prevents undefined behavior and possible crashes, especia= lly during pcie hotplug. Signed-off-by: Andrew Melnychenko --- hw/net/e1000e.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/net/e1000e.c b/hw/net/e1000e.c index a91dbdca3c..f2cc1552c5 100644 --- a/hw/net/e1000e.c +++ b/hw/net/e1000e.c @@ -328,7 +328,7 @@ e1000e_init_net_peer(E1000EState *s, PCIDevice *pci_dev= , uint8_t *macaddr) s->nic =3D qemu_new_nic(&net_e1000e_info, &s->conf, object_get_typename(OBJECT(s)), dev->id, s); =20 - s->core.max_queue_num =3D s->conf.peers.queues - 1; + s->core.max_queue_num =3D s->conf.peers.queues ? s->conf.peers.queues = - 1 : 0; =20 trace_e1000e_mac_set_permanent(MAC_ARG(macaddr)); memcpy(s->core.permanent_mac, macaddr, sizeof(s->core.permanent_mac)); --=20 2.24.1