From nobody Sun Sep 7 16:15:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154603; cv=none; d=zohomail.com; s=zohoarc; b=RlA/ns/FG14rl+6ywUuNMADbtH5lNFnZDoIQTRQUeRrNOp1JdMJUQ3kyJrFnr015nrkGVdwLTkPAD+2p2RFZxHif9PvcL/LrlSYozV6YG8+wnr2Vzd7fFacdxVjKttWSL5rkV1AbkRQWjbb76EmUb17quOfSUm3XGfXESAbkyL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bHbySloGXEBNpIAdka6JIs1MPKgGuQ4fBWs2uhx6Mmo=; b=XiEV8l0tT7tZXqcpJ5JdBY+QHpuArjmmOPYeoIEwN+xf3OERtAmtOImX2tOdDmvY5xLSjJSxFm/8ujwHSu7/ny2snvVj8NTODG4FkMp3EwrV6I8ycDTGaC5Vzj94gQW8CZ2he56MkjNAOVy+D4lnyPYGyDJXYeWHt4hwcfeS50g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154603508196.47924069029136; Mon, 2 Mar 2020 05:10:03 -0800 (PST) Received: from localhost ([::1]:60798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kpe-0001Sx-B3 for importer@patchew.org; Mon, 02 Mar 2020 08:10:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48911) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8ko7-0006pf-4E for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8ko4-0003SH-Ph for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:25 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51764 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8ko4-0003Ms-Dc; Mon, 02 Mar 2020 08:08:24 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 404A2974DEB5C69ADDAE; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:47 +0800 From: Chen Qun To: , Subject: [PATCH v3 05/12] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Mon, 2 Mar 2020 21:07:08 +0800 Message-ID: <20200302130715.29440-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen =3D req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) r->iov.iov_base =3D blk_blockalign(s->qdev.conf.blk, r->buflen); } =20 - buflen =3D req->cmd.xfer; outbuf =3D r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) { --=20 2.23.0