From nobody Sun Sep 7 16:16:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154666; cv=none; d=zohomail.com; s=zohoarc; b=VB4LiQleqstgmLKMw7eqNvJBV0p6Q+rSVOsNo7Fiosk+e+T7+p3OVxYRuRNSxdobsa904KEwkAHuE9Nu3gmN/I7bdrhwc5SB/UU4UNfToQ7X/JD4zyU3BU2Am/JDJ+G3Wlaejfl4jIpYEyIpWz5EDMbrdky5Rv/zT5tEI6seL8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154666; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S4is+Iffgmyj0nM9bX+nOe61OpQJ42ON2rWNiarS2G0=; b=SKjCwBx1+0thrvMCUoN8KUyQAAUBeoG5BybSBB/uQdg3QuS9Xuzu6OT9/E0cF72+b39IOpPqZMUMzKgyqUAb6G7uHto9d/MhwvCuNJsERcAs3wlVd3i7e5x26IPVnpto6IuzyX0rmf5X0XY4gSAbd+He7iwAWDedOzrCo9JjLFc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154666396228.6786836750473; Mon, 2 Mar 2020 05:11:06 -0800 (PST) Received: from localhost ([::1]:60828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kqf-0003mn-8K for importer@patchew.org; Mon, 02 Mar 2020 08:11:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48640) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Ff-Fs for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003MN-By for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51536 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8kng-0003Ip-Vp; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 30214E7C45B717FB405E; Mon, 2 Mar 2020 21:07:53 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:45 +0800 From: Chen Qun To: , Subject: [PATCH v3 01/12] block/stream: Remove redundant statement in stream_run() Date: Mon, 2 Mar 2020 21:07:04 +0800 Message-ID: <20200302130715.29440-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Max Reitz , Euler Robot , Chen Qun , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: John Snow Reviewed-by: Kevin Wolf --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz v1->v2:move 'ret' declaration to the for() statement(Base on Kevin's commen= ts). --- block/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/stream.c b/block/stream.c index 5562ccbf57..aa2e7af98e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) int64_t offset =3D 0; uint64_t delay_ns =3D 0; int error =3D 0; - int ret =3D 0; int64_t n =3D 0; /* bytes */ =20 if (bs =3D=3D s->bottom) { @@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) =20 for ( ; offset < len; offset +=3D n) { bool copy; + int ret; =20 /* Note that even when no rate limit is applied we need to yield * with no pending I/O here so that bdrv_drain_all() returns. @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) break; } } - ret =3D 0; =20 /* Publish progress */ job_progress_update(&s->common.job, n); --=20 2.23.0