From nobody Sun Sep 7 16:16:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583155049; cv=none; d=zohomail.com; s=zohoarc; b=HJlnopd6rN8gERD95EKEZPuQ+qcUyU3zz9DrX99v8UEYq9JrzLDmwxiyfPRjhqkErLgIpwzG9JsypnVyH0H9SJWMmJgX5EnZo/36R+u3LGYawK3eydkCB3URBTjOsMIm1Uvk+KqU3AWK2yg9kubdAWHIJoSEcWDuVhYys5PdCHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583155049; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=swIBMWmZY896DyJx23AzD0QZM+NQ5lJpwKZMOoG606o=; b=fjRSu+dDSP6vLuJ1jcKiif7y0g4koD0fpBPEpgz7J5Hfyl8XQAldIVqlV8zrFNYcEFdQHBLb2CjDiUvxHr4UyJdc5G/6/846SW1VZKC7ZBjnLnIY876YkK/aJGBLF8TJsanLjiibExZ76BEAZyVYf83sJrleY3wkaJ/jBfzs/vM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583155049128675.9997888525804; Mon, 2 Mar 2020 05:17:29 -0800 (PST) Received: from localhost ([::1]:60932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kwp-000448-Qe for importer@patchew.org; Mon, 02 Mar 2020 08:17:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48815) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006Gv-Uf for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knk-0003Pa-QF for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51768 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mq-K9; Mon, 02 Mar 2020 08:08:04 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 64C489648BA4CAF3AFE9; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:52 +0800 From: Chen Qun To: , Subject: [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Date: Mon, 2 Mar 2020 21:07:15 +0800 Message-ID: <20200302130715.29440-14-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, "Dr. David Alan Gilbert" , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set =3D true; ^ ~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- Cc: "Dr. David Alan Gilbert" Cc: Philippe Mathieu-Daud=C3=A9 v1->v2: move the 'set' declaration to the for() statement(Base on Philippe'= s suggestion). --- monitor/hmp-cmds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..c6b0495822 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) const char *name =3D qdict_get_str(qdict, "name"); uint8_t type =3D qdict_get_try_int(qdict, "type", 9); Error *err =3D NULL; - bool set =3D false; =20 list =3D qmp_query_rocker_of_dpa_groups(name, type !=3D 9, type, &err); if (err !=3D NULL) { @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) =20 for (g =3D list; g; g =3D g->next) { RockerOfDpaGroup *group =3D g->value; + bool set =3D false; =20 monitor_printf(mon, "0x%08x", group->id); =20 @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const Q= Dict *qdict) =20 if (group->has_set_eth_dst) { if (!set) { - set =3D true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst); } =20 - set =3D false; - if (group->has_ttl_check && group->ttl_check) { monitor_printf(mon, " check TTL"); } --=20 2.23.0