From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154666; cv=none; d=zohomail.com; s=zohoarc; b=VB4LiQleqstgmLKMw7eqNvJBV0p6Q+rSVOsNo7Fiosk+e+T7+p3OVxYRuRNSxdobsa904KEwkAHuE9Nu3gmN/I7bdrhwc5SB/UU4UNfToQ7X/JD4zyU3BU2Am/JDJ+G3Wlaejfl4jIpYEyIpWz5EDMbrdky5Rv/zT5tEI6seL8Q= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154666; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=S4is+Iffgmyj0nM9bX+nOe61OpQJ42ON2rWNiarS2G0=; b=SKjCwBx1+0thrvMCUoN8KUyQAAUBeoG5BybSBB/uQdg3QuS9Xuzu6OT9/E0cF72+b39IOpPqZMUMzKgyqUAb6G7uHto9d/MhwvCuNJsERcAs3wlVd3i7e5x26IPVnpto6IuzyX0rmf5X0XY4gSAbd+He7iwAWDedOzrCo9JjLFc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154666396228.6786836750473; Mon, 2 Mar 2020 05:11:06 -0800 (PST) Received: from localhost ([::1]:60828 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kqf-0003mn-8K for importer@patchew.org; Mon, 02 Mar 2020 08:11:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48640) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Ff-Fs for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003MN-By for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51536 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8kng-0003Ip-Vp; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 30214E7C45B717FB405E; Mon, 2 Mar 2020 21:07:53 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:45 +0800 From: Chen Qun To: , Subject: [PATCH v3 01/12] block/stream: Remove redundant statement in stream_run() Date: Mon, 2 Mar 2020 21:07:04 +0800 Message-ID: <20200302130715.29440-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Max Reitz , Euler Robot , Chen Qun , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: John Snow Reviewed-by: Kevin Wolf --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz v1->v2:move 'ret' declaration to the for() statement(Base on Kevin's commen= ts). --- block/stream.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/block/stream.c b/block/stream.c index 5562ccbf57..aa2e7af98e 100644 --- a/block/stream.c +++ b/block/stream.c @@ -114,7 +114,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) int64_t offset =3D 0; uint64_t delay_ns =3D 0; int error =3D 0; - int ret =3D 0; int64_t n =3D 0; /* bytes */ =20 if (bs =3D=3D s->bottom) { @@ -139,6 +138,7 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) =20 for ( ; offset < len; offset +=3D n) { bool copy; + int ret; =20 /* Note that even when no rate limit is applied we need to yield * with no pending I/O here so that bdrv_drain_all() returns. @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) break; } } - ret =3D 0; =20 /* Publish progress */ job_progress_update(&s->common.job, n); --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154631; cv=none; d=zohomail.com; s=zohoarc; b=M7Djba8XQHxqiScB6zjyCvcesp2GPhmJNldITvMUU1ED6lIQDAaGtgPo9542BQt8YOyPm7VncjDn28emBGkMa97SKTxkGsy3ZVdPHhvw8aLQJItK/GHGXEqOZGAfl7lWm8igiKLv2q+9XGjdnZTIw6xtZX2CGrP4r8voAc1Phw4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154631; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=1HlzjQYX4Zy+lirpA2NxtXwibURBf2L9m6a6lL70WAM=; b=Y5J34rzqCTnM73d+jkpn0ZOV7oYddQLr1Y8Fzo9Si2AmzhWqjCxsYpea/h0YCftb6o7Mki7YIUyFk/0/zCLSOsrY6twDQcR0Yy6XurRRUPbCENbKmUa6Y0lC94V5a9itGv7X6ykDokJ/IjXUoaTGAKco2xVo57PzTbQ3DDn2MEY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154631658804.896579051707; Mon, 2 Mar 2020 05:10:31 -0800 (PST) Received: from localhost ([::1]:60808 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kq6-0002g0-Ep for importer@patchew.org; Mon, 02 Mar 2020 08:10:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48641) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Fg-FQ for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003MO-By for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51528 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8kng-0003Iq-Vb; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 26024FA5F96E0F866802; Mon, 2 Mar 2020 21:07:53 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:46 +0800 From: Chen Qun To: , Subject: [PATCH v3 02/12] block/iscsi:Remove redundant statement in iscsi_open() Date: Mon, 2 Mar 2020 21:07:05 +0800 Message-ID: <20200302130715.29440-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Peter Lieven , Max Reitz , Ronnie Sahlberg , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read flags &=3D ~BDRV_O_RDWR; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Kevin Wolf --- Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Kevin Wolf Cc: Max Reitz v1->v2: Keep the 'flags' then use it(Base on Kevin's comments). --- block/iscsi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..50bae51700 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -2002,7 +2002,7 @@ static int iscsi_open(BlockDriverState *bs, QDict *op= tions, int flags, iscsilun->cluster_size =3D iscsilun->bl.opt_unmap_gran * iscsilun->block_size; if (iscsilun->lbprz) { - ret =3D iscsi_allocmap_init(iscsilun, bs->open_flags); + ret =3D iscsi_allocmap_init(iscsilun, flags); } } =20 --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154583; cv=none; d=zohomail.com; s=zohoarc; b=AsNpt5BuktEryOeBVhYzjw891HtMtf0XZfi3wDOp7tm0IV0HTNwfkC+HuxlfRu2a+en23aahZ4inSipusO3ldMXtdl7Xg/yqoDfzSi8NAFj8uAGubcbQJxQc+Tfv+b/bSiUBR1wLDMTm3sawwT4DZoW4NlIlCE91gNxj9ZysTqI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154583; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=sECWEgKqBHBx0zpQh9+5d8KIMDbFGi3AIvLzxI0nc58=; b=aDZhRi35dpLuHHGXO/lIkA3E7MMJdyerWbmSfc2kYCitT+62qDHbhHOJBm7BlFsUYXommxPZn/ufaZ1X7W2MIjY7tnxHWlk5VG3x9vgEflUqzmPOAc68PGac0+utuT+5FluBh0HPPmCuVJ9s3wRMmYOcf3qJ3IVAcU/kAmhbC7Y= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158315458358877.82353893673076; Mon, 2 Mar 2020 05:09:43 -0800 (PST) Received: from localhost ([::1]:60788 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kpK-0000d9-BZ for importer@patchew.org; Mon, 02 Mar 2020 08:09:42 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48639) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Fe-Fv for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003MC-Bj for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51532 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8kng-0003Ir-VV; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 2B3C4B8B17646587C289; Mon, 2 Mar 2020 21:07:53 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:46 +0800 From: Chen Qun To: , Subject: [PATCH v3 03/12] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Date: Mon, 2 Mar 2020 21:07:06 +0800 Message-ID: <20200302130715.29440-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Max Reitz , Euler Robot , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: block/file-posix.c:891:9: warning: Value stored to 'op' is never read op =3D RAW_PL_ABORT; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Kevin Wolf --- Cc: Kevin Wolf Cc: Max Reitz --- block/file-posix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 6345477112..0f77447a25 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs, "Is another process using the image [%s]?\n", bs->filename); } - op =3D RAW_PL_ABORT; /* fall through to unlock bytes. */ case RAW_PL_ABORT: raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm, --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154720; cv=none; d=zohomail.com; s=zohoarc; b=g/CyIrfziEAP0+3YOOiARIZB3DYqsLgosRwIDB2dhqpRHxmLZYDAF0xsHUqlfx0RTo2XWekv8krzeVp73R88QL2G12Mq53OHTAqsiQElu4mzd8udKqd+iJ7zbgenpn7j+hezj+ucEDuyV2KyPSIxpYTKE9MBy4X5HoknCoe4TWs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154720; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=6VWrMHZzPEuZMQhGknN9GvRlpu9m4m7nz7ptWyLTwqw=; b=NTtshw5WBPIerFtNKMxMCWVZKC9eD53+7BNXQT3VY1v6hbBThnNMf4jfGFzD9VfEBPlNPv/6r+HS0ZtnkcAREWJRYT4q+Cs8sC0Q67PBica9H3SDgu4SE2b2Bc8sH7mHhhC3tYcYXMc0kWKQuQp2BUeKGY9JZGXq841Q4F44Uyo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158315472094151.4106089802973; Mon, 2 Mar 2020 05:12:00 -0800 (PST) Received: from localhost ([::1]:60842 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8krX-0005Te-RG for importer@patchew.org; Mon, 02 Mar 2020 08:11:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48653) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Fj-Pe for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003Mf-Ol for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3178 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knh-0003Iu-D8; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4FF2821955A36AD40F6B; Mon, 2 Mar 2020 21:07:53 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:47 +0800 From: Chen Qun To: , Subject: [PATCH v3 04/12] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() Date: Mon, 2 Mar 2020 21:07:07 +0800 Message-ID: <20200302130715.29440-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Paolo Bonzini , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc:Fam Zheng --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..2e6cc07d4e 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, val <<=3D shift; val |=3D current & ~(mask << shift); addr &=3D ~3; - size =3D 4; } =20 if (addr < 0x40) { --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154603; cv=none; d=zohomail.com; s=zohoarc; b=RlA/ns/FG14rl+6ywUuNMADbtH5lNFnZDoIQTRQUeRrNOp1JdMJUQ3kyJrFnr015nrkGVdwLTkPAD+2p2RFZxHif9PvcL/LrlSYozV6YG8+wnr2Vzd7fFacdxVjKttWSL5rkV1AbkRQWjbb76EmUb17quOfSUm3XGfXESAbkyL0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154603; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bHbySloGXEBNpIAdka6JIs1MPKgGuQ4fBWs2uhx6Mmo=; b=XiEV8l0tT7tZXqcpJ5JdBY+QHpuArjmmOPYeoIEwN+xf3OERtAmtOImX2tOdDmvY5xLSjJSxFm/8ujwHSu7/ny2snvVj8NTODG4FkMp3EwrV6I8ycDTGaC5Vzj94gQW8CZ2he56MkjNAOVy+D4lnyPYGyDJXYeWHt4hwcfeS50g= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154603508196.47924069029136; Mon, 2 Mar 2020 05:10:03 -0800 (PST) Received: from localhost ([::1]:60798 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kpe-0001Sx-B3 for importer@patchew.org; Mon, 02 Mar 2020 08:10:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48911) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8ko7-0006pf-4E for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8ko4-0003SH-Ph for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:25 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51764 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8ko4-0003Ms-Dc; Mon, 02 Mar 2020 08:08:24 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 404A2974DEB5C69ADDAE; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:47 +0800 From: Chen Qun To: , Subject: [PATCH v3 05/12] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Mon, 2 Mar 2020 21:07:08 +0800 Message-ID: <20200302130715.29440-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen =3D req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) r->iov.iov_base =3D blk_blockalign(s->qdev.conf.blk, r->buflen); } =20 - buflen =3D req->cmd.xfer; outbuf =3D r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) { --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154797; cv=none; d=zohomail.com; s=zohoarc; b=RI0EA1zVQwRLkcRbWDZcymmGjx2LwFjP82qWgWRrzCxYmhAgNCD7SvwMSrhhKq/TZJ8gET4SvaUhfkLKmdajO92WBNF8CZZ7BXA+2LgJ+Wlte7HjItu/YQZf46gsSiBATrOepDHVLEn25Evh9Ks3mVW20CbNM+izwKTwlvBcUQc= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154797; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QY7uRNNpzs4vciJTUQR9ZRlNiW645YFUGZJB5FSKTsU=; b=AIuClTIOf6X8PX76nSXW+t7AJFsWoRHVVdByk6x6KqdrQIVM4H8BQCygPY2W1xUboYOa6Y3iIAf+LCMa7c2kNKL/baKtXONbFPrFkvSHfU7ZJmDZgD5FVi0CRy8A41Tu+3VnI6YgOax2sGBS1Vt+bX4vQDJ/52C7e/LC7IIYUFY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154797419822.0093161514335; Mon, 2 Mar 2020 05:13:17 -0800 (PST) Received: from localhost ([::1]:60862 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8ksm-0007em-9P for importer@patchew.org; Mon, 02 Mar 2020 08:13:16 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48755) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006GR-1A for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knk-0003Od-0K for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:04 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51756 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mk-KM; Mon, 02 Mar 2020 08:08:03 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 2E44AA81D8ABFD82BBE5; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:48 +0800 From: Chen Qun To: , Subject: [PATCH v3 06/12] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Date: Mon, 2 Mar 2020 21:07:09 +0800 Message-ID: <20200302130715.29440-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never r= ead format =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/pxa2xx_lcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index 05f5f84671..464e93161a 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/display/pxa2xx_lcd.c @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int= ch, int bpp) n =3D 256; break; default: - format =3D 0; return; } =20 --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154883; cv=none; d=zohomail.com; s=zohoarc; b=N87feKjT4WvFRLiXfFjkz2C6rdTLR/MiV1dNxeGySa2GVFdT4KbYBs76o3mqGIcNKMFnB+PGhXXgDbgLFN0Cn4iBfXaY0R5v65gbhCFkPo6eN2jokXiqp6LkskmacExgRUesXfzAUJPu/FnbZG45OoQXdGUO5k44RV2aIhKwY0g= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154883; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qLm/9yfAp9061gfshwrHobHWf4rT/sbcB3rnqEJOHDA=; b=CgdevsrHnFmQA6WxtOn9Gwxhz/HEvTx7ZE37w8Xzi4XkQGebytFxXyNFm26GJFj2ADZSju5RQcHCLlqxEgpq/dG9hjOr8qtJh4EH3lBgJHAHZVVMKp/b6vK+VtMd8fP7y47Hbjkk1As6r6OzuqKNBCPCr2uLZJbUq4uZtjSHdkY= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154883173465.87378517848185; Mon, 2 Mar 2020 05:14:43 -0800 (PST) Received: from localhost ([::1]:60890 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8ku9-0001ag-8T for importer@patchew.org; Mon, 02 Mar 2020 08:14:41 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48757) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006GS-2m for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knj-0003OW-Vy for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51762 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mm-Jh; Mon, 02 Mar 2020 08:08:03 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 3C7B568BD8D6A4CC4AD7; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:49 +0800 From: Chen Qun To: , Subject: [PATCH v3 07/12] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Date: Mon, 2 Mar 2020 21:07:10 +0800 Message-ID: <20200302130715.29440-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' i= s never read is_dirty =3D false; Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Laurent Vivier --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/display/exynos4210_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index c1071ecd46..05d3265b76 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exynos4210_fimd.c @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) } host_fb_addr +=3D inc_size; fb_line_addr +=3D inc_size; - is_dirty =3D false; } g_free(snap); blend =3D true; --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154753; cv=none; d=zohomail.com; s=zohoarc; b=bjKypnuCIHPWK2PR+wDUYI3+ONglUERpReN9RFYxepLdFnVufdI3/8Dkln+jt+tVVEb6JbCiFaUwL14p8IfGJjMXKRd6Ursgb5KbkqWs0+O8aNzXSjWAzH+qFykzP9xZijSnGeCfqGBestxu+TS2K9fizUT06SjsaEyGVIBIqLw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154753; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=E/hsiMoIMHQ6tlwboutKscpKfUIVI2sG4MyuSQ2Uel4=; b=gBU0+kVa8S9/bn5zkRlMUvQdd5NvALv8yHZlEfsE51ZaLQvgtrNEjYoPnI2Kj9rVXgtey26HIk3s+2W4VAxamUO1OiJdwRexX4XKF/UmCGGkD3qa5GcFCGHEZwcfV00gDH20FG84CdVvFaq+hattzLyK1/src1VXH5Wb7piAv5o= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154753127599.1834129573889; Mon, 2 Mar 2020 05:12:33 -0800 (PST) Received: from localhost ([::1]:60846 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8ks4-0006Dl-06 for importer@patchew.org; Mon, 02 Mar 2020 08:12:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48649) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kni-0006Fi-Jc for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:03 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knh-0003MZ-Ll for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:02 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:55482 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knh-0003La-9U; Mon, 02 Mar 2020 08:08:01 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.59]) by Forcepoint Email with ESMTP id 4D915793AA68359AB045; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:49 +0800 From: Chen Qun To: , Subject: [PATCH v3 08/12] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() Date: Mon, 2 Mar 2020 21:07:11 +0800 Message-ID: <20200302130715.29440-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>=3D 5; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell --- hw/display/blizzard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a..62517bdf75 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, g =3D (data & 0x3f) << 2; data >>=3D 6; r =3D (data & 0x1f) << 3; - data >>=3D 5; *dest++ =3D rgb_to_pixel32(r, g, b); } } --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154962; cv=none; d=zohomail.com; s=zohoarc; b=UV5Pw7DrbC3NcOt6URRD6MhhwOCCqNf8RfEOEOpu/UaZXZgm6hl4C7DKXvTfsnXsAT6VmFlWh9WYu4PUcV2QMFgIv5c3Qf1jlcZPg33J4Ar9wAOQ1QpfjmON4pRF/T9XQOfA3gXbnCUGSlDCbMV6sulkG5akeRAd0aYTqjag4uM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154962; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=7awlEQ+efR0JQwHNcxwwO3hYR10/SdQs2+YD4DuC/9w=; b=EhdyMuX/iQlZpvRLG+ObJb9nNw877LFK/DeWG0kYGhBqpuL+3t4SVjy87I8vizobB7mXHWcVYtxOr71r516Gl68p1GFjfvczOsvBTQXLR6PtmGAAcOKgMHEvoLB+vRPaAouNgs8hbm6Z/nfmaD/MNDtLWwY7B0W/qX8zDqt+6uo= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158315496283317.998968193031374; Mon, 2 Mar 2020 05:16:02 -0800 (PST) Received: from localhost ([::1]:60926 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kvR-0002zo-NS for importer@patchew.org; Mon, 02 Mar 2020 08:16:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48812) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006Gt-TG for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knk-0003PB-JS for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51760 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knk-0003Mp-6A; Mon, 02 Mar 2020 08:08:04 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 374647BF6694896F34FF; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:50 +0800 From: Chen Qun To: , Subject: [PATCH v3 09/12] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Date: Mon, 2 Mar 2020 21:07:12 +0800 Message-ID: <20200302130715.29440-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Francisco Iglesias , Alistair Francis , "Edgar E. Iglesias" , Alistair Francis , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_W= ORD3, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Francisco Iglesias Reviewed-by: Alistair Francis Reviewed-by: Edgar E. Iglesias --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: Philippe Mathieu-Daud=C3=A9 v1->v2: move the 'dst_type' declaration.(Base on Philippe's suggestion). --- hw/dma/xlnx-zdma.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c index 8fb83f5b07..eeacad59ce 100644 --- a/hw/dma/xlnx-zdma.c +++ b/hw/dma/xlnx-zdma.c @@ -373,7 +373,7 @@ static uint64_t zdma_update_descr_addr(XlnxZDMA *s, boo= l type, static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, uint32_t len) { uint32_t dst_size, dlen; - bool dst_intr, dst_type; + bool dst_intr; unsigned int ptype =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, POINT_= TYPE); unsigned int rw_mode =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_CTRL0, MODE= ); unsigned int burst_type =3D ARRAY_FIELD_EX32(s->regs, ZDMA_CH_DATA_ATT= R, @@ -387,17 +387,17 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf,= uint32_t len) while (len) { dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_WORD= 2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_WORD= 3, - TYPE); if (dst_size =3D=3D 0 && ptype =3D=3D PT_MEM) { uint64_t next; + bool dst_type =3D FIELD_EX32(s->dsc_dst.words[3], + ZDMA_CH_DST_DSCR_WORD3, + TYPE); + next =3D zdma_update_descr_addr(s, dst_type, R_ZDMA_CH_DST_CUR_DSCR_LSB); zdma_load_descriptor(s, next, &s->dsc_dst); dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_= WORD2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_= WORD3, - TYPE); } =20 /* Match what hardware does by ignoring the dst_size and only using --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154686; cv=none; d=zohomail.com; s=zohoarc; b=npAfYjqAwrPEhkTWYMNUnQy8ydxLW49Ft02+ZePaVhAnZTdm/ndGfSnpmKfAsZbRHhflPQGXflEKnB41WUNe5IHquztPc0T0LuXsgMvD1DCPFg+qOL0VxJz1noPSQUA1t2Zo+9yDrFMp7vcD77wzKI2VruuAOc/Edd594FHvTPI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154686; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=QbxU3lMNPCpg/HHj6INZl1JwWtPXTwJwGEz9cGKb4iE=; b=QZ3OYcxHrHxsOUFO0/zBAUJflUHxSqoQTgeCqQGG+3HntY49QJUrI50TwIFMdmuQqthWeuNnEWVhUzAisJCgW5ji+3I+F9RjRCk41bbftb4O0VgFDQ5njm3pjKsvjdKqkxseleBW1bVXwhHi4Qg2DLfIU0+1H2rCk492eeFWXaI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154686470154.19862131558716; Mon, 2 Mar 2020 05:11:26 -0800 (PST) Received: from localhost ([::1]:60832 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kqz-0004FE-86 for importer@patchew.org; Mon, 02 Mar 2020 08:11:25 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48773) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006GU-9S for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knk-0003Oi-0y for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51766 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mr-L8; Mon, 02 Mar 2020 08:08:03 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 44B5381F7092D2E362EC; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:51 +0800 From: Chen Qun To: , Subject: [PATCH v3 10/12] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Date: Mon, 2 Mar 2020 21:07:13 +0800 Message-ID: <20200302130715.29440-12-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, Euler Robot , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell --- hw/timer/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..570cf7075b 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); - DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_FRCCNTB_WRITE; --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583154564; cv=none; d=zohomail.com; s=zohoarc; b=dG17Z3c3zv+liMMPdCAOCG8m+6UXDd2tLsUozMaSDE/1dak9xpwcS8ylUSPVIiV//49pv7wtlS/N///tJuSfvQVJ8avPrJDT7D/i8ToU+Sa5PAOxJbaVbmTfiDCNjqZrkFgBzpNn4A74o8Kluo9hda5omz4KWBDaegD0+fYeIK0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583154564; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mKukJQrLN83q8zGXmY5XzZxjGQU5n4zzaegdAPxCKRc=; b=XpwoT21NLKSP+AVwnzuXri/f381jFcq9lSsUyJ6Vlj1FwJRfkl/ti8fEzSjmE+E8qZyHUoF3fpaaivbYvIG28xMaHoQSSSWUOZDAIJayPsb1Qe8HJMkuaOW8DF5T5wYSmJVW23DZhuUYA+WEIIDOeAo7cps/Iu1xqkRxGPipi9w= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583154564605151.4011962246601; Mon, 2 Mar 2020 05:09:24 -0800 (PST) Received: from localhost ([::1]:60784 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kp0-00085Y-PE for importer@patchew.org; Mon, 02 Mar 2020 08:09:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48766) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006GT-6H for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knj-0003ON-UT for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51758 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mj-IJ; Mon, 02 Mar 2020 08:08:03 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 326837649F9E2992C69B; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:52 +0800 From: Chen Qun To: , Subject: [PATCH v3 11/12] usb/hcd-ehci: Remove redundant statements Date: Mon, 2 Mar 2020 21:07:14 +0800 Message-ID: <20200302130715.29440-13-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Gerd Hoffmann , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read again =3D -1; ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Acked-by: Gerd Hoffmann --- Cc: Gerd Hoffmann Cc: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-ehci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f457f..29d49c2d7e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } =20 /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int a= sync) =20 default: fprintf(stderr, "Bad state!\n"); - again =3D -1; g_assert_not_reached(); - break; } =20 if (again < 0 || itd_count > 16) { --=20 2.23.0 From nobody Sun Sep 7 15:33:43 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1583155049; cv=none; d=zohomail.com; s=zohoarc; b=HJlnopd6rN8gERD95EKEZPuQ+qcUyU3zz9DrX99v8UEYq9JrzLDmwxiyfPRjhqkErLgIpwzG9JsypnVyH0H9SJWMmJgX5EnZo/36R+u3LGYawK3eydkCB3URBTjOsMIm1Uvk+KqU3AWK2yg9kubdAWHIJoSEcWDuVhYys5PdCHo= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1583155049; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=swIBMWmZY896DyJx23AzD0QZM+NQ5lJpwKZMOoG606o=; b=fjRSu+dDSP6vLuJ1jcKiif7y0g4koD0fpBPEpgz7J5Hfyl8XQAldIVqlV8zrFNYcEFdQHBLb2CjDiUvxHr4UyJdc5G/6/846SW1VZKC7ZBjnLnIY876YkK/aJGBLF8TJsanLjiibExZ76BEAZyVYf83sJrleY3wkaJ/jBfzs/vM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1583155049128675.9997888525804; Mon, 2 Mar 2020 05:17:29 -0800 (PST) Received: from localhost ([::1]:60932 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8kwp-000448-Qe for importer@patchew.org; Mon, 02 Mar 2020 08:17:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:48815) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j8knl-0006Gv-Uf for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j8knk-0003Pa-QF for qemu-devel@nongnu.org; Mon, 02 Mar 2020 08:08:05 -0500 Received: from szxga06-in.huawei.com ([45.249.212.32]:51768 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j8knj-0003Mq-K9; Mon, 02 Mar 2020 08:08:04 -0500 Received: from DGGEMS414-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 64C489648BA4CAF3AFE9; Mon, 2 Mar 2020 21:07:58 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS414-HUB.china.huawei.com (10.3.19.214) with Microsoft SMTP Server id 14.3.439.0; Mon, 2 Mar 2020 21:07:52 +0800 From: Chen Qun To: , Subject: [PATCH v3 12/12] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Date: Mon, 2 Mar 2020 21:07:15 +0800 Message-ID: <20200302130715.29440-14-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200302130715.29440-1-kuhn.chenqun@huawei.com> References: <20200302130715.29440-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.32 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, "Dr. David Alan Gilbert" , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set =3D true; ^ ~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Laurent Vivier --- Cc: "Dr. David Alan Gilbert" Cc: Philippe Mathieu-Daud=C3=A9 v1->v2: move the 'set' declaration to the for() statement(Base on Philippe'= s suggestion). --- monitor/hmp-cmds.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..c6b0495822 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2808,7 +2808,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) const char *name =3D qdict_get_str(qdict, "name"); uint8_t type =3D qdict_get_try_int(qdict, "type", 9); Error *err =3D NULL; - bool set =3D false; =20 list =3D qmp_query_rocker_of_dpa_groups(name, type !=3D 9, type, &err); if (err !=3D NULL) { @@ -2820,6 +2819,7 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) =20 for (g =3D list; g; g =3D g->next) { RockerOfDpaGroup *group =3D g->value; + bool set =3D false; =20 monitor_printf(mon, "0x%08x", group->id); =20 @@ -2864,14 +2864,11 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const Q= Dict *qdict) =20 if (group->has_set_eth_dst) { if (!set) { - set =3D true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst); } =20 - set =3D false; - if (group->has_ttl_check && group->ttl_check) { monitor_printf(mon, " check TTL"); } --=20 2.23.0