From nobody Thu Nov 13 22:02:57 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894504; cv=none; d=zohomail.com; s=zohoarc; b=jRd8o0G6Agq30lGDBbL4ARcdMXIUiJWI3pwYPzTrL7p8dcTlKk4UJEk17iFNvKBkaXkOa9OkC+kdzeHAndBjjWjIHzDPCIddswpbaBjHzPPpvrQ7p4K16UaDAgRoOMDm45QcSZhEVbdgdjS44NL27HZ2aJYfvt5CV75sKxubqFk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894504; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hCU51xFXYmUd1xKOruip+g6P/RBBcNpYeEW6REUohy8=; b=MrEcjnrQRRSe+nAVMFEaRtUXVcVHC/AME8efpMovne8wVV/CyUaxtLKcXo+KSqmIML7DLZgTzSqhXabA/v01jst3D1KINo8s/yhMTzjqZE0+VGToP05IXXPlg7hE4Faykx0gzIM0Y1tBdl7ZnrSDcgaLCg762W06kWbB06L74MM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158289450487655.54795835304469; Fri, 28 Feb 2020 04:55:04 -0800 (PST) Received: from localhost ([::1]:46494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fAU-0006Pa-I8 for importer@patchew.org; Fri, 28 Feb 2020 07:55:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f9V-0004xD-MD for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7f9U-0002nR-O0 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:01 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:31880 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7f9U-0002nF-LG for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:00 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-MmkjTIsIMF2wfRPl10hgxA-1; Fri, 28 Feb 2020 07:53:58 -0500 Received: by mail-wm1-f72.google.com with SMTP id v21so456913wml.5 for ; Fri, 28 Feb 2020 04:53:58 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id d9sm12398979wrx.94.2020.02.28.04.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hCU51xFXYmUd1xKOruip+g6P/RBBcNpYeEW6REUohy8=; b=WbpE7AC8HEHpMaktFAnWGHPIcy3C+xdp4CLUl3WifWcmSRSXYt89cyfYnt8CBeXEgOWmEJ kbaDOxgdwV2f2lcbXStm5fZoq5mKH0ed7zepBrGYj9LqLTaQyXI+sS96pp1X4dFQ+KxgFH /Rgp0TpcxG4ih5riPq7g7ArRmC1+6u4= X-MC-Unique: MmkjTIsIMF2wfRPl10hgxA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=om0orcuUNcgbjYJFBk5NZd23kX2WFadmaS0vRzXLejY=; b=U1x1oBXhUVikAg/PYXJvDof3tzQ5jhXkyNtV3p8fgGpV5XyGt0CLl58B9LSHxhC5Qy 9OpXm/HO5Jv2hw1cxtjwiWbjSM+q6mvwJqSSE1WaMY5wM5BqL1yCwLpDN+/PWwQoHXsX IbowDBmoVBpKEFUr7JBeEYmMIXbtNO4jMvGWZxq2aBaePdDkYWN6hjRO4qkpwZCV8wnK 2GKmyXk6Uj67rARwQlIV1N+QPg4snvdScmST+fa4dj4oaD326ZPUuImTI4IaCtMPtTSp buefM96HvVUbzCYhbgLYJrQaUl5rGdSXhHD+AO84TUemAdWICYg+lq2v+IU7qbFV2Xac cUdQ== X-Gm-Message-State: APjAAAWdNPEp9B8vMaYv2DSUQK5+IY+5qwVLtgO8XdmG9edmeJYLG2MN WqcKVGPttr+wO3ZQNukjOFxarjdvtt1yGDEjn8VeeHGDAH86aWUaY6VT82veArcRe/qAt15Voov hmO1ZguK/l64VA4M= X-Received: by 2002:a5d:4c52:: with SMTP id n18mr4981722wrt.403.1582894437407; Fri, 28 Feb 2020 04:53:57 -0800 (PST) X-Google-Smtp-Source: APXvYqzM/sxlv8YE5kDTiVHAvqAw/act89mDCgky2Xq6c5uz/7/BLXjqxyOoAdXff593ZcPROP5Hkw== X-Received: by 2002:a5d:4c52:: with SMTP id n18mr4981711wrt.403.1582894437156; Fri, 28 Feb 2020 04:53:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/5] hw/arm/gumstix: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:47 +0100 Message-Id: <20200228125351.29482-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Jan Kiszka Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 As the Connex and Verdex machines only boot in little-endian, we can simplify the code. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v2: Do not use target_words_bigendian(), arm-softmmu is only little endian (Peter Maydell) --- hw/arm/gumstix.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index f26a0e8010..3a4bc332c4 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -51,7 +51,6 @@ static void connex_init(MachineState *machine) { PXA2xxState *cpu; DriveInfo *dinfo; - int be; MemoryRegion *address_space_mem =3D get_system_memory(); =20 uint32_t connex_rom =3D 0x01000000; @@ -66,14 +65,9 @@ static void connex_init(MachineState *machine) exit(1); } =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif if (!pflash_cfi01_register(0x00000000, "connext.rom", connex_rom, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - sector_len, 2, 0, 0, 0, 0, be)) { + sector_len, 2, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } @@ -87,7 +81,6 @@ static void verdex_init(MachineState *machine) { PXA2xxState *cpu; DriveInfo *dinfo; - int be; MemoryRegion *address_space_mem =3D get_system_memory(); =20 uint32_t verdex_rom =3D 0x02000000; @@ -102,14 +95,9 @@ static void verdex_init(MachineState *machine) exit(1); } =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif if (!pflash_cfi01_register(0x00000000, "verdex.rom", verdex_rom, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - sector_len, 2, 0, 0, 0, 0, be)) { + sector_len, 2, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } --=20 2.21.1