From nobody Thu Nov 13 20:40:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894504; cv=none; d=zohomail.com; s=zohoarc; b=jRd8o0G6Agq30lGDBbL4ARcdMXIUiJWI3pwYPzTrL7p8dcTlKk4UJEk17iFNvKBkaXkOa9OkC+kdzeHAndBjjWjIHzDPCIddswpbaBjHzPPpvrQ7p4K16UaDAgRoOMDm45QcSZhEVbdgdjS44NL27HZ2aJYfvt5CV75sKxubqFk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894504; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hCU51xFXYmUd1xKOruip+g6P/RBBcNpYeEW6REUohy8=; b=MrEcjnrQRRSe+nAVMFEaRtUXVcVHC/AME8efpMovne8wVV/CyUaxtLKcXo+KSqmIML7DLZgTzSqhXabA/v01jst3D1KINo8s/yhMTzjqZE0+VGToP05IXXPlg7hE4Faykx0gzIM0Y1tBdl7ZnrSDcgaLCg762W06kWbB06L74MM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158289450487655.54795835304469; Fri, 28 Feb 2020 04:55:04 -0800 (PST) Received: from localhost ([::1]:46494 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fAU-0006Pa-I8 for importer@patchew.org; Fri, 28 Feb 2020 07:55:02 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50054) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f9V-0004xD-MD for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:02 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7f9U-0002nR-O0 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:01 -0500 Received: from us-smtp-2.mimecast.com ([207.211.31.81]:31880 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7f9U-0002nF-LG for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:00 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-127-MmkjTIsIMF2wfRPl10hgxA-1; Fri, 28 Feb 2020 07:53:58 -0500 Received: by mail-wm1-f72.google.com with SMTP id v21so456913wml.5 for ; Fri, 28 Feb 2020 04:53:58 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id d9sm12398979wrx.94.2020.02.28.04.53.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:53:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894440; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=hCU51xFXYmUd1xKOruip+g6P/RBBcNpYeEW6REUohy8=; b=WbpE7AC8HEHpMaktFAnWGHPIcy3C+xdp4CLUl3WifWcmSRSXYt89cyfYnt8CBeXEgOWmEJ kbaDOxgdwV2f2lcbXStm5fZoq5mKH0ed7zepBrGYj9LqLTaQyXI+sS96pp1X4dFQ+KxgFH /Rgp0TpcxG4ih5riPq7g7ArRmC1+6u4= X-MC-Unique: MmkjTIsIMF2wfRPl10hgxA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=om0orcuUNcgbjYJFBk5NZd23kX2WFadmaS0vRzXLejY=; b=U1x1oBXhUVikAg/PYXJvDof3tzQ5jhXkyNtV3p8fgGpV5XyGt0CLl58B9LSHxhC5Qy 9OpXm/HO5Jv2hw1cxtjwiWbjSM+q6mvwJqSSE1WaMY5wM5BqL1yCwLpDN+/PWwQoHXsX IbowDBmoVBpKEFUr7JBeEYmMIXbtNO4jMvGWZxq2aBaePdDkYWN6hjRO4qkpwZCV8wnK 2GKmyXk6Uj67rARwQlIV1N+QPg4snvdScmST+fa4dj4oaD326ZPUuImTI4IaCtMPtTSp buefM96HvVUbzCYhbgLYJrQaUl5rGdSXhHD+AO84TUemAdWICYg+lq2v+IU7qbFV2Xac cUdQ== X-Gm-Message-State: APjAAAWdNPEp9B8vMaYv2DSUQK5+IY+5qwVLtgO8XdmG9edmeJYLG2MN WqcKVGPttr+wO3ZQNukjOFxarjdvtt1yGDEjn8VeeHGDAH86aWUaY6VT82veArcRe/qAt15Voov hmO1ZguK/l64VA4M= X-Received: by 2002:a5d:4c52:: with SMTP id n18mr4981722wrt.403.1582894437407; Fri, 28 Feb 2020 04:53:57 -0800 (PST) X-Google-Smtp-Source: APXvYqzM/sxlv8YE5kDTiVHAvqAw/act89mDCgky2Xq6c5uz/7/BLXjqxyOoAdXff593ZcPROP5Hkw== X-Received: by 2002:a5d:4c52:: with SMTP id n18mr4981711wrt.403.1582894437156; Fri, 28 Feb 2020 04:53:57 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 1/5] hw/arm/gumstix: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:47 +0100 Message-Id: <20200228125351.29482-2-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , qemu-arm@nongnu.org, Jan Kiszka Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 As the Connex and Verdex machines only boot in little-endian, we can simplify the code. Reviewed-by: Peter Maydell Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- v2: Do not use target_words_bigendian(), arm-softmmu is only little endian (Peter Maydell) --- hw/arm/gumstix.c | 16 ++-------------- 1 file changed, 2 insertions(+), 14 deletions(-) diff --git a/hw/arm/gumstix.c b/hw/arm/gumstix.c index f26a0e8010..3a4bc332c4 100644 --- a/hw/arm/gumstix.c +++ b/hw/arm/gumstix.c @@ -51,7 +51,6 @@ static void connex_init(MachineState *machine) { PXA2xxState *cpu; DriveInfo *dinfo; - int be; MemoryRegion *address_space_mem =3D get_system_memory(); =20 uint32_t connex_rom =3D 0x01000000; @@ -66,14 +65,9 @@ static void connex_init(MachineState *machine) exit(1); } =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif if (!pflash_cfi01_register(0x00000000, "connext.rom", connex_rom, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - sector_len, 2, 0, 0, 0, 0, be)) { + sector_len, 2, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } @@ -87,7 +81,6 @@ static void verdex_init(MachineState *machine) { PXA2xxState *cpu; DriveInfo *dinfo; - int be; MemoryRegion *address_space_mem =3D get_system_memory(); =20 uint32_t verdex_rom =3D 0x02000000; @@ -102,14 +95,9 @@ static void verdex_init(MachineState *machine) exit(1); } =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif if (!pflash_cfi01_register(0x00000000, "verdex.rom", verdex_rom, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - sector_len, 2, 0, 0, 0, 0, be)) { + sector_len, 2, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } --=20 2.21.1 From nobody Thu Nov 13 20:40:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894509; cv=none; d=zohomail.com; s=zohoarc; b=Kp/fl2OIJ1WPUniqDXz0YH1EDX8wC2WMk40c6Zh9RlZb9Mbvlz2PE9NcmYglm0pBSy3Xjeo2TZMXF0+Svj5XAONvJTqUgnO1qiYMFnKoGhE9An9CIr1CRi2TKrcK/KnI+AyzSX595E+YFl1PhnklYARSyv9vI/CCVkxBIeFiZ/o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894509; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XwDs7eB7yM8J9r+WDDmjIGrx6VK50GLopC5M52Cl3uU=; b=LWXdFWMkEhCf/giOiAAIh+pKgGuifeO5SuRY9/McGEPxxudexGIIFa9X7LX9HUiHB6/b7ANj50HrAlQ9ZcXsDXi+3pBzyzQ8/QHxtHixsxPscu/1lY/uvMvQL6rkJiHoiKB0y5axGDdFbqr9L75gxS1WN4aJkU4c0AvU1FM/qFY= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582894509229883.0300013165845; Fri, 28 Feb 2020 04:55:09 -0800 (PST) Received: from localhost ([::1]:46498 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fAZ-0006bJ-Sb for importer@patchew.org; Fri, 28 Feb 2020 07:55:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50073) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f9X-0004zj-W1 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7f9X-0002oA-0m for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:03 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:45050 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7f9W-0002o1-Ti for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:02 -0500 Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-394-2gz3hXYlO4ChF49ddIzr0g-1; Fri, 28 Feb 2020 07:54:00 -0500 Received: by mail-wm1-f72.google.com with SMTP id t17so658903wmi.7 for ; Fri, 28 Feb 2020 04:54:00 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id d9sm12398979wrx.94.2020.02.28.04.53.57 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:53:58 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894442; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XwDs7eB7yM8J9r+WDDmjIGrx6VK50GLopC5M52Cl3uU=; b=ee4eIO0jrLywUxQexV2zM5LSOcs+43XFQjbyZgerV1PUGlDpYRTzEoiQ+cbQYc0m9X2X2w 5rMbM3niqICCTq2/EwuTLq6iF8RuOjrqZ5Whtv30dS0SGds/0hbQGi4Q2VN41JcrXwrtYG JeRWwAAhbixPe325u8IlZQIn7el226A= X-MC-Unique: 2gz3hXYlO4ChF49ddIzr0g-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=0FgPL1xTyWyfSBALtTC0/9engcqp/M7CptMznNnbZK0=; b=JEzreu9yRWVvZqjcX3sf9UzR+PQLn+o9UHau65F2cTbvC1wuEQHrqWk4GcaPdlWdRA nrLd0FrxjjBYZ+KSyOK+Suw6NpDm93W1yzsTHu8yUfDAsNWrFcXuIfzIrJ8rBAdYcXgH Ongg7zakSvRRWMVfsAe4u5AMCGHKLgbd3PgqOO1Odgqj2SQGKqHqrA4g3kxNkcWvUVtU DE+x0jw9OwhuMXwBB3qKMpvLH74+DnZ1iqd/TE0HEOPTZDRDaHR8R2QKK4kjuIWwxMw/ eF5fvbuVVSMSMY7zbkLh7m85XivEAUrBx94Usb6vCY0ZGZtRMWC+4XTawLyA7zUz++N6 nTdA== X-Gm-Message-State: APjAAAWVeG+81/tYjV3gPVQeOmY4M6flhiE2Eg1CKitVfNwdXyLSRSe9 fY8Hwkdi9jpkfWDtkXwe8qGM7KhjtoL417t06hBoighBL/7DuXFF3YQ+kOFLYE7b0LKqCnS6mmO huEX3+UBUPFI808c= X-Received: by 2002:a7b:cf08:: with SMTP id l8mr4600425wmg.169.1582894439246; Fri, 28 Feb 2020 04:53:59 -0800 (PST) X-Google-Smtp-Source: APXvYqx7v06HKBq9Kj6vX/A4DZnr1ikzdcav5IYjqnCsm3Y5qrj16y5xbXFeAyBP8EzWUBXymLUZTw== X-Received: by 2002:a7b:cf08:: with SMTP id l8mr4600406wmg.169.1582894439000; Fri, 28 Feb 2020 04:53:59 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/5] hw/arm/mainstone: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:48 +0100 Message-Id: <20200228125351.29482-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/mainstone.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/arm/mainstone.c b/hw/arm/mainstone.c index 6e64dfab50..1042017086 100644 --- a/hw/arm/mainstone.c +++ b/hw/arm/mainstone.c @@ -119,7 +119,6 @@ static void mainstone_common_init(MemoryRegion *address= _space_mem, DeviceState *mst_irq; DriveInfo *dinfo; int i; - int be; MemoryRegion *rom =3D g_new(MemoryRegion, 1); =20 /* Setup CPU & memory */ @@ -130,11 +129,6 @@ static void mainstone_common_init(MemoryRegion *addres= s_space_mem, memory_region_set_readonly(rom, true); memory_region_add_subregion(address_space_mem, 0, rom); =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif /* There are two 32MiB flash devices on the board */ for (i =3D 0; i < 2; i ++) { dinfo =3D drive_get(IF_PFLASH, 0, i); @@ -142,7 +136,7 @@ static void mainstone_common_init(MemoryRegion *address= _space_mem, i ? "mainstone.flash1" : "mainstone.fla= sh0", MAINSTONE_FLASH, dinfo ? blk_by_legacy_dinfo(dinfo) : NU= LL, - sector_len, 4, 0, 0, 0, 0, be)) { + sector_len, 4, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } --=20 2.21.1 From nobody Thu Nov 13 20:40:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894584; cv=none; d=zohomail.com; s=zohoarc; b=VvjAJZ0+bmTCLz9a44vMC0/b2ap3IeJcG1bj1wis0qSTS66mYdNygWaLylIKeGw6qObEcjrp9tCJ7pqGyMuHxagWvArdYIUZ81+rf84LSc4x05hEBjzUbCnLSRom87P9/9dk8/jVxrUQoFuvPszgn0ksj1QP4tg+vPycCX8c9kA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894584; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=NGU4cckMOQBBSno3d5GnmeEO95k4ubXtwQS7BoucsBw=; b=TRZZZlTi5sLhMZeAN5ptaflPjcgowhmr4i6pOsrrLZGLBg+H5CYP4ly2ns4s+kHaEsMQPWAoqw8hPzD06nWEWN/GtTeqMpUo0wI8Mv6tnQrhgoSCpORoCEUQ+S2GqPMILmyaVnBQBCy54iC04YJrVeGT/pMXSNrt3O8HUxFkrzo= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 158289458425831.04119605527285; Fri, 28 Feb 2020 04:56:24 -0800 (PST) Received: from localhost ([::1]:46528 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fBl-0000MK-UU for importer@patchew.org; Fri, 28 Feb 2020 07:56:21 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50102) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7f9Z-00053H-Vb for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:06 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7f9Z-0002p2-19 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:05 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:49158 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7f9Y-0002on-U9 for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:04 -0500 Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-142-qUzZ9cFTMduF2i3JS8Xo1A-1; Fri, 28 Feb 2020 07:54:02 -0500 Received: by mail-wr1-f71.google.com with SMTP id z1so1289020wrs.9 for ; Fri, 28 Feb 2020 04:54:02 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id d9sm12398979wrx.94.2020.02.28.04.53.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:54:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894444; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NGU4cckMOQBBSno3d5GnmeEO95k4ubXtwQS7BoucsBw=; b=OmqD9rVS1HM96Yh1mLzDv0AoAbfAjlXh7QBQWQ/mTBXuWQvojMgBdkCj5HqNxdJ54d7gOE xHr/JRUxfkWOiRh4R+tJpjSpoBXq53Gj82lV+gTshT6xJXduWZrwzLmsIznaCXUqW4tpkS bc/xp5w8TbtaDXjsBruDrnIPNgXHb6o= X-MC-Unique: qUzZ9cFTMduF2i3JS8Xo1A-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=/dnD18K5Rg50i85S9IuEqrMYly3TKELwfFapxO4Kdxw=; b=m5L9Jn0fyDb1CbKeRSUaRkGA663HpWr7jIW6pHJZrpt8K/04SN3vKhX/ANtbhOxWB+ mll6vmOS4YgxRXIyD2hPtG66h8VKQLTu3IAfngGf6Y2LsXQmDn/W7c01Bg2sBbSYsg30 +wUGdUXvY3ScQXovK15VUNIwBFZtQc7hOM6MoQEA7wHprxkjh2UEOvO6PVyrD1oGTv5C FBEKTxYXy+yMbQON2uKTgg5RLe/oaEyf2yQXkx+2XkeN8yMTqfPS/Qv0g8HndVBkDeBC o3dPQlh4Vviga7RBFXrIhLe8ZZ/y1u+gRIGBYOaY4rhOSXAEziYO5r7cqL65ez59b0cp KLmg== X-Gm-Message-State: APjAAAUmbGX7OOrPGE2SfEJvS6m4utMzUys16fFApplPjdZCmoKbG4l1 3zD/zbDNC88KyTyW6kYymOcaGyQUzS7nlVm0SpMZbRViePTzR7E+KsphmtTHZeXFoaOKwBmn5jk /fegMlrgOvqDJGs8= X-Received: by 2002:a7b:c119:: with SMTP id w25mr4905043wmi.112.1582894441010; Fri, 28 Feb 2020 04:54:01 -0800 (PST) X-Google-Smtp-Source: APXvYqxOP4q9x5AyxNWEnf4sfeDn+4jd1+qHdoJpX9ZlWtegtCL1nCs2OEOMz+gvVSiFqM5gmmEcFg== X-Received: by 2002:a7b:c119:: with SMTP id w25mr4905028wmi.112.1582894440828; Fri, 28 Feb 2020 04:54:00 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 3/5] hw/arm/omap_sx1: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:49 +0100 Message-Id: <20200228125351.29482-4-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/omap_sx1.c | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/hw/arm/omap_sx1.c b/hw/arm/omap_sx1.c index 2bebab4171..de5ff447dc 100644 --- a/hw/arm/omap_sx1.c +++ b/hw/arm/omap_sx1.c @@ -114,7 +114,6 @@ static void sx1_init(MachineState *machine, const int v= ersion) DriveInfo *dinfo; int fl_idx; uint32_t flash_size =3D flash0_size; - int be; =20 if (machine->ram_size !=3D mc->default_ram_size) { char *sz =3D size_to_str(mc->default_ram_size); @@ -154,17 +153,11 @@ static void sx1_init(MachineState *machine, const int= version) OMAP_CS2_BASE, &cs[3]); =20 fl_idx =3D 0; -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif - if ((dinfo =3D drive_get(IF_PFLASH, 0, fl_idx)) !=3D NULL) { if (!pflash_cfi01_register(OMAP_CS0_BASE, "omap_sx1.flash0-1", flash_size, blk_by_legacy_dinfo(dinfo), - sector_size, 4, 0, 0, 0, 0, be)) { + sector_size, 4, 0, 0, 0, 0, 0)) { fprintf(stderr, "qemu: Error registering flash memory %d.\n", fl_idx); } @@ -187,7 +180,7 @@ static void sx1_init(MachineState *machine, const int v= ersion) if (!pflash_cfi01_register(OMAP_CS1_BASE, "omap_sx1.flash1-1", flash1_size, blk_by_legacy_dinfo(dinfo), - sector_size, 4, 0, 0, 0, 0, be)) { + sector_size, 4, 0, 0, 0, 0, 0)) { fprintf(stderr, "qemu: Error registering flash memory %d.\n", fl_idx); } --=20 2.21.1 From nobody Thu Nov 13 20:40:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894593; cv=none; d=zohomail.com; s=zohoarc; b=lYznQP5WKyNIlE8k7bwXU0hE0P1gfSWq99A78M67JgEsTRT1RCwJuZGw0Xw6HHeMdNF82l7m+s/cELKMDMqotHvHPfO4b+tYY208vVSddruNMgaofoJf9Dh0Muoj6pFtRFqoLJ34kUwEKhbob0wY2mBtCbtDGwfsvPxBlAGTqAI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894593; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=fGbS/zlE8uJcFaugSfNNCFiui8oNM2qeJ1yh+1ke7gM=; b=dHBrQU5sO69qSgxLGOBZjXn4CTmlQQtZ5R0bMvFgeSqYDfL/tKoPc6VrbyH9YiV3zSgl8b4RoNEZqJjtaBkuWfjcFkjWn4ke1RtL8eKeplGHJiSvtkF68m3XYcpq7X9moJxz25VnOv15JVLSfWjxoJi+DFwd2+WxuNwgF9oDIA4= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582894593436859.0572912871372; Fri, 28 Feb 2020 04:56:33 -0800 (PST) Received: from localhost ([::1]:46530 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fBs-0000XR-Vh for importer@patchew.org; Fri, 28 Feb 2020 07:56:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50150) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fA1-0005kl-Lb for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7fA0-0002uz-Jo for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:33 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:37362 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7fA0-0002uG-GE for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:32 -0500 Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-DDbzvcI2OEmDvDnd87G1Yw-1; Fri, 28 Feb 2020 07:54:26 -0500 Received: by mail-wr1-f69.google.com with SMTP id n23so1278689wra.20 for ; Fri, 28 Feb 2020 04:54:26 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id y7sm340988wrl.26.2020.02.28.04.54.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:54:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894467; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=fGbS/zlE8uJcFaugSfNNCFiui8oNM2qeJ1yh+1ke7gM=; b=P0p+w1pAFzwHKjiPJp/UyCPEFZhmx/W5CxVhR0nBcNDRUozd6u2MUjVuDuv1LVLBbsa8aW UCDJ5C6iwsLtde3RQqaeTjVg3A/x73uIt4pokMOKbZ38le5xSNPaKi7LXZDWPZGMH4eTcM TR9iMRa8sKRzF/4niNXSMHWZSkTdwM0= X-MC-Unique: DDbzvcI2OEmDvDnd87G1Yw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=4y3/KK4nBcHl83eeBXH6BEe9dO9OSqQV02N1QOTozm8=; b=l6mGTDamWLs3LiUxv+3Qe+iPorau7sPBIAPsnOaPyMn4byxgWBVVqXkdHvfZ+XmNeN vD+SzkIhboqubO4SeDWhNX4stANgIldyEhQzzJ7/L3uTHJRV4MVkPcS1E8JRut6PZtp4 gkp4yRwkTFyTic4xg1KuVQFNyO6lajqd5iWte9lx0DtYvCxt1XQWVDFrX9cCz9BMfYUA GDXj69KSv98b+iHFrIkr+W3lYM02Eu6yZbvhvpFIGEZ+n07ytMZzxn0OdsXI1rkfB2Wv Ir2TSyF7RPaBN9cgspnpEV7++mhq/bppoln1nxCyyTw0zqhtMiu5AAMvikyVjwkgQ9MC g2CQ== X-Gm-Message-State: APjAAAXmRUQ8MzV4Dsk6Adhrwso6WFyki0meywuiEc5Vn7FUhQ3MPKVP /0HlSHVlK1L/AMbN26osorxHT6LGHC0TERPpLeRBxZMI3qinQXqcYPfLbJjNVtTzOqLM7VN0/XM R3Buv2MQoy/37+Zg= X-Received: by 2002:a1c:f401:: with SMTP id z1mr4725374wma.103.1582894464760; Fri, 28 Feb 2020 04:54:24 -0800 (PST) X-Google-Smtp-Source: APXvYqyTDFFrbbWQ1gqyE0HnPAEiinU20JFQYfC+X6S6SGvjuV/pj15/Xx2f7qLM3AzvvyK/uw8RcA== X-Received: by 2002:a1c:f401:: with SMTP id z1mr4725353wma.103.1582894464487; Fri, 28 Feb 2020 04:54:24 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 4/5] hw/arm/z2: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:50 +0100 Message-Id: <20200228125351.29482-5-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/z2.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/hw/arm/z2.c b/hw/arm/z2.c index 4bb237f22d..a0f4095990 100644 --- a/hw/arm/z2.c +++ b/hw/arm/z2.c @@ -300,7 +300,6 @@ static void z2_init(MachineState *machine) uint32_t sector_len =3D 0x10000; PXA2xxState *mpu; DriveInfo *dinfo; - int be; void *z2_lcd; I2CBus *bus; DeviceState *wm; @@ -308,15 +307,10 @@ static void z2_init(MachineState *machine) /* Setup CPU & memory */ mpu =3D pxa270_init(address_space_mem, z2_binfo.ram_size, machine->cpu= _type); =20 -#ifdef TARGET_WORDS_BIGENDIAN - be =3D 1; -#else - be =3D 0; -#endif dinfo =3D drive_get(IF_PFLASH, 0, 0); if (!pflash_cfi01_register(Z2_FLASH_BASE, "z2.flash0", Z2_FLASH_SIZE, dinfo ? blk_by_legacy_dinfo(dinfo) : NULL, - sector_len, 4, 0, 0, 0, 0, be)) { + sector_len, 4, 0, 0, 0, 0, 0)) { error_report("Error registering flash memory"); exit(1); } --=20 2.21.1 From nobody Thu Nov 13 20:40:01 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582894642; cv=none; d=zohomail.com; s=zohoarc; b=hhGabHoYkLPk8TphiOta1Gg5lSnHXRx5VBctgcakGHb8M7Dqow7NO2olBixJbmwkQKzTeaNHmqZdszsc+R22dDNcQ9v9JSc7yyQ3k3W2Zq7CrstjQSKU7sahsg/INmjSi2xklsM2a38/U1de0DElEGCI/GXr5nSMYo136BmhGe8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582894642; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=RFVTFY7GEBgh7q7HWz8/cePShORRz7+aAiJuxr5/kZA=; b=FXV7iI27xqOynhsXpJW3t+i2seniwxIB6cc0tY2uocVChWavKRAp6H99gDGWkBxl3tbEaaPpKFfWBqq3zh9ZQCuNrI+nmsc2HgLF2GiJdmLebxqfDPuPsCo/pBsPU+TUYkqJiiLQmfK2hZoP2Kydw9o9m1GqHKCRgE7qa/5Cj0g= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582894642095523.942151254637; Fri, 28 Feb 2020 04:57:22 -0800 (PST) Received: from localhost ([::1]:46542 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fCg-0001kK-CV for importer@patchew.org; Fri, 28 Feb 2020 07:57:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50151) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7fA1-0005kr-Mc for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7fA0-0002vB-NY for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:33 -0500 Received: from us-smtp-1.mimecast.com ([205.139.110.61]:22812 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7fA0-0002uP-JF for qemu-devel@nongnu.org; Fri, 28 Feb 2020 07:54:32 -0500 Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-156-3gN0aA4ZOJCIBD82HLGzfw-1; Fri, 28 Feb 2020 07:54:28 -0500 Received: by mail-wm1-f71.google.com with SMTP id q20so85241wmg.1 for ; Fri, 28 Feb 2020 04:54:28 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id y7sm340988wrl.26.2020.02.28.04.54.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 04:54:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582894470; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=RFVTFY7GEBgh7q7HWz8/cePShORRz7+aAiJuxr5/kZA=; b=TcW+qkUoUEku5KnqvIL1YpKS4CWkaO7VYLUWLLz723hs1CX1XJOGfVGAsVkeuozNXpxRYF ycovKlI5EmQ+oABcMcKn5YzMC+tpEdYXWrjoiKvQV3d5USwZ8/unpmdLpL4+5AdmaxNvY6 9FBnB6FMnydfMBHP0DQXFKmB4ApkQL0= X-MC-Unique: 3gN0aA4ZOJCIBD82HLGzfw-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=K6aC7TQ6a+95A3Kf8tkZ4l6ui47wA33c90/e4cK4bZs=; b=kmUW1ZA9kUWacPqDL3ieeJOHrmTndf0/d0qC4g1a9QgAtvSQCxqnufpKjVZZvsN6b0 Iq1SAYGz49fV9Zh2ecMSsjuBji3OMUcudmnEKJWDxlxiPZJS6WnFeVYmBzqn4bSinxWz 8G3e5yzsdUQOr9jnMnMAl2kGc+5mg1vAjHcC0fk4WXcqjVqWTds89oNSw1A1SydIeHY2 m5Wryr8ESgIzp4TSg/zoeW4J9i81GtINJcO0619Lavp+iJ/Yb0tZsZ3WHDuOxc7Kf4tW 5DR9Zm9uDRM6pMUSn1oxdL289XfHfh2uZL+TQaBVrnPREiSbvyc8Cdzzb+BHQFrq5qZb hBXw== X-Gm-Message-State: APjAAAUvpjEhWSUE2MMyWVooy5beUUvMAvyI/H/NLNFCpE4iutnHonJw g7ul27XOekXH+VzAPwsSsHCe1yS74X/rQ0dTxU41UxR1+DVdlBY+RC5kF8AbSGjIqcgmCP5+A38 +JPoS8HqTRpPeFfs= X-Received: by 2002:a5d:6acf:: with SMTP id u15mr4981948wrw.182.1582894466975; Fri, 28 Feb 2020 04:54:26 -0800 (PST) X-Google-Smtp-Source: APXvYqw7z8D4EeKLFPXzjEbjIsJrYk6RlFT4N3p3BB47Ow70QZgCfP2Gtp3/SeLJ/mnkUQyXiuMgQA== X-Received: by 2002:a5d:6acf:: with SMTP id u15mr4981927wrw.182.1582894466774; Fri, 28 Feb 2020 04:54:26 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 5/5] hw/arm/musicpal: Simplify since the machines are little-endian only Date: Fri, 28 Feb 2020 13:53:51 +0100 Message-Id: <20200228125351.29482-6-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228125351.29482-1-philmd@redhat.com> References: <20200228125351.29482-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Peter Maydell , qemu-arm@nongnu.org, Jan Kiszka , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" We only build the little-endian softmmu configurations. Checking for big endian is pointless, remove the unused code. Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson --- hw/arm/musicpal.c | 10 ---------- 1 file changed, 10 deletions(-) diff --git a/hw/arm/musicpal.c b/hw/arm/musicpal.c index db8b03cb83..b2d0cfdac8 100644 --- a/hw/arm/musicpal.c +++ b/hw/arm/musicpal.c @@ -1645,22 +1645,12 @@ static void musicpal_init(MachineState *machine) * 0xFF800000 (if there is 8 MB flash). So remap flash access if t= he * image is smaller than 32 MB. */ -#ifdef TARGET_WORDS_BIGENDIAN - pflash_cfi02_register(0x100000000ULL - MP_FLASH_SIZE_MAX, - "musicpal.flash", flash_size, - blk, 0x10000, - MP_FLASH_SIZE_MAX / flash_size, - 2, 0x00BF, 0x236D, 0x0000, 0x0000, - 0x5555, 0x2AAA, 1); -#else pflash_cfi02_register(0x100000000ULL - MP_FLASH_SIZE_MAX, "musicpal.flash", flash_size, blk, 0x10000, MP_FLASH_SIZE_MAX / flash_size, 2, 0x00BF, 0x236D, 0x0000, 0x0000, 0x5555, 0x2AAA, 0); -#endif - } sysbus_create_simple(TYPE_MV88W8618_FLASHCFG, MP_FLASHCFG_BASE, NULL); =20 --=20 2.21.1