From nobody Thu Nov 13 22:04:08 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582884540; cv=none; d=zohomail.com; s=zohoarc; b=RJQMjXB/rPbZqBL8RwEFSYmZuXVsDcvjmegX5Cydf8EzAdJSsZKqMBUBKad41pYWDEiB3kVyQMWT5EBbheYEvSknvraeOTebQ/5Wvf6EP9RYeOX/cQ0TCnG7f846hk+4v6cXfmhvB1tgo5sFf3nCbw99mWatGAyF8Z6QdrbRBpA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582884540; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=U596dy96rfJ3roF0dAsD+G3kCp1P/QwUVt7AH1P41lY=; b=KwhTk+lzE3AkyqDjoRT+smeK4lfsJCrTPKIKciIR12nozH6eMTJxIKI2gJbTmbiMhN0cv+rhRUvcwHu174FEwdT9PonswVuUfWQShIYvajEBswdna+3YGPKyJPler57FMEnXzYQXHrHlzOtQqThfAx1WPAMYbj4ry/nCaO9KRT8= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582884540463723.479796965763; Fri, 28 Feb 2020 02:09:00 -0800 (PST) Received: from localhost ([::1]:44742 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cZn-0001RV-5X for importer@patchew.org; Fri, 28 Feb 2020 05:08:59 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:56902) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7cYa-00086L-Ef for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:45 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7cYY-0002p3-RO for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:44 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:57341 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7cYY-0002ny-NT for qemu-devel@nongnu.org; Fri, 28 Feb 2020 05:07:42 -0500 Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-185-fSezLjP2ML6-hzFuqQ3OUA-1; Fri, 28 Feb 2020 05:07:39 -0500 Received: by mail-wm1-f69.google.com with SMTP id o24so515809wmh.0 for ; Fri, 28 Feb 2020 02:07:38 -0800 (PST) Received: from x1w.moovbox.local ([185.102.219.36]) by smtp.gmail.com with ESMTPSA id q12sm12534994wrg.71.2020.02.28.02.07.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 28 Feb 2020 02:07:36 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582884461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=U596dy96rfJ3roF0dAsD+G3kCp1P/QwUVt7AH1P41lY=; b=KZjqIDyrEJXlTUvoX9+atX7Yrf6tMpJFvYUEUHdMDpBIWGGvTOc5wPl4sMV0ARdxoiM5UR 64SZIqmlHaoL6WiyopJKIBKaG0fY5RHLt2Gsf6ZFtY9nR/rDmqt9r230rfXw8REeVfdUpn YZcB64HJJ2yIvF9i624/aQ9ykgxMCGg= X-MC-Unique: fSezLjP2ML6-hzFuqQ3OUA-1 X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=DWgR+ky/bIZD4jaLET2vS/CCvPR/BzPRfuBiP4EJRxQ=; b=nh+o+ttbgAHco0xUXeKk4SbubGYiqXxB/vaIcJl0xkEA4JjZcled0eRM/itWp0lD88 6WGPzCz+x0IkDsfLL+tp+GKaijCCA2YuFXzHGUldRKBL8DFig6zUQkY07XkmCa0eObmk 1dRQdOZIjsrh2kD6BlC3tbmxzkbjJMGziH5upJF+Eq502MKdBQV7ZIJ/CdYYJk936K3K QeqA8JWQmMrr2Dg3Gr8f64ofTwfODbFdlYZ6APv7EZaD5QL/ilYbOux+VbcAwSCJL0cv 8KwB4WLwVYBMjvJ1ZsRuLhYxr3FmgQBx5MoznNxoEBYY6wqWVZjH6ix3P8nCPstD+Vf1 n3vA== X-Gm-Message-State: APjAAAVkTebjeg7XsZY8XXM339e3qo7t/4jT7DBHojw6Fd5YnsOGWs+8 yWFkYnRTUnORKS7dfa2SnDDb2AKk5qVXQrxmqMT/NGrsOGVnDRlFBVKcuUQBJTK7TKCCLVtecDp o1Dlu6NeeYIz5M/g= X-Received: by 2002:adf:e542:: with SMTP id z2mr4350644wrm.150.1582884457739; Fri, 28 Feb 2020 02:07:37 -0800 (PST) X-Google-Smtp-Source: APXvYqwULmwotSEjywX/qiez5ZDXHUGhw5pTBYSJWK7rCZfDpnXJBy56nZN7tyRJWtHOm2tMT20ysw== X-Received: by 2002:adf:e542:: with SMTP id z2mr4350627wrm.150.1582884457555; Fri, 28 Feb 2020 02:07:37 -0800 (PST) From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v3 2/4] util/osdep: Improve error report by calling error_setg_win32() Date: Fri, 28 Feb 2020 11:07:24 +0100 Message-Id: <20200228100726.8414-3-philmd@redhat.com> X-Mailer: git-send-email 2.21.1 In-Reply-To: <20200228100726.8414-1-philmd@redhat.com> References: <20200228100726.8414-1-philmd@redhat.com> MIME-Version: 1.0 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Michael Roth , Markus Armbruster , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8"; text/plain; charset="utf-8" Use error_setg_win32() which adds a hint similar to strerror(errno)). Reviewed-by: Marc-Andr=C3=A9 Lureau Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- v3: Remove change in socket_init() which uses fprintf() --- util/osdep.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/util/osdep.c b/util/osdep.c index f7d06050f7..4829c07ff6 100644 --- a/util/osdep.c +++ b/util/osdep.c @@ -82,8 +82,8 @@ static int qemu_mprotect__osdep(void *addr, size_t size, = int prot) DWORD old_protect; =20 if (!VirtualProtect(addr, size, prot, &old_protect)) { - error_report("%s: VirtualProtect failed with error code %ld", - __func__, GetLastError()); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + error_report("%s: VirtualProtect failed: %s", __func__, emsg); return -1; } return 0; --=20 2.21.1