From nobody Tue Feb 10 05:10:02 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582882171; cv=none; d=zohomail.com; s=zohoarc; b=K9I0ShUm8iyNsZZZZIutK+YhFbbQHCu0q7/eRfKxc76KEJxVc8Ir9fgwDT3jfNBNwraLTnn8fWd0D6gZRs3Y40z6OAmvcmERKyZ2PgfZRHeZJsIJJ+DcZ9ULi3xMTU14xBeKUnfZ4Bq83XqH+Z9mvvUdVTw0qvh+PLgp0EGEld8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582882171; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=vy6mjPbcxFDYzD2ybd2JJ2zfuWCltugzKAToMhGkA9k=; b=J41j80/TCQT3WanywyiCSCEod/gFgWoh/vZjrjPjqMpBgSb2B1r0agA1zJiQgkwfIHnQ3k9g719YFAv6OKtm/OW+BH625m1V5YgXYVPBC1Tu+weUj8bt0IyETxyFflvlH8eQG+Xe66EhQ35byKkKRUIFM/3gz5hU1oKaIY84feE= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582882171862778.982723444665; Fri, 28 Feb 2020 01:29:31 -0800 (PST) Received: from localhost ([::1]:44148 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7bxa-0006O0-LO for importer@patchew.org; Fri, 28 Feb 2020 04:29:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:50592) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7btc-00082L-GL for qemu-devel@nongnu.org; Fri, 28 Feb 2020 04:25:25 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7btb-000452-De for qemu-devel@nongnu.org; Fri, 28 Feb 2020 04:25:24 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:47029 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7btb-00044o-AE for qemu-devel@nongnu.org; Fri, 28 Feb 2020 04:25:23 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-229-zUV7DZi8ODOAlhrgfsEEXg-1; Fri, 28 Feb 2020 04:25:20 -0500 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 42FB0A0CC1; Fri, 28 Feb 2020 09:25:19 +0000 (UTC) Received: from secure.mitica (ovpn-116-211.ams2.redhat.com [10.36.116.211]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6010160BE0; Fri, 28 Feb 2020 09:25:15 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582881923; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vy6mjPbcxFDYzD2ybd2JJ2zfuWCltugzKAToMhGkA9k=; b=E+zmPEw5ApSYTCvY3gFuCzK6/17VuI/e+hwtgVYpQa7ZoGi4Nw+LYrfEFndQFLLCr/ZAoP Vu+/+ysYuUnB5xkMqF9nEbhx8LMjxU+r1rg5c1roE9KjnYlQ05IamqyMIbuJsI5gMf+39y 9f0b4PorWSOElT2T0eS41tXXlCTaXW0= X-MC-Unique: zUV7DZi8ODOAlhrgfsEEXg-1 From: Juan Quintela To: qemu-devel@nongnu.org Subject: [PULL 09/15] migration/vmstate: Remove redundant statement in vmstate_save_state_v() Date: Fri, 28 Feb 2020 10:24:14 +0100 Message-Id: <20200228092420.103757-10-quintela@redhat.com> In-Reply-To: <20200228092420.103757-1-quintela@redhat.com> References: <20200228092420.103757-1-quintela@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Laurent Vivier , Fam Zheng , Thomas Huth , =?UTF-8?q?Daniel=20P=2E=20Berrang=C3=A9?= , Eduardo Habkost , qemu-block@nongnu.org, Juan Quintela , Euler Robot , "Dr. David Alan Gilbert" , Markus Armbruster , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Stefan Hajnoczi , Chen Qun , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Hailiang Zhang Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" From: Chen Qun The "ret" has been assigned in all branches. It didn't need to be assigned separately. Clang static code analyzer show warning: migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Juan Quintela Signed-off-by: Juan Quintela --- migration/vmstate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index 7dd8ef66c6..bafa890384 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -362,7 +362,6 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDesc= ription *vmsd, } for (i =3D 0; i < n_elems; i++) { void *curr_elem =3D first_elem + size * i; - ret =3D 0; =20 vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems= ); old_offset =3D qemu_ftell_fast(f); --=20 2.24.1