From nobody Thu Nov 13 21:52:17 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582821372; cv=none; d=zohomail.com; s=zohoarc; b=k2448ai6alkx3C3o7lPI//fl8vcA/dPhMWnsl/Z5sz8ilhvWCPkJOm5TJbbnLXGRj+dItYqetj6r1YotsatY0aSZRPiB7eNhA4rm1bZzKQNMxkswVXk47sCUKXrBNeHPmUGdBfGIL/kYGXLERYeuUH0tlU/TrnRcdttUsY8wnKY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582821372; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=lrxksytfH/4aQKzPhPTMKmDyBX6ftLeis8jZBIQPOJY=; b=nm96Uxf90WQDOdUuiS9Y+YN/SpMTF7r62SwK7QL+UaAAz5daupJjdLCyPujk6GOOgq9IiDwT3RLw9B/iEm8muC14mle8UA8hqg9tttsifE89mjEI+cNOz9d3LXm4n5p3aTmw+cGek3EpAWsDm50+YntOz6tE78Odid2724c6T8w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582821372106803.7823037143696; Thu, 27 Feb 2020 08:36:12 -0800 (PST) Received: from localhost ([::1]:34270 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7M8w-0000sp-WF for importer@patchew.org; Thu, 27 Feb 2020 11:36:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40912) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7M50-0004Nj-U2 for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:32:07 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7M50-00033e-1i for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:32:06 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:58355 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7M4z-00033I-Ty for qemu-devel@nongnu.org; Thu, 27 Feb 2020 11:32:05 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-158-qrlnDfvtMbanvVC6FzKkoA-1; Thu, 27 Feb 2020 11:32:03 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id EE4D3800D50; Thu, 27 Feb 2020 16:32:00 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-195.brq.redhat.com [10.40.205.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 5AC436E3EE; Thu, 27 Feb 2020 16:31:58 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582821125; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=lrxksytfH/4aQKzPhPTMKmDyBX6ftLeis8jZBIQPOJY=; b=eIcU6rpWHQT5wNbvaHv41q0KLWtnG703RcuaMBSggVaQ8JmnTZVv20Pg9XmHOtGu+8bmyg s+QLzpdPcJG5oNWCl/FwSvqFYh+VKzR7PpEBnfqpu9jTNaYYyCs9s5GBZ12QxEmAUQnxfO atCGSgie6NTL8o35K8VC7ULRzK25v0I= X-MC-Unique: qrlnDfvtMbanvVC6FzKkoA-1 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH v2 5/6] qga: Fix a memory leak Date: Thu, 27 Feb 2020 17:31:00 +0100 Message-Id: <20200227163101.414-6-philmd@redhat.com> In-Reply-To: <20200227163101.414-1-philmd@redhat.com> References: <20200227163101.414-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , Stefan Weil , Markus Armbruster , Michael Roth , =?UTF-8?q?Tom=C3=A1=C5=A1=20Golembiovsk=C3=BD?= , Stefan Hajnoczi , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Paolo Bonzini , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The string returned by g_win32_error_message() has to be deallocated with g_free(). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Marc-Andr=C3=A9 Lureau --- qga/channel-win32.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/qga/channel-win32.c b/qga/channel-win32.c index c86f4388db..774205e017 100644 --- a/qga/channel-win32.c +++ b/qga/channel-win32.c @@ -302,8 +302,8 @@ static gboolean ga_channel_open(GAChannel *c, GAChannel= Method method, OPEN_EXISTING, FILE_FLAG_NO_BUFFERING | FILE_FLAG_OVERLAPPED, = NULL); if (c->handle =3D=3D INVALID_HANDLE_VALUE) { - g_critical("error opening path %s: %s", newpath, - g_win32_error_message(GetLastError())); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + g_critical("error opening path %s: %s", newpath, emsg); return false; } =20 --=20 2.21.1