From nobody Thu Nov 13 21:51:52 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582798735; cv=none; d=zohomail.com; s=zohoarc; b=hcl0hkZroDS1RADLevaBiPvpFQTbt0efC5HfhR3ola6CyQDYos7s05dqRizQ5gBYxA/3W2HFe2i7rSocNyDosDVzAnkUU9iOQmV/yNe9HAFDPQsVs6eOiucuK1mEWzrPxR9jK5saLBpeRU6AXWI5NT/PKq/FYeJ6dLEDETS6KRk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582798735; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=LMudDymxhn5SYN8zB8osoTwCL+VNgZTY4vrznHYmidc=; b=dI2Izsa0WArhKo0hRGAuXpRijoYS0muQMbVtZRfmNkd5xOi4E5e5mPQ1oYQxnOckeNqgagsD3yHR1Tw8dGQfx+MiaSZm+WEUgUyXvaID/nGBGaPfdQEwGi34vcWl7ekC646PRSGj0ebLGj5ucHYfxgNZFgBQzMrPLQPXRExanDM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582798735390750.3252777320932; Thu, 27 Feb 2020 02:18:55 -0800 (PST) Received: from localhost ([::1]:56626 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GFp-0007qX-US for importer@patchew.org; Thu, 27 Feb 2020 05:18:53 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:39865) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7GAt-00032j-6b for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:13:49 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7GAs-0006Iw-5n for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:13:47 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:55255 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7GAs-0006EZ-1P for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:13:46 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-318-VH5RIL7ANKGMIbL5DCQQvQ-1; Thu, 27 Feb 2020 05:13:44 -0500 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id DD9EC107B7DB; Thu, 27 Feb 2020 10:13:42 +0000 (UTC) Received: from t480s.redhat.com (ovpn-116-36.ams2.redhat.com [10.36.116.36]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2C8F96E3EE; Thu, 27 Feb 2020 10:13:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582798425; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=LMudDymxhn5SYN8zB8osoTwCL+VNgZTY4vrznHYmidc=; b=eQvAd3fOyO4PRAUpPDITfhLKEQdvlL20O6nz1ESV4nbNAp7nvN5CufJFFcbpCzSzvOGB48 EXBPFqK0IgQ/iuxMMBvPNsCxacDhCZ2aUFStRcTVnSOt8ruSbudlqXjvKKFEPk8fCinU+4 WZL6ckPITKr14abnE6wNBvVZUgNkaZQ= X-MC-Unique: VH5RIL7ANKGMIbL5DCQQvQ-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v3 05/15] exec: Reuse qemu_ram_apply_settings() in qemu_ram_remap() Date: Thu, 27 Feb 2020 11:11:55 +0100 Message-Id: <20200227101205.5616-6-david@redhat.com> In-Reply-To: <20200227101205.5616-1-david@redhat.com> References: <20200227101205.5616-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , "Michael S . Tsirkin" , Richard Henderson , Igor Kotrasinski , David Hildenbrand , "Dr . David Alan Gilbert" , Peter Xu , Murilo Opsfelder Araujo , Igor Mammedov , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" I don't see why we shouldn't apply all settings to make it look like the surrounding RAM (and enable proper VMA merging). Note: memory backend settings might have overridden these settings. We would need a callback to let the memory backend fix that up. Reviewed-by: Richard Henderson Reviewed-by: Peter Xu Cc: Richard Henderson Cc: Paolo Bonzini Cc: Igor Mammedov Signed-off-by: David Hildenbrand --- exec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/exec.c b/exec.c index a0a8d93fee..1fc1fa237e 100644 --- a/exec.c +++ b/exec.c @@ -2516,8 +2516,7 @@ void qemu_ram_remap(ram_addr_t addr, ram_addr_t lengt= h) length, addr); exit(1); } - memory_try_enable_merging(vaddr, length); - qemu_ram_setup_dump(vaddr, length); + qemu_ram_apply_settings(vaddr, length); } } } --=20 2.24.1