From nobody Thu Nov 13 21:52:19 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582797919; cv=none; d=zohomail.com; s=zohoarc; b=j3ZXfNVDLr/Qww2Vm2M5Sh9a8JvwwvoFLnvcP9Wm5aROwMPnIQroJNuhxa3QR/3ZL3T9SGf2fdIOpnCsgt7M62nDnYb4B0aYo40mJCKz9mtd+xJnLz818xSvejaQNNnhS5KYwUw7//x6PA0YUztS3YCslQ6AJG1GnUcyG0mSRvI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582797919; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=z7MUcizcjT8mmfm7wQjzBurTyv6zocr1z5HIlwjNKTE=; b=BMhjB17mI7+YwWz4PAY+xB/IpWY/mIBA+32YVOl6v6CkL6t1d1f/IFS/7IwGK1Ks4T9gDiX75q0l4huZ15tnnoBvkKVDiBqRFumwYlwBGA3x31sdF277g/NJENxHMsE44/ilmLspOTkWrln/aHfWqveZw1P7ERJdxnRvXlfBv/w= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582797919327508.07281645070873; Thu, 27 Feb 2020 02:05:19 -0800 (PST) Received: from localhost ([::1]:56428 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7G2g-0004CQ-1g for importer@patchew.org; Thu, 27 Feb 2020 05:05:18 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:35392) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j7G0a-0001iY-Mt for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:03:09 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j7G0Z-0002kB-Od for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:03:08 -0500 Received: from us-smtp-2.mimecast.com ([205.139.110.61]:58187 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j7G0Z-0002ip-L0 for qemu-devel@nongnu.org; Thu, 27 Feb 2020 05:03:07 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-346-Nf4PoOHZM6W4LhubDij_Kw-1; Thu, 27 Feb 2020 05:03:03 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B1726189F760; Thu, 27 Feb 2020 10:03:02 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-195.brq.redhat.com [10.40.205.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id B5D9C8B779; Thu, 27 Feb 2020 10:03:00 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582797787; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=z7MUcizcjT8mmfm7wQjzBurTyv6zocr1z5HIlwjNKTE=; b=bR9KM0qqmTzhueA94zqY5sR3aMF3JJXGMHbdX5f0n3xCbZcGZIELnwq0vydRFS+//RfxVg BAqEWW0pU+Js2LTJ4FA1xq4OhqQo8FpU9epevjBW0yzIjMJsWMbdB0P2za6zj7lxdBgQr8 b3NjnTfyuFTxLUab4gpT2+r+HizyEPs= X-MC-Unique: Nf4PoOHZM6W4LhubDij_Kw-1 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org Subject: [PATCH 2/2] util/oslib-win32: Improve error report by calling error_setg_win32() Date: Thu, 27 Feb 2020 11:02:50 +0100 Message-Id: <20200227100250.20514-3-philmd@redhat.com> In-Reply-To: <20200227100250.20514-1-philmd@redhat.com> References: <20200227100250.20514-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.61 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Daniel P . Berrange" , qemu-trivial@nongnu.org, Stefan Weil , Paolo Bonzini , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Use error_setg_win32() which adds a hint similar to strerror(errno)). Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Daniel P. Berrang=C3=A9 --- util/oslib-win32.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/util/oslib-win32.c b/util/oslib-win32.c index e9b14ab178..d2fca1808d 100644 --- a/util/oslib-win32.c +++ b/util/oslib-win32.c @@ -46,7 +46,8 @@ void *qemu_oom_check(void *ptr) { if (ptr =3D=3D NULL) { - fprintf(stderr, "Failed to allocate memory: %lu\n", GetLastError()= ); + g_autofree gchar *emsg =3D g_win32_error_message(GetLastError()); + fprintf(stderr, "Failed to allocate memory: %s\n", emsg); abort(); } return ptr; --=20 2.21.1