From nobody Thu Nov 13 22:13:55 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582770994; cv=none; d=zohomail.com; s=zohoarc; b=oFj64vnu5csw/XYjWMMMwQseIiupywKiiI7zXZm1wVK+O2LaP/1vFANWLZV6eRUZ78LdEag1HyxvQ6XAY+wMuVEsp5ZcHenbkFQtPAJnn4QQLsS80H4q3+c1z99P5aH3YrNJ8bBP6KZD1TZPJdHrCEA6X9acZCjp7rCNv7WV1Z4= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582770994; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Iv105vkxIe0Uy2naZRZUTtJcw1gfTsk/nHorpSEHeHM=; b=dzM2RX8qOCA6dymTfKQLMeyTaeaFsbE+0p0bQYP0+xpc4aMXk93IHDTiMeg/Qt8epEox6fqmsMrQwDCVWIf1qdGcoLaPzXHFZH0SVpAvGPnRDX2bfJ3ITlBEGXy3/D9jmRJKSb92+e0rVowz88CkbgwYXHgbnxw0Nm4FaChXxDk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582770994711693.9846970225738; Wed, 26 Feb 2020 18:36:34 -0800 (PST) Received: from localhost ([::1]:52948 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j792O-00012e-G6 for importer@patchew.org; Wed, 26 Feb 2020 21:36:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:60083) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j791R-0007wl-Bg for qemu-devel@nongnu.org; Wed, 26 Feb 2020 21:35:34 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j791Q-0001aO-AD for qemu-devel@nongnu.org; Wed, 26 Feb 2020 21:35:33 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3173 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j791O-0001OE-0L; Wed, 26 Feb 2020 21:35:30 -0500 Received: from DGGEMS409-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 8DEEA4DC289EFDFADFF7; Thu, 27 Feb 2020 10:35:26 +0800 (CST) Received: from localhost.localdomain (10.175.104.216) by DGGEMS409-HUB.china.huawei.com (10.3.19.209) with Microsoft SMTP Server id 14.3.439.0; Thu, 27 Feb 2020 10:35:18 +0800 From: Pan Nengyuan To: Subject: [PATCH v3 3/6] hw/arm/spitz: move timer_new from init() into realize() to avoid memleaks Date: Thu, 27 Feb 2020 10:50:52 +0800 Message-ID: <20200227025055.14341-4-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200227025055.14341-1-pannengyuan@huawei.com> References: <20200227025055.14341-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.104.216] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: zhang.zhanghailiang@huawei.com, Pan Nengyuan , qemu-devel@nongnu.org, qemu-arm@nongnu.org, euler.robot@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" There are some memleaks when we call 'device_list_properties'. This patch m= ove timer_new from init into realize to fix it. Reported-by: Euler Robot Signed-off-by: Pan Nengyuan --- Cc: Andrzej Zaborowski --- hw/arm/spitz.c | 8 +++++++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/hw/arm/spitz.c b/hw/arm/spitz.c index e001088103..cbfa6934cf 100644 --- a/hw/arm/spitz.c +++ b/hw/arm/spitz.c @@ -524,11 +524,16 @@ static void spitz_keyboard_init(Object *obj) =20 spitz_keyboard_pre_map(s); =20 - s->kbdtimer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, spitz_keyboard_tick, = s); qdev_init_gpio_in(dev, spitz_keyboard_strobe, SPITZ_KEY_STROBE_NUM); qdev_init_gpio_out(dev, s->sense, SPITZ_KEY_SENSE_NUM); } =20 +static void spitz_keyboard_realize(DeviceState *dev, Error **errp) +{ + SpitzKeyboardState *s =3D SPITZ_KEYBOARD(dev); + s->kbdtimer =3D timer_new_ns(QEMU_CLOCK_VIRTUAL, spitz_keyboard_tick, = s); +} + /* LCD backlight controller */ =20 #define LCDTG_RESCTL 0x00 @@ -1115,6 +1120,7 @@ static void spitz_keyboard_class_init(ObjectClass *kl= ass, void *data) DeviceClass *dc =3D DEVICE_CLASS(klass); =20 dc->vmsd =3D &vmstate_spitz_kbd; + dc->realize =3D spitz_keyboard_realize; } =20 static const TypeInfo spitz_keyboard_info =3D { --=20 2.18.2