From nobody Thu Nov 13 20:44:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1582740685; cv=none; d=zohomail.com; s=zohoarc; b=QycMBgLOCHyFuuxWn6yakMs1bVp0ckP9GbwZgsIH1oUIrPq9pIe+MGa1bvUcsY9RZhPu8ay7L1FSkI+rJrXSZMLsrW2UCpddI8IQbsMaojPeQFLsyMIqbr0W2l/iZaZHpEO4NjSLg76FPah6smtpQ6Xb7mrXdfFW7M+omiHM478= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582740685; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=BW1rVVuvHSIHaMM8u2a8l8PWRGvK4vmAgMmHgrFc8bQ=; b=RMVA4mf4PINFk6EP1xV/h8mptmDuf6dEpGftBAnllsi2VT0zrOMItcT1daQYjrZSBfyjMXaqZ8rJrnpP+wwZIcX4oRDBwFWNQuErINIRGNM2Te9+o3InJn0f0vluKpKN3nkWa8s7GLBfoeJjqDb3Psube7esHX8mq9hM1D5FLIs= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582740685125410.68042024185445; Wed, 26 Feb 2020 10:11:25 -0800 (PST) Received: from localhost ([::1]:48330 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j719Y-0008UQ-23 for importer@patchew.org; Wed, 26 Feb 2020 13:11:24 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40652) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j718d-00076v-Fz for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j718b-000642-Me for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:27 -0500 Received: from mail-wr1-x441.google.com ([2a00:1450:4864:20::441]:33449) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j718b-000637-GQ for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:25 -0500 Received: by mail-wr1-x441.google.com with SMTP id u6so4331237wrt.0 for ; Wed, 26 Feb 2020 10:10:25 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id p26sm3725420wmc.24.2020.02.26.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 10:10:21 -0800 (PST) Received: from zen.home.arpa (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id E8FF51FF8C; Wed, 26 Feb 2020 18:10:20 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=BW1rVVuvHSIHaMM8u2a8l8PWRGvK4vmAgMmHgrFc8bQ=; b=NRWIeo+TbwqyFHiuPlZeJfbjbxrZkRBenWPlixbEeIHkcZkhUjJOFOYs1KRoDIs1Cc Hr9SN7GFX/7lWvt5hq54iru7ozw0Q5eejip0/yJhULvtM+Q2Ib0LesSOnQ2TUXYDBPU0 4hFdevSeqtsXzulLw0a8IPGGGZix2HTUgVlOTiJ7V57S6iuVhTiJ+UenIOYLTOhRPaqa GUqqUWQJ4GRXQGijmul/6L9dB+hrbyohw5JkdA/MrlJr/O1ZqXA3ob9zzNqOPYnK5RIq 2quzMNw7AzaptbgvYjB8K1tj0nI9h9RfCv0ieXbzvdgHUuNfCOePTm6wyCdB7fvOgmwr VTBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=BW1rVVuvHSIHaMM8u2a8l8PWRGvK4vmAgMmHgrFc8bQ=; b=hTooTRIYgwY72ahDXbDZdpMvzdqEzWuQg5WpUe+J3hZZ7VqBjVgL6qKA543UHyNE4Q /uOf26dX5P6LORTHb1n8ORqlk9fQTy3oKBu/ipm/C4eI94TR+Uv8JDwQfo93+lYMAmRj nWwb1XHVk/d4T6nH2Ts873dcbWD4nMOOxX3k6cHTdpSsGmPh5ElzkIK7kYJ9GXvYQ/io vJ3e06eluEMGnUobIAGjbJYdePZNIH3N3U01YhYTtBKvV7VcgRciOo1AwDAeW2fzC5H+ bNyUFd0XOhwzg79EaUvEzgqvSZW0O3W3PSfx2poY98wvkL+XnBZe8Wb2gYkE7Z8kdLtz Gacg== X-Gm-Message-State: APjAAAX9RBhDksUI8xfSNdxMx5JJ9mqnFnoF3XxjsvCEzX5RtZOwSKcw GB0c7Nzr0rJsFeW26Kb0CttkGYk7aAM= X-Google-Smtp-Source: APXvYqwcSteicOJ0uFqauIDpb/K6QH2cZeUNx7e7lFnmFTo488gfslFyzgQlaJqM2WDZ3PpfqnKJXw== X-Received: by 2002:adf:f606:: with SMTP id t6mr6780858wrp.304.1582740624387; Wed, 26 Feb 2020 10:10:24 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 1/4] accel/tcg: use units.h for defining code gen buffer sizes Date: Wed, 26 Feb 2020 18:10:17 +0000 Message-Id: <20200226181020.19592-2-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org> References: <20200226181020.19592-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::441 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) It's easier to read. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Niek Linnenbank Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/translate-all.c | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index a08ab11f657..238b0e575bf 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -18,6 +18,7 @@ */ =20 #include "qemu/osdep.h" +#include "qemu/units.h" #include "qemu-common.h" =20 #define NO_CPU_IO_DEFS @@ -901,33 +902,33 @@ static void page_lock_pair(PageDesc **ret_p1, tb_page= _addr_t phys1, =20 /* Minimum size of the code gen buffer. This number is randomly chosen, but not so small that we can't have a fair number of TB's live. */ -#define MIN_CODE_GEN_BUFFER_SIZE (1024u * 1024) +#define MIN_CODE_GEN_BUFFER_SIZE (1 * MiB) =20 /* Maximum size of the code gen buffer we'd like to use. Unless otherwise indicated, this is constrained by the range of direct branches on the host cpu, as used by the TCG implementation of goto_tb. */ #if defined(__x86_64__) -# define MAX_CODE_GEN_BUFFER_SIZE (2ul * 1024 * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (2 * GiB) #elif defined(__sparc__) -# define MAX_CODE_GEN_BUFFER_SIZE (2ul * 1024 * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (2 * GiB) #elif defined(__powerpc64__) -# define MAX_CODE_GEN_BUFFER_SIZE (2ul * 1024 * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (2 * GiB) #elif defined(__powerpc__) -# define MAX_CODE_GEN_BUFFER_SIZE (32u * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (32 * MiB) #elif defined(__aarch64__) -# define MAX_CODE_GEN_BUFFER_SIZE (2ul * 1024 * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (2 * GiB) #elif defined(__s390x__) /* We have a +- 4GB range on the branches; leave some slop. */ -# define MAX_CODE_GEN_BUFFER_SIZE (3ul * 1024 * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (3 * GiB) #elif defined(__mips__) /* We have a 256MB branch region, but leave room to make sure the main executable is also within that region. */ -# define MAX_CODE_GEN_BUFFER_SIZE (128ul * 1024 * 1024) +# define MAX_CODE_GEN_BUFFER_SIZE (128 * MiB) #else # define MAX_CODE_GEN_BUFFER_SIZE ((size_t)-1) #endif =20 -#define DEFAULT_CODE_GEN_BUFFER_SIZE_1 (32u * 1024 * 1024) +#define DEFAULT_CODE_GEN_BUFFER_SIZE_1 (32 * MiB) =20 #define DEFAULT_CODE_GEN_BUFFER_SIZE \ (DEFAULT_CODE_GEN_BUFFER_SIZE_1 < MAX_CODE_GEN_BUFFER_SIZE \ --=20 2.20.1 From nobody Thu Nov 13 20:44:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1582740761; cv=none; d=zohomail.com; s=zohoarc; b=JS3d+RMo5IiQM6ZYkQfSx+Ins8Uw4rBbmWfo/BkK2S1YC19JCexiZNL37E9nzrmjyzun0PUaFMCFCK8gKR3v08Jh7nYbjeshCgIW/e0SjvdDT+t0mbvlAt4Xqzl9psBl5M5Jpqm9h0sNlK4x5V50byFaqAGqvRSl0xku9w+rwtw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582740761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hTO2TJKTVn6zYRsBqCfNS47JQf5FFH1MtA261qT+XBk=; b=AhtX6lu+MJp7ZLsFVAIcgu2MWwoNglKq8gfIpdX5u5lCUEh6DMql6juLsrmA/VMiQ9+8ccN1r5xLYrIvy1dw9O4/YwLEgtVGz2VNXWD5k1esGB/XaPQjZKnia0CvvT4EBBmNioEmaZPQDID57fezOfGRbrvF1KdRRS1DjAE0CoA= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582740761409755.5032022384631; Wed, 26 Feb 2020 10:12:41 -0800 (PST) Received: from localhost ([::1]:48362 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71Am-0002Cx-A9 for importer@patchew.org; Wed, 26 Feb 2020 13:12:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40661) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j718d-00077h-UN for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:28 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j718c-00065A-PU for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:27 -0500 Received: from mail-wm1-x341.google.com ([2a00:1450:4864:20::341]:50577) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j718c-00064S-Iu for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:26 -0500 Received: by mail-wm1-x341.google.com with SMTP id a5so284128wmb.0 for ; Wed, 26 Feb 2020 10:10:26 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id z10sm3867301wmk.31.2020.02.26.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 10:10:21 -0800 (PST) Received: from zen.home.arpa (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 08C411FF8F; Wed, 26 Feb 2020 18:10:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=hTO2TJKTVn6zYRsBqCfNS47JQf5FFH1MtA261qT+XBk=; b=XhZKl9/y1LXlkcu4qnQDHpOSISFfZXX5rZTkBK3XsCMR7LgI/JUaD75+mDloiGDs+T DXpIrXPkXY90+FfirwZzGMYnna1qoqIjQnYRFbTq9zNYGmSXJxAe2cV4Sx+ZFWeSQ5uy 6Fg/RNivdqoJT3z0YPHlO+C4z5UpSDqsGFJWvYKm0BUfKNes/OEc16rr6bYiIlByZ2Yv XOw/lf2pQRxWwVkFScpLm274JOJ8tBR7W/SyED7t7ofrxHj1Y4Y8QtjfxcYfM4z05RFa eWK+wv+PK3az5Ez5I6MD6LlHHe8PAV4Y1Loejl1G34+ceN0QVFM1IY6D3uj+11egqODk Z5/A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=hTO2TJKTVn6zYRsBqCfNS47JQf5FFH1MtA261qT+XBk=; b=rA/ZhhilYWaW64TjBv/2haZY/lwBFyMzommhW/4ULX+VQKmOqhgrHvi4LX8j+PiSKc U+IMGxU/sdsiWpETj9XO0r7D9c7aqjKzyp+cWrMP+V3RwTqoq19/SngArF1TisC/TRVd AUWLKfrpJ5RZf5YgcYlcHNmu7D3oeGH53BWGou0CBYX03TQ6gymBTt6KtNxOAVO2boXo h9aoMgfpb9Dd+WmjrPP7CQKPI3lyt1NHNxHqIr9tNy5Bago2gRWgoIkPk3EX3dDLrDjT veCK5e8Whd7V0ZpulvQv9JB6jewfHNCtlIiFTLFPWDgZo6TfuJ49nv9gIEVyiJUPO38z xLow== X-Gm-Message-State: APjAAAWTYvsqnIcl+X7ViSJOnJOq0kaP8ino59LK3KX1zK5Ug1FO3rlI e8XMeKwDs3VUqurVSlZ0a60qWQ== X-Google-Smtp-Source: APXvYqzQgMdzyv1kRIJ0A5xZ+8PIob9SLYhIZRVPTr+Ie+CbSKOG8v5VAmbmd0Cdfaay52qGOEfKSQ== X-Received: by 2002:a1c:a4c3:: with SMTP id n186mr110130wme.25.1582740625545; Wed, 26 Feb 2020 10:10:25 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 2/4] accel/tcg: remove link between guest ram and TCG cache size Date: Wed, 26 Feb 2020 18:10:18 +0000 Message-Id: <20200226181020.19592-3-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org> References: <20200226181020.19592-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::341 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Niek Linnenbank , qemu-arm@nongnu.org, Paolo Bonzini , Igor Mammedov , =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Basing the TB cache size on the ram_size was always a little heuristic and was broken by a1b18df9a4 which caused ram_size not to be fully realised at the time we initialise the TCG translation cache. The current DEFAULT_CODE_GEN_BUFFER_SIZE may still be a little small but follow-up patches will address that. Fixes: a1b18df9a4 Signed-off-by: Alex Benn=C3=A9e Cc: Niek Linnenbank Cc: Igor Mammedov Reviewed-by: Richard Henderson Tested-by: Niek Linnenbank Tested-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/translate-all.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 238b0e575bf..5b66af783b5 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -938,15 +938,7 @@ static inline size_t size_code_gen_buffer(size_t tb_si= ze) { /* Size the buffer. */ if (tb_size =3D=3D 0) { -#ifdef USE_STATIC_CODE_GEN_BUFFER tb_size =3D DEFAULT_CODE_GEN_BUFFER_SIZE; -#else - /* ??? Needs adjustments. */ - /* ??? If we relax the requirement that CONFIG_USER_ONLY use the - static buffer, we could size this on RESERVED_VA, on the text - segment size of the executable, or continue to use the default.= */ - tb_size =3D (unsigned long)(ram_size / 4); -#endif } if (tb_size < MIN_CODE_GEN_BUFFER_SIZE) { tb_size =3D MIN_CODE_GEN_BUFFER_SIZE; --=20 2.20.1 From nobody Thu Nov 13 20:44:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1582740761; cv=none; d=zohomail.com; s=zohoarc; b=ffDC39gsdlrLPyavme4M4hxBB0rehcJO8YptXsfZayf4UNAKhBhUgKn+KSzuk56AqhChRrHiWov8q+xzHC+C4EguhsBF6ezxF+YMOm5MOZn7t4nnb6KfHv92q43qMQ1b3tPs7vBLdShRVyho12PpXTlhdgFp0FJZ/yvuE4g1/qM= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582740761; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=hVy/VS0FWeHo9oOxiCCfD4MP3OOalx8Xcbvt8rhf/op19V7vvgsobQa0zt2QfpSyttUCfvc2ndt/Ux80a+d8OdQlw4Uyw7gtlCTIEo6680Ir7ZJkIKvDo4XzmPDRj0hYsoJTwtgqkXGh0BMHPNIygNqjlPJRey05T+jmwQBMPhM= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582740761192659.3901698454318; Wed, 26 Feb 2020 10:12:41 -0800 (PST) Received: from localhost ([::1]:48358 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71Am-0002CY-0n for importer@patchew.org; Wed, 26 Feb 2020 13:12:40 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40701) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j718g-0007DV-Ak for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:31 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j718f-00067T-9q for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:30 -0500 Received: from mail-wm1-x344.google.com ([2a00:1450:4864:20::344]:52080) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j718f-00066o-3d for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:29 -0500 Received: by mail-wm1-x344.google.com with SMTP id t23so276429wmi.1 for ; Wed, 26 Feb 2020 10:10:29 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id a3sm4411073wrq.63.2020.02.26.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 10:10:23 -0800 (PST) Received: from zen.home.arpa (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 1EC1B1FF90; Wed, 26 Feb 2020 18:10:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=eQSzHAVFumHhzYdBXmXaE+cLeTGQO0bIkGTK6aArG9UlqWjheMpZwpKL2FFgVCBK2A jrTISFiiSo7GVEZzZb5FDb5B10PDCEK94WFe8EA11eFdDJOjDVKNmt7Qjj/SQqpZtOTS naulW5shQLyMIwS/Sxe4vvJG1Jg03fulYxnAADa2iP7OMVL0l8A9VV302ePNKILWztuv tNfhuOBrR2YUAUidiH5j3D4e8QeGaYjxNb96U7k2pLCYi3foTMLgEVcWoyOfXUGlhibb WLQU+7ENJcHPPwKfrmyh7MfDZE+lGhk/Q1/QpCOfhCMGX6qJJoNyLwOz4pKCOe0QT/Y/ HcHw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=qFnkfoP8m+qXflyejUwS/Vipa7DcI1oKmkPYEaLcY/E=; b=XFaUy3J3bRx4pL/8RsNBeFafvuvcunxhJxFA6R8c9gksh5lLWm+9zLSOf019L0BS/1 yJPRM1BhQsMW8pY2yjNctX8hfvyQKzKX391V5mVHtxjWzFQMsGli0xyGrXARm3zSqaNx JZIkhXif3ppme0BvSG6lnnzQAZ2HAmOfPDoxFvwLHGSs+jhdv7GSQQy+IysgFK+5EH4g 9bkg0/yXkh97DHLicjXTIfn58vG4WVOQkKsE6m/HCVs/jfGqKtOrlkiBIuXu+KiWmUbQ a3eYjb79KCcqdoVP2Xxd3D43jEVMs3vEL1jk/KQvFGess+Z+krQNeSvHvVQ00jEVt4xl l8wA== X-Gm-Message-State: APjAAAWIa0OoF5RNBuD1ydb2iUnuc5WAqRmWcxWhgS7ODr85Bf1rQT/t UBEOtQWpaUhjmlMugg8lZZzkIw== X-Google-Smtp-Source: APXvYqyU7dH6wL9d0FysM1K0oct/PLODu+U5CObWBIGDNsmE1uCTxo0a9lj/QQUm2E0m1Jup4eHpJw== X-Received: by 2002:a7b:c152:: with SMTP id z18mr132561wmi.70.1582740628019; Wed, 26 Feb 2020 10:10:28 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 3/4] accel/tcg: only USE_STATIC_CODE_GEN_BUFFER on 32 bit hosts Date: Wed, 26 Feb 2020 18:10:19 +0000 Message-Id: <20200226181020.19592-4-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org> References: <20200226181020.19592-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::344 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) There is no particular reason to use a static codegen buffer on 64 bit hosts as we have address space to burn. Allow the common CONFIG_USER case to use the mmap'ed buffers like SoftMMU. Signed-off-by: Alex Benn=C3=A9e Reviewed-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: Richard Henderson Tested-by: Philippe Mathieu-Daud=C3=A9 --- accel/tcg/translate-all.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 5b66af783b5..4ce5d1b3931 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -892,11 +892,12 @@ static void page_lock_pair(PageDesc **ret_p1, tb_page= _addr_t phys1, } } =20 -#if defined(CONFIG_USER_ONLY) -/* Currently it is not recommended to allocate big chunks of data in - user mode. It will change when a dedicated libc will be used. */ -/* ??? 64-bit hosts ought to have no problem mmaping data outside the - region in which the guest needs to run. Revisit this. */ +#if defined(CONFIG_USER_ONLY) && TCG_TARGET_REG_BITS =3D=3D 32 +/* + * For user mode on smaller 32 bit systems we may run into trouble + * allocating big chunks of data in the right place. On these systems + * we utilise a static code generation buffer directly in the binary. + */ #define USE_STATIC_CODE_GEN_BUFFER #endif =20 --=20 2.20.1 From nobody Thu Nov 13 20:44:54 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=linaro.org ARC-Seal: i=1; a=rsa-sha256; t=1582740848; cv=none; d=zohomail.com; s=zohoarc; b=aOabV24EyUR2sRZBmUmPdSUTpaYNp/Kazmvo9ds60q04tcRhk7+9U4mSDRuiv8KARjMdUwAE1kaygGBYNHV8M8Lm3GDNBfvHuD/s9szmgMl1SlnZvDfOKN8YW/BBhLZnw8boRRTSAYCEZ8AhodqLDW2INBAXzNslXXHV+Efp/wA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582740848; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=mGdhokziaFlD24j2e180ug759eZelaxuW6pu6HeYdT8=; b=adBpiDzsI97c5t09bRbZH5V2Sphrcp63bLyQde2Wgd9epMUzKdF3SPcYxOh33tNl/t/D8yydjqG0gmp850rCcLqVhQ8ccE6J+x5cX9cBqQgPnThYhCKv6g6bOXYIEFNtx3yQMnKdY8YSn8m2eULdk0EEUy650d+l0SYbUhF8+y0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582740848636285.1874251114525; Wed, 26 Feb 2020 10:14:08 -0800 (PST) Received: from localhost ([::1]:48410 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j71CB-0004jg-DH for importer@patchew.org; Wed, 26 Feb 2020 13:14:07 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:40732) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j718h-0007Gy-ED for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:32 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j718g-00068Y-FG for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:31 -0500 Received: from mail-wr1-x442.google.com ([2a00:1450:4864:20::442]:37061) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1j718g-00067j-9M for qemu-devel@nongnu.org; Wed, 26 Feb 2020 13:10:30 -0500 Received: by mail-wr1-x442.google.com with SMTP id l5so4305157wrx.4 for ; Wed, 26 Feb 2020 10:10:30 -0800 (PST) Received: from zen.linaroharston ([51.148.130.216]) by smtp.gmail.com with ESMTPSA id n5sm4223973wrq.40.2020.02.26.10.10.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 26 Feb 2020 10:10:25 -0800 (PST) Received: from zen.home.arpa (localhost [127.0.0.1]) by zen.linaroharston (Postfix) with ESMTP id 326FD1FF91; Wed, 26 Feb 2020 18:10:21 +0000 (GMT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=mGdhokziaFlD24j2e180ug759eZelaxuW6pu6HeYdT8=; b=S6PCTofgeYtP2Wsm4aYo/W9iKZZgEEkaoEfhMSkuk3t1Gw1gr4k6Ei0rXViBm7YXON k9MUApcURl81lTk0y1GvkekR2TQE8wka0qKAdw/rKYg96Hou3ySxw57m1QJMBbW/UYiw Yg9teIYwwZHdAo8cKaMy990lCu5CSR9f4+6xxk7E/YhcPnfi8z5SO+hhbgpIGNuD+dji V4AHxWNrEWkaMR5Aij9+ZPs4jjuWRketPCY1enCZ4u5ZkfkZw4Zy8HdNd412kXlNg+6c TBSZj0eo5h8i9LPuWlxK2g2HAJ7thZc9oY+v9dwOtqxxw/gJkY6bS65f6l5OSwcuSMD/ CSOA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=mGdhokziaFlD24j2e180ug759eZelaxuW6pu6HeYdT8=; b=aZUefVf4gNd1AHE2vepf93jCyrlhhlm9GJ3Ll+rPQEUdwgm1AE/9yUN+Ow55wKCcbB s87yMsvjb9julad906z+rK99vPfTLMsEG1Ygr/NdJx+3YmU5Gms9o9HjxfpGEoW7KSMy wTFILWzkDGXcoOkZ2nl2vyaZbG4/tCDdxkeDAu0qQl9MQSt643B1mVuCAfNNebrjRmRb wU0TR9br33d22IZDOJBXPjBDwLKegbJ14/dn7k7zfKaZQU8m75153YQzEJBTh6LA2I4J ucnc6088BhpPMMfbOunysPib9iPSCJLQASUoTzFweRvuCH5l5KZpOwVvMumuALdYOUiP 5JKQ== X-Gm-Message-State: APjAAAUhCFy/3U3+HDTxZaEuoU0aZzBul5FrWuNpprYkKJVlaSe91P1s aXcJmDv4AspZGnPz9D6YZ/hhjQ== X-Google-Smtp-Source: APXvYqxGDjFnY6b5blMr7GM/ru+U+9CiqyaFPCP0PoqNCXpX+OmvjNLgdq3NDV7f/mRHl9YpzpqytA== X-Received: by 2002:a5d:440f:: with SMTP id z15mr6669505wrq.420.1582740629273; Wed, 26 Feb 2020 10:10:29 -0800 (PST) From: =?UTF-8?q?Alex=20Benn=C3=A9e?= To: qemu-devel@nongnu.org Subject: [PATCH v1 4/4] accel/tcg: increase default code gen buffer size for 64 bit Date: Wed, 26 Feb 2020 18:10:20 +0000 Message-Id: <20200226181020.19592-5-alex.bennee@linaro.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20200226181020.19592-1-alex.bennee@linaro.org> References: <20200226181020.19592-1-alex.bennee@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a00:1450:4864:20::442 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Paolo Bonzini , qemu-arm@nongnu.org, =?UTF-8?q?Alex=20Benn=C3=A9e?= , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) While 32mb is certainly usable a full system boot ends up flushing the codegen buffer nearly 100 times. Increase the default on 64 bit hosts to take advantage of all that spare memory. After this change I can boot my tests system without any TB flushes. Signed-off-by: Alex Benn=C3=A9e Tested-by: Niek Linnenbank --- accel/tcg/translate-all.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/accel/tcg/translate-all.c b/accel/tcg/translate-all.c index 4ce5d1b3931..f7baa512059 100644 --- a/accel/tcg/translate-all.c +++ b/accel/tcg/translate-all.c @@ -929,7 +929,11 @@ static void page_lock_pair(PageDesc **ret_p1, tb_page_= addr_t phys1, # define MAX_CODE_GEN_BUFFER_SIZE ((size_t)-1) #endif =20 +#if TCG_TARGET_REG_BITS =3D=3D 32 #define DEFAULT_CODE_GEN_BUFFER_SIZE_1 (32 * MiB) +#else +#define DEFAULT_CODE_GEN_BUFFER_SIZE_1 (2 * GiB) +#endif =20 #define DEFAULT_CODE_GEN_BUFFER_SIZE \ (DEFAULT_CODE_GEN_BUFFER_SIZE_1 < MAX_CODE_GEN_BUFFER_SIZE \ --=20 2.20.1