From nobody Thu Nov 13 21:50:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582732507; cv=none; d=zohomail.com; s=zohoarc; b=UCa4RBpHMYWzfAgtGLiqPzpT4/uub/VTAgUfYkfAh90fXZpi16EYFI+A7hsifC49cYWeVZ6StXfFkET/cv5esktcO7iB4Y0GwZ/q2oZHdk21mdNZJSvffbReH7oruMv11yATGjFVRYAX7cgi45eQGkUl3XjBUTUDYFnzyKvApuI= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582732507; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=5SAil29C2B/8RRVuO+5knjn0nj8iH/o7OggV0iKssVQ=; b=LDcBHwTzw7uGv8WsTCVogCXkfywZfMjx6nE967OL8M+e1AfOX6dn2h6ituni7B6IdFJ989e+9z6e6kSIPnPdcr80r1tjTDjmbwbzIPCL2qSjz6lgLJ/xmC365FiWyNicKTrGHGm1DKQVnQwJMa6NINJKysW7jZicODCb7FbdEDg= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582732507458915.4636834145945; Wed, 26 Feb 2020 07:55:07 -0800 (PST) Received: from localhost ([::1]:46202 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6z1e-0004QO-9j for importer@patchew.org; Wed, 26 Feb 2020 10:55:06 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:33966) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6z0M-0002gM-HZ for qemu-devel@nongnu.org; Wed, 26 Feb 2020 10:53:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6z0L-0002oG-F5 for qemu-devel@nongnu.org; Wed, 26 Feb 2020 10:53:46 -0500 Received: from us-smtp-delivery-1.mimecast.com ([205.139.110.120]:48494 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6z0L-0002mc-Aj for qemu-devel@nongnu.org; Wed, 26 Feb 2020 10:53:45 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-160-lpyoPsZ_PieWswSaBSDR9w-1; Wed, 26 Feb 2020 10:53:41 -0500 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 325DC1005513; Wed, 26 Feb 2020 15:53:40 +0000 (UTC) Received: from t480s.redhat.com (ovpn-117-196.ams2.redhat.com [10.36.117.196]) by smtp.corp.redhat.com (Postfix) with ESMTP id 25728100EBAF; Wed, 26 Feb 2020 15:53:37 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582732424; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5SAil29C2B/8RRVuO+5knjn0nj8iH/o7OggV0iKssVQ=; b=GobRxe3BCNl9IfkhZU1LDg628fdnbLA+Vv/t7eso0+YV6XOCiKAT+VIWhk6qI+JYW75+RD glmlSHbjLaBkiKKRS8kDuRwwQh0+pZaUlbxnIeQgFncrNh8qiQFq+J9cVS6ClpnXj8kvey W23bXYPS8IKaBTQHbof7V4hoiNch8BM= X-MC-Unique: lpyoPsZ_PieWswSaBSDR9w-1 From: David Hildenbrand To: qemu-devel@nongnu.org Subject: [PATCH v3 04/13] numa: Make all callbacks of ram block notifiers optional Date: Wed, 26 Feb 2020 16:52:55 +0100 Message-Id: <20200226155304.60219-5-david@redhat.com> In-Reply-To: <20200226155304.60219-1-david@redhat.com> References: <20200226155304.60219-1-david@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 205.139.110.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Eduardo Habkost , Juan Quintela , David Hildenbrand , "Dr . David Alan Gilbert" , Peter Xu , Paolo Bonzini , Richard Henderson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Let's make add/remove optional. We want to introduce a RAM block notifier for RAM migration, that's only interested in resizes. Reviewed-by: Peter Xu Cc: Richard Henderson Cc: Paolo Bonzini Cc: Eduardo Habkost Cc: Marcel Apfelbaum Cc: Peter Xu Signed-off-by: David Hildenbrand --- hw/core/numa.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-) diff --git a/hw/core/numa.c b/hw/core/numa.c index fe6ca5c50d..37ce175e13 100644 --- a/hw/core/numa.c +++ b/hw/core/numa.c @@ -870,8 +870,11 @@ static int ram_block_notify_add_single(RAMBlock *rb, v= oid *opaque) void ram_block_notifier_add(RAMBlockNotifier *n) { QLIST_INSERT_HEAD(&ram_list.ramblock_notifiers, n, next); + /* Notify about all existing ram blocks. */ - qemu_ram_foreach_block(ram_block_notify_add_single, n); + if (n->ram_block_added) { + qemu_ram_foreach_block(ram_block_notify_add_single, n); + } } =20 void ram_block_notifier_remove(RAMBlockNotifier *n) @@ -884,7 +887,9 @@ void ram_block_notify_add(void *host, size_t size, size= _t max_size) RAMBlockNotifier *notifier; =20 QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) { - notifier->ram_block_added(notifier, host, size, max_size); + if (notifier->ram_block_added) { + notifier->ram_block_added(notifier, host, size, max_size); + } } } =20 @@ -893,7 +898,9 @@ void ram_block_notify_remove(void *host, size_t size, s= ize_t max_size) RAMBlockNotifier *notifier; =20 QLIST_FOREACH(notifier, &ram_list.ramblock_notifiers, next) { - notifier->ram_block_removed(notifier, host, size, max_size); + if (notifier->ram_block_removed) { + notifier->ram_block_removed(notifier, host, size, max_size); + } } } =20 --=20 2.24.1