From nobody Thu Nov 13 22:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707192; cv=none; d=zohomail.com; s=zohoarc; b=AT2S7CAzvPU9cDRWpFL3dFu4Kk5breybqOq42vLQwFdI4SERG9nZ0KYg7UnGefsnZF2diAPgF1OhbNVEo/L469l7TH6Fvx0gN3A6E2YNqzTIIeQRDnbydWtFrNAAMZgaR5aSdi86BsNZ8Yir9xTNqCP0jQ9uoEvGuM1tsyqABmk= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707192; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=I9ao/MFX0Zi2nYHkNH00MFCzo6mpXZ4uFBdZ7i2uL6A=; b=gG7v963q8++WSeMX7fB65746bKyJk0VNVy4SwZMjmfL7JbnBLdFQtQ57p4dgrVQLDHwlqLaqjtfwxxEDwDnSaw2fB2ySsNKqWOSG8xcnWnn5WnNyjAOqf2T7smTuLdENpjReoZWJZOH7ETyZvogrVP3yBW12RNl1BPxRQa73Gi4= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707192770375.1409717748767; Wed, 26 Feb 2020 00:53:12 -0800 (PST) Received: from localhost ([::1]:40108 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sRL-0001A6-Ba for importer@patchew.org; Wed, 26 Feb 2020 03:53:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44633) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sM7-0000Po-2e for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sM5-0007Z6-Vz for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:47 -0500 Received: from szxga04-in.huawei.com ([45.249.212.190]:3166 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM5-0007Ng-Hs; Wed, 26 Feb 2020 03:47:45 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 8414DBC3328692CDDA27; Wed, 26 Feb 2020 16:47:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:33 +0800 From: To: , Subject: [PATCH v2 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Wed, 26 Feb 2020 16:46:39 +0800 Message-ID: <20200226084647.20636-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.190 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Chen Qun , Euler Robot , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen =3D req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) r->iov.iov_base =3D blk_blockalign(s->qdev.conf.blk, r->buflen); } =20 - buflen =3D req->cmd.xfer; outbuf =3D r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) { --=20 2.23.0