From nobody Thu Nov 13 22:13:56 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582707305; cv=none; d=zohomail.com; s=zohoarc; b=LTUUeiU7BTvFSfZW2npZWtI2Spy6Yx3/1zyZllNWA/6+KbCug9dGYURwkew8Xe8czn345GSGxwViS7cj6QxBEwi19JqdtnkVLIamg7zS6J3PKFrA3a9hOTpHIn8jfyRUdwI0krb8U+BZqje+Vwlkstj9DqHfLT+pNnYgG+czD9I= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582707305; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=e4YD8cBie9uY3LBRhreGow3sUocGVPYszg0DW4w4Xrw=; b=mAmvtgrVPHl5gftkYJoqlypXRj+oReho4Vdl9L+JitPTMqT/Xw73T1cGkLQA+Ao5C/H4EFNAsGgIeLJqQg/4+FEmZTAv3EpQCy6M6NphHQ4d7XBG49YrVPINpMxj+6mFSc1iAwCTXCzN1B23lFziHpQRV3ncCaUxV9/XRByd3KQ= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582707305142708.0937633292531; Wed, 26 Feb 2020 00:55:05 -0800 (PST) Received: from localhost ([::1]:40154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sT9-0004wj-Rx for importer@patchew.org; Wed, 26 Feb 2020 03:55:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:44838) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6sMB-0000b7-7b for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:52 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6sMA-0007uk-3y for qemu-devel@nongnu.org; Wed, 26 Feb 2020 03:47:51 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:46048 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6sM9-0007jV-Nr; Wed, 26 Feb 2020 03:47:50 -0500 Received: from DGGEMS411-HUB.china.huawei.com (unknown [172.30.72.58]) by Forcepoint Email with ESMTP id 9221BA449786916D8ADB; Wed, 26 Feb 2020 16:47:47 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS411-HUB.china.huawei.com (10.3.19.211) with Microsoft SMTP Server id 14.3.439.0; Wed, 26 Feb 2020 16:47:37 +0800 From: To: , Subject: [PATCH v2 12/13] usb/hcd-ehci: Remove redundant statements Date: Wed, 26 Feb 2020 16:46:46 +0800 Message-ID: <20200226084647.20636-13-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.21.0.windows.1 In-Reply-To: <20200226084647.20636-1-kuhn.chenqun@huawei.com> References: <20200226084647.20636-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Gerd Hoffmann , Euler Robot , Chen Qun , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Type: text/plain; charset="utf-8" From: Chen Qun The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read again =3D -1; ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Gerd Hoffmann Cc: Philippe Mathieu-Daud=C3=A9 --- hw/usb/hcd-ehci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f457f..29d49c2d7e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } =20 /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int a= sync) =20 default: fprintf(stderr, "Bad state!\n"); - again =3D -1; g_assert_not_reached(); - break; } =20 if (again < 0 || itd_count > 16) { --=20 2.23.0