From nobody Thu Nov 13 20:43:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582616526; cv=none; d=zohomail.com; s=zohoarc; b=O8FrYgmsaN9UX/PfNurdvYxieZnLNM9YWTg4OiIPwom5o+yhUGEY7jbo3t9EoO2dOXjQ2rfsxAWOcKat3uvCVxnpCzgHxOusEU4Cm7wmi4CJ7ysG0fpViiDvpc38ijjb1TTdh9i8KKuWBbVgURK+huZQIB8JmeORxMH6vyHC1mE= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582616526; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=SQvPIXWeaI0af9ZXv2Q34hkbMFaqduB4oxK1IfaaI6I=; b=MajV831bo7yP6nyjT/k2FTGADY5wkljam8Y6rbX5Mu3koxC99Kg+EjQ/Gbx5fY8eQDU2aTQIl+qYY1Guh1vMIlZYYBKIk1D29zqNbdaww6AIf0orbgA5vBAmz6t3EmCuA9toj5QHpWNvXV2JXeTbQBgUesQgH0LHoSShSAAnakM= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582616526625788.8747082549627; Mon, 24 Feb 2020 23:42:06 -0800 (PST) Received: from localhost ([::1]:49976 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Uqz-0001tu-GE for importer@patchew.org; Tue, 25 Feb 2020 02:42:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:41042) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Upm-00009J-9Y for qemu-devel@nongnu.org; Tue, 25 Feb 2020 02:40:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6Upl-0003dx-6p for qemu-devel@nongnu.org; Tue, 25 Feb 2020 02:40:50 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:55772 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6Upk-0003dM-RH for qemu-devel@nongnu.org; Tue, 25 Feb 2020 02:40:49 -0500 Received: from DGGEMS408-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id ADAF1A2DFF4E42C25089; Tue, 25 Feb 2020 15:40:46 +0800 (CST) Received: from localhost.localdomain (10.175.104.216) by DGGEMS408-HUB.china.huawei.com (10.3.19.208) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 15:40:38 +0800 From: Pan Nengyuan To: Subject: [PATCH 4/4] virtio-crypto: do delete ctrl_vq in virtio_crypto_device_unrealize Date: Tue, 25 Feb 2020 15:55:54 +0800 Message-ID: <20200225075554.10835-5-pannengyuan@huawei.com> X-Mailer: git-send-email 2.18.2 In-Reply-To: <20200225075554.10835-1-pannengyuan@huawei.com> References: <20200225075554.10835-1-pannengyuan@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.175.104.216] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: "Gonglei \(Arei\)" , euler.robot@huawei.com, Pan Nengyuan , qemu-devel@nongnu.org, zhang.zhanghailiang@huawei.com Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" Similar to other virtio-deivces, ctrl_vq forgot to delete in virtio_crypto_= device_unrealize, this patch fix it. This device has aleardy maintained vq pointers. Thus, we use the new virtio= _delete_queue function directly to do the cleanup. The leak stack: Direct leak of 10752 byte(s) in 3 object(s) allocated from: #0 0x7f4c024b1970 in __interceptor_calloc (/lib64/libasan.so.5+0xef970) #1 0x7f4c018be49d in g_malloc0 (/lib64/libglib-2.0.so.0+0x5249d) #2 0x55a2f8017279 in virtio_add_queue /mnt/sdb/qemu-new/qemu_test/qemu/= hw/virtio/virtio.c:2333 #3 0x55a2f8057035 in virtio_crypto_device_realize /mnt/sdb/qemu-new/qem= u_test/qemu/hw/virtio/virtio-crypto.c:814 #4 0x55a2f8005d80 in virtio_device_realize /mnt/sdb/qemu-new/qemu_test/= qemu/hw/virtio/virtio.c:3531 #5 0x55a2f8497d1b in device_set_realized /mnt/sdb/qemu-new/qemu_test/qe= mu/hw/core/qdev.c:891 #6 0x55a2f8b48595 in property_set_bool /mnt/sdb/qemu-new/qemu_test/qemu= /qom/object.c:2238 #7 0x55a2f8b54fad in object_property_set_qobject /mnt/sdb/qemu-new/qemu= _test/qemu/qom/qom-qobject.c:26 #8 0x55a2f8b4de2c in object_property_set_bool /mnt/sdb/qemu-new/qemu_te= st/qemu/qom/object.c:1390 #9 0x55a2f80609c9 in virtio_crypto_pci_realize /mnt/sdb/qemu-new/qemu_t= est/qemu/hw/virtio/virtio-crypto-pci.c:58 Reported-by: Euler Robot Signed-off-by: Pan Nengyuan Cc: "Gonglei (Arei)" --- hw/virtio/virtio-crypto.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/hw/virtio/virtio-crypto.c b/hw/virtio/virtio-crypto.c index 7351ab0a19..4c65114de5 100644 --- a/hw/virtio/virtio-crypto.c +++ b/hw/virtio/virtio-crypto.c @@ -831,12 +831,13 @@ static void virtio_crypto_device_unrealize(DeviceStat= e *dev, Error **errp) =20 max_queues =3D vcrypto->multiqueue ? vcrypto->max_queues : 1; for (i =3D 0; i < max_queues; i++) { - virtio_del_queue(vdev, i); + virtio_delete_queue(vcrypto->vqs[i].dataq); q =3D &vcrypto->vqs[i]; qemu_bh_delete(q->dataq_bh); } =20 g_free(vcrypto->vqs); + virtio_delete_queue(vcrypto->ctrl_vq); =20 virtio_cleanup(vdev); cryptodev_backend_set_used(vcrypto->cryptodev, false); --=20 2.18.2