From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596952; cv=none; d=zohomail.com; s=zohoarc; b=ihQpIJQwkcvqHFJWUEqzR/Y3s51YARvsIHesXFULNLXtLQMqg3UgQP8aUQOjWJofQSNLrNHFzqrE25vid5KKHpYzMnf+ADBiVXTiNEfn5L3uNA7ChmcsUpH0XmcrolMLXSZ7c+9MsT8TNmGtXmbdYyfh+WjDN2SvUxkLalRjpzs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596952; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=azjfS/de6SjbIHX3C+ockGLnm2+mlYqEtMH6DZETfdc=; b=aihyJBYMSxSeCdOYlmKdgjcDfsmBaON2Hp4YnXCOaQgSy/cIZvn8ugWAhQm3p9M/Tw6zhrUKmlfx7l7tF4QBn+SxVMC8DeG9NB7hHIwkXDhrPtNm6kD+NhukNrU5ft22hLkFdSXdnYDr7O8ZRJkSlA715V2MmEWa+eFEgS+d9LU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596952090879.9782356184782; Mon, 24 Feb 2020 18:15:52 -0800 (PST) Received: from localhost ([::1]:47774 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PlH-0000oH-1y for importer@patchew.org; Mon, 24 Feb 2020 21:15:51 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38517) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgP-0006us-Fy for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgO-00088u-0l for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:49 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:59816 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007vr-0q; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id AF84BE1648301EFB36CC; Tue, 25 Feb 2020 10:10:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:28 +0800 From: To: , Subject: [PATCH 01/13] block/stream: Remove redundant statement in stream_run() Date: Tue, 25 Feb 2020 10:09:25 +0800 Message-ID: <20200225020937.25028-2-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Max Reitz , Chen Qun , John Snow Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/stream.c:186:9: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: John Snow --- Cc: John Snow Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org --- block/stream.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/stream.c b/block/stream.c index 5562ccbf57..d78074ac80 100644 --- a/block/stream.c +++ b/block/stream.c @@ -183,7 +183,6 @@ static int coroutine_fn stream_run(Job *job, Error **er= rp) break; } } - ret =3D 0; =20 /* Publish progress */ job_progress_update(&s->common.job, n); --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582597052; cv=none; d=zohomail.com; s=zohoarc; b=PPBO35HdsV9MU/gI/rymGEtiyDuM/wwO4V5O4SKu/yFUPSNzpA91J0ICRcCgm0INtiX7f0uWnWUQl8bP91LZ2MQaYsOKt/KdFmaRCmMOyfyTxd167cIVNxWDO2Nbz351mKG6XM2OSKDgWGD++fmkO2AGmMbF6oBHwwQtcUO6NDU= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582597052; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=yongWDqyiPrjUnQTFepbgSVwD206Y90nSr3Iyt6P2xc=; b=CBzyRvVMa8jyxQ+0v3wLjtBl2IqVZ+HdHbsKIuEGEy4eSnNLb21F3wKWN4oHbH4LmScqdv2aV/G3Pt0LeWCXH5bqSQD7Frn/rM9QwgiSt2OKJgyyYWYYNnR39Xqfl6NjLqWp4NpJl/miSGhnqiJxjHfNoptwrLPUTF1G8J7zgFg= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 15825970523652.1964571858281943; Mon, 24 Feb 2020 18:17:32 -0800 (PST) Received: from localhost ([::1]:47804 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Pms-0002rK-FE for importer@patchew.org; Mon, 24 Feb 2020 21:17:30 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38478) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgO-0006ty-Sf for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:51 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgN-00087z-N7 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:48 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:59808 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007vp-0r; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A122E5CC1DCBE591F729; Tue, 25 Feb 2020 10:10:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:29 +0800 From: To: , Subject: [PATCH 02/13] block/iscsi:Remove redundant statement in iscsi_open() Date: Tue, 25 Feb 2020 10:09:26 +0800 Message-ID: <20200225020937.25028-3-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Peter Lieven , Max Reitz , Ronnie Sahlberg , Chen Qun , Paolo Bonzini Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/iscsi.c:1920:9: warning: Value stored to 'flags' is never read flags &=3D ~BDRV_O_RDWR; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Ronnie Sahlberg Cc: Paolo Bonzini Cc: Peter Lieven Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org --- block/iscsi.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/iscsi.c b/block/iscsi.c index 682abd8e09..ed88479ede 100644 --- a/block/iscsi.c +++ b/block/iscsi.c @@ -1917,7 +1917,6 @@ static int iscsi_open(BlockDriverState *bs, QDict *op= tions, int flags, if (ret < 0) { goto out; } - flags &=3D ~BDRV_O_RDWR; } =20 iscsi_readcapacity_sync(iscsilun, &local_err); --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596733; cv=none; d=zohomail.com; s=zohoarc; b=POf6e9VbdgeoMOsiVGlelaCTPJ0R2OEfH4NlTKeSOc5gVxTp0/FZLRat/le0OjRFLNux5bEp/kOgdA2dWiATWH71+yRQfblPV8q2lIFX/76fdknAhnjnxqV3cJzlicfWaiUvi8Lk4dtoonhrnxcdh0Kl0DVXStsxQFgteSHUGxs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596733; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=dHNrIMAS6jL8WL0ztPPhq+DbhA+71eFkB5iG9qi7yCs=; b=P9ldrV/xcqIsHQ1XOYtv3XozAvNxneXTUFakEet08ZE6kV4kJSzIoU483hbE2tg0AAm2qksw02FNtuns+RM0M+DCMfNoWyagpuC4mDTGvunrVtHz+iOof2NSkCqNrhq9AEdPazVex8yExLlcEMXPXXEwejHPNHEkZr00xvrm9Jk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596733128881.1205895296446; Mon, 24 Feb 2020 18:12:13 -0800 (PST) Received: from localhost ([::1]:47684 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Phj-0000jz-Sw for importer@patchew.org; Mon, 24 Feb 2020 21:12:11 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38477) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgO-0006ts-Rz for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgN-00088H-Oj for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:48 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:59806 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007vn-0o; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 98AC6616BF2A3398F797; Tue, 25 Feb 2020 10:10:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:30 +0800 From: To: , Subject: [PATCH 03/13] block/file-posix: Remove redundant statement in raw_handle_perm_lock() Date: Tue, 25 Feb 2020 10:09:27 +0800 Message-ID: <20200225020937.25028-4-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Kevin Wolf , peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, qemu-block@nongnu.org, Max Reitz , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: block/file-posix.c:891:9: warning: Value stored to 'op' is never read op =3D RAW_PL_ABORT; ^ ~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Kevin Wolf Cc: Max Reitz Cc: qemu-block@nongnu.org --- block/file-posix.c | 1 - 1 file changed, 1 deletion(-) diff --git a/block/file-posix.c b/block/file-posix.c index 6345477112..0f77447a25 100644 --- a/block/file-posix.c +++ b/block/file-posix.c @@ -888,7 +888,6 @@ static int raw_handle_perm_lock(BlockDriverState *bs, "Is another process using the image [%s]?\n", bs->filename); } - op =3D RAW_PL_ABORT; /* fall through to unlock bytes. */ case RAW_PL_ABORT: raw_apply_lock_bytes(s, s->fd, s->perm, ~s->shared_perm, --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596741; cv=none; d=zohomail.com; s=zohoarc; b=Vj0zU5URqEYNgkMi0iKiybVaRrhWBn4luJMmgUIVrfKF2DcUKaWFcnbufaXBHYhAivdltw7c0zHTnyqdF6kW7aWcKP30/gFaIiPIS2O/wpH4TjF7/+Ve8nJEp59ZJTor1D3kYMjx1TFg07VJbYoVBdVJD+pXWCVFp81YqltXIys= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596741; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XCNhvLGHC1HLFQruWDKACFDsHt8+Cjn6sf1bGr47jOU=; b=D89P4qwVtRbLFVqKQo4f/7fSwd+LtZEmqFEMmxRhdQQVlz2lDjfWouOeY6B1P7KAoFCELjDmouoPF7rmb1xsW8WGcq05R32I31qsELqQqzFR3DFgD0ZhuXKue8vCod65uzXii5v/uuwVxTZhpob19ZJJ/2CAwtVlKuxZR/P/apw= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596741726763.8351458610443; Mon, 24 Feb 2020 18:12:21 -0800 (PST) Received: from localhost ([::1]:47688 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Phs-00015r-GD for importer@patchew.org; Mon, 24 Feb 2020 21:12:20 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38393) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgN-0006rF-CU for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgL-00084J-E7 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:47 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:59814 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007vq-0W; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A8DD541B76545289C6E1; Tue, 25 Feb 2020 10:10:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:30 +0800 From: To: , Subject: [PATCH 04/13] scsi/esp-pci: Remove redundant statement in esp_pci_io_write() Date: Tue, 25 Feb 2020 10:09:28 +0800 Message-ID: <20200225020937.25028-5-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, Paolo Bonzini , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/scsi/esp-pci.c:198:9: warning: Value stored to 'size' is never read size =3D 4; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/esp-pci.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/esp-pci.c b/hw/scsi/esp-pci.c index d5a1f9e017..2e6cc07d4e 100644 --- a/hw/scsi/esp-pci.c +++ b/hw/scsi/esp-pci.c @@ -195,7 +195,6 @@ static void esp_pci_io_write(void *opaque, hwaddr addr, val <<=3D shift; val |=3D current & ~(mask << shift); addr &=3D ~3; - size =3D 4; } =20 if (addr < 0x40) { --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596993; cv=none; d=zohomail.com; s=zohoarc; b=AsuQRPl6TNr4WJEOIMuCdiY13wzbIfcs7h/Ejn6yzhhAoqJyeeG2+PeTlGVVMyP6KjeOMmevcto/tqvCoqZnKogUKTqU5M13E6GAtbcpr0t/prH+YlENDsxgbjEE0PdEWrvB/isXbBCujtm8J/KlrYRl6jAlaVUk8FyIOsXlIIY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596993; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=bFo9xxlz3O8xJtM/4m3MRTx6bpKd/OENxeoM+FV0ckk=; b=UPePQ6UfxMig7df3CsLKBF8vbIrJbngfWyDNNafPtqYfjkajHqAdh2vOZqFjzlpk3DxHFhicsLE0N578lmDvUy8Yez8VYRlJHtk9gmX+Cxao2K85LSK5pUqO0BLcZDgKUVZvk0wjq9dKx9Yl6i47+6myPryFhXzJam6lkSwuBto= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596993350101.13123848052783; Mon, 24 Feb 2020 18:16:33 -0800 (PST) Received: from localhost ([::1]:47795 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Plw-0001sG-Aq for importer@patchew.org; Mon, 24 Feb 2020 21:16:32 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38501) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgP-0006uI-3y for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgN-00088M-PN for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:49 -0500 Received: from szxga07-in.huawei.com ([45.249.212.35]:59894 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgN-00085G-Cv; Mon, 24 Feb 2020 21:10:47 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id B9A09D269BD14660E0AF; Tue, 25 Feb 2020 10:10:37 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:31 +0800 From: To: , Subject: [PATCH 05/13] scsi/scsi-disk: Remove redundant statement in scsi_disk_emulate_command() Date: Tue, 25 Feb 2020 10:09:29 +0800 Message-ID: <20200225020937.25028-6-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.35 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Fam Zheng , peter.maydell@linaro.org, Paolo Bonzini , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: scsi/scsi-disk.c:1918:5: warning: Value stored to 'buflen' is never read buflen =3D req->cmd.xfer; ^ ~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Paolo Bonzini Cc: Fam Zheng --- hw/scsi/scsi-disk.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/scsi/scsi-disk.c b/hw/scsi/scsi-disk.c index 10d0794d60..1c0cb63a6f 100644 --- a/hw/scsi/scsi-disk.c +++ b/hw/scsi/scsi-disk.c @@ -1915,7 +1915,6 @@ static int32_t scsi_disk_emulate_command(SCSIRequest = *req, uint8_t *buf) r->iov.iov_base =3D blk_blockalign(s->qdev.conf.blk, r->buflen); } =20 - buflen =3D req->cmd.xfer; outbuf =3D r->iov.iov_base; memset(outbuf, 0, r->buflen); switch (req->cmd.buf[0]) { --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596871; cv=none; d=zohomail.com; s=zohoarc; b=TojcgHP2v8ar/N2aUMe8JBfLsajkJBTI3eu+4KiENO+iFEbpmZONDZbxRNCHKAmvMEvxWY+f4iw77LX+zjgOA91N6IuUkzIZTo87HFPCdgIKK9zy/8obW14e6RlDMcPYQH4FIVz813mC7REdw1ZavLDQrjgXmkgrPqKufW85nU0= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596871; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=hUlP1Ku5rjk10Wkq2AkHSieKfliATebXXHgr0Ps3eeQ=; b=NZbn9d4qKWYvKZ7NXepg3nPV517SiLpQ5qIQDkS6pLbw0dXDsqvVWoEuy18xj01U8rT15+vi4Fc8Q5O/z27tSz5tTrfzG1agTv6xEij2qjDxb8QR9WaBxZfumYL1qgLW/DPvaV53FsgWXcY6Fo+JNBER31S8ZdQuNo9KCKE6MDA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596871048943.0359166848133; Mon, 24 Feb 2020 18:14:31 -0800 (PST) Received: from localhost ([::1]:47722 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Pjx-0005hm-Ty for importer@patchew.org; Mon, 24 Feb 2020 21:14:29 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38678) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgS-00071q-QF for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgQ-0008Cd-NF for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:52 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3249 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgN-00085x-Nz; Mon, 24 Feb 2020 21:10:48 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C8804C6C5159483D681F; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:32 +0800 From: To: , Subject: [PATCH 06/13] display/pxa2xx_lcd: Remove redundant statement in pxa2xx_palette_parse() Date: Tue, 25 Feb 2020 10:09:30 +0800 Message-ID: <20200225020937.25028-7-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/pxa2xx_lcd.c:596:9: warning: Value stored to 'format' is never r= ead format =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/display/pxa2xx_lcd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/pxa2xx_lcd.c b/hw/display/pxa2xx_lcd.c index 05f5f84671..464e93161a 100644 --- a/hw/display/pxa2xx_lcd.c +++ b/hw/display/pxa2xx_lcd.c @@ -593,7 +593,6 @@ static void pxa2xx_palette_parse(PXA2xxLCDState *s, int= ch, int bpp) n =3D 256; break; default: - format =3D 0; return; } =20 --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596837; cv=none; d=zohomail.com; s=zohoarc; b=L/4pnWLYwBjIxJ6D5wsaKUq+aMIvw3oN47oTsTQjxmj0BVM18giujV8K+BufZuaAd6As4ChwLiyOsroxT23Njq5Ln7IA2OOlfcpRNXzuzYM9qVLRgYE4LayyEMxu6i5zM/ZsgyjfiH7b1ijpFB7ayXDfgdSj7ysMxJM98emr7Bs= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596837; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=akYpCofzNjTDFlaIutoBzWFiJsDxzBGez9aVe7dASRw=; b=iFdf6XU4PyeWQtbxlgBmo7j+C1ZDOxS3bnuE+swV7ackNridAKSpRlLrr6QGmpbxVAWXo7OkdKXkfcnN+JXJEWydL5YybbxZtg5SWvbLCdd6P/vOG968Et2uM/pWgQz203eEuQMBX6MAp/z/l9iIDiUI/W3ZXX0M7OVRIikWV98= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596837104924.2392619981133; Mon, 24 Feb 2020 18:13:57 -0800 (PST) Received: from localhost ([::1]:47712 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PjP-00046r-SV for importer@patchew.org; Mon, 24 Feb 2020 21:13:55 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38544) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgP-0006vZ-SE for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgO-0008A2-Mr for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:49 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3246 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007zV-D8; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A2C5BDFDBD7D69E87A5D; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:32 +0800 From: To: , Subject: [PATCH 07/13] display/exynos4210_fimd: Remove redundant statement in exynos4210_fimd_update() Date: Tue, 25 Feb 2020 10:09:31 +0800 Message-ID: <20200225020937.25028-8-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, qemu-arm@nongnu.org, zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/exynos4210_fimd.c:1313:17: warning: Value stored to 'is_dirty' i= s never read is_dirty =3D false; Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/display/exynos4210_fimd.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/exynos4210_fimd.c b/hw/display/exynos4210_fimd.c index c1071ecd46..05d3265b76 100644 --- a/hw/display/exynos4210_fimd.c +++ b/hw/display/exynos4210_fimd.c @@ -1310,7 +1310,6 @@ static void exynos4210_fimd_update(void *opaque) } host_fb_addr +=3D inc_size; fb_line_addr +=3D inc_size; - is_dirty =3D false; } g_free(snap); blend =3D true; --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596919; cv=none; d=zohomail.com; s=zohoarc; b=XDBhk1beJ3AFV/39lY9zwRAGFFw1I3AT5zYyLjZucwAB7inoW60772EJgtZRg2fkw5WSdGrBmpBH+GuRC+hbb3WxsuHk4QRYJoQIHyzp/RZDguRrwIlE4p4VyCO1nd3JHN0+ctgE0BiGiYT5udkYdxoagmkxNu4jDx/SO8GrHUY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596919; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=VGpWTy1nVE03RBlNsZmXs0G+qd8dC/0oORZ5FV5gpJ8=; b=LzOKdY/9cKE5UofG+Ms8sZUN7I7zac5akOEoCLgceSTmJThi9iwb3fFOiz0hYOucX7Tj+NEKzRUb1xq8QOmq64QkrKBQ9u4U4v5VIkJWZQZQUg3LXfRshzSKMGHWJfb3vo3mHsc+YXJ4C9B1fUdxu1SmkFUso1LDGTlhjj+MgmA= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596919008415.1370764554829; Mon, 24 Feb 2020 18:15:19 -0800 (PST) Received: from localhost ([::1]:47746 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Pkh-0007pP-Sw for importer@patchew.org; Mon, 24 Feb 2020 21:15:15 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38495) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgP-0006uF-3G for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:50 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgN-00088g-U7 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:48 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3243 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007zR-Bp; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 951B57892CD99F11857F; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:33 +0800 From: To: , Subject: [PATCH 08/13] display/blizzard: Remove redundant statement in blizzard_draw_line16_32() Date: Tue, 25 Feb 2020 10:09:32 +0800 Message-ID: <20200225020937.25028-9-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/display/blizzard.c:940:9: warning: Value stored to 'data' is never read data >>=3D 5; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Andrzej Zaborowski Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/display/blizzard.c | 1 - 1 file changed, 1 deletion(-) diff --git a/hw/display/blizzard.c b/hw/display/blizzard.c index 359e399c2a..62517bdf75 100644 --- a/hw/display/blizzard.c +++ b/hw/display/blizzard.c @@ -937,7 +937,6 @@ static void blizzard_draw_line16_32(uint32_t *dest, g =3D (data & 0x3f) << 2; data >>=3D 6; r =3D (data & 0x1f) << 3; - data >>=3D 5; *dest++ =3D rgb_to_pixel32(r, g, b); } } --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596906; cv=none; d=zohomail.com; s=zohoarc; b=QGSO22tkbIeDj6yIiqkrny2c669swrh7wRvkAps+Ro5e6QcjO6fspwFsORPWWQqzqeb9MOvrz0Mx/nv36kjNwci1eEijOC376S/Jb+d5BiCorUwZ78g4WLJL5VbCdaXRrkhw1oq1WbA0C00v90ywHZLYyC+E6GuxvNx+KM1H26o= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596906; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=wRhkDY3Z+604E1/cXrtUCBuLtTDYv6Kq4isvMfufdS8=; b=dozQN/b1hhgu8OQQU1cUXBUnJdOOTO71jaAgMaYYMv7MnD48GW8zZ08ylMQhGKYFedj4YcqiIviEAWXoDB0pu7FpunhhfbeSnQ/bTsTp2FT1e6gILqUqdq86+mvZyprzfpHOmZRhNGsdYUlFHAJxRBS+nncETt/kYUUZq7KxfKs= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596906921798.9966715905131; Mon, 24 Feb 2020 18:15:06 -0800 (PST) Received: from localhost ([::1]:47736 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PkX-0007OC-Jv for importer@patchew.org; Mon, 24 Feb 2020 21:15:05 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38685) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgS-00072T-VD for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgQ-0008D5-Ts for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:52 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3248 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgN-00085t-N9; Mon, 24 Feb 2020 21:10:48 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id C36695B1E644EC59BFDE; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:33 +0800 From: To: , Subject: [PATCH 09/13] dma/xlnx-zdma: Remove redundant statement in zdma_write_dst() Date: Tue, 25 Feb 2020 10:09:33 +0800 Message-ID: <20200225020937.25028-10-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, Alistair Francis , qemu-arm@nongnu.org, Chen Qun , "Edgar E. Iglesias" Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/dma/xlnx-zdma.c:399:13: warning: Value stored to 'dst_type' is never read dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_W= ORD3, ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~= ~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Alistair Francis Cc: "Edgar E. Iglesias" Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/dma/xlnx-zdma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/hw/dma/xlnx-zdma.c b/hw/dma/xlnx-zdma.c index 8fb83f5b07..45355c5d59 100644 --- a/hw/dma/xlnx-zdma.c +++ b/hw/dma/xlnx-zdma.c @@ -396,8 +396,6 @@ static void zdma_write_dst(XlnxZDMA *s, uint8_t *buf, u= int32_t len) zdma_load_descriptor(s, next, &s->dsc_dst); dst_size =3D FIELD_EX32(s->dsc_dst.words[2], ZDMA_CH_DST_DSCR_= WORD2, SIZE); - dst_type =3D FIELD_EX32(s->dsc_dst.words[3], ZDMA_CH_DST_DSCR_= WORD3, - TYPE); } =20 /* Match what hardware does by ignoring the dst_size and only using --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596781; cv=none; d=zohomail.com; s=zohoarc; b=XJhAwW0o1Lsvrzb+C7zjBnbqSnt6TbkEcg/PW/hcigjW2stjGW+8lTTlm1xipbKEURYdpg9jWtcHlfi2LwC7hx4NbGRozkwRcgDlterk9O7iu4JrdSCAd/9FMoKlLxVJjoE3U7VPl0uSiKbzOqx9btwfYXU4H+bNskHTGRvuEuA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596781; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=xx+yVFCSvCbUQ9i5cn8CkXW31aLPwxELM3C/Of0/DaQ=; b=CXsYMNweOj7E+S2o6Kctx+c/RD/W3dqnbAPZVwoP7OEBkJwJj9QUu7WfTLD4kW8hsUSBE75HzLVaeCFIFl8ARXMFHQHCbnf9APvVM+BeDPLYihPBjTlFxZL9iQsIKE93RdFmwz7vIdY9MFG+ImdYjKRFtB4Y7BqFUDcvwiGgRHI= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596781364556.233666056223; Mon, 24 Feb 2020 18:13:01 -0800 (PST) Received: from localhost ([::1]:47698 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PiW-0002Sv-8S for importer@patchew.org; Mon, 24 Feb 2020 21:13:00 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38367) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgM-0006qk-TF for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgL-00084i-Mt for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:46 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3244 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007zT-AK; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 99A35544E8D56BA7C4C5; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:34 +0800 From: To: , Subject: [PATCH 10/13] migration/vmstate: Remove redundant statement in vmstate_save_state_v() Date: Tue, 25 Feb 2020 10:09:34 +0800 Message-ID: <20200225020937.25028-11-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Juan Quintela , zhang.zhanghailiang@huawei.com, "Dr. David Alan Gilbert" , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun The "ret" has been assigned in all branches. It didn't need to be assigned separately. Clang static code analyzer show warning: migration/vmstate.c:365:17: warning: Value stored to 'ret' is never read ret =3D 0; ^ ~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Juan Quintela Cc: "Dr. David Alan Gilbert" --- migration/vmstate.c | 1 - 1 file changed, 1 deletion(-) diff --git a/migration/vmstate.c b/migration/vmstate.c index 7dd8ef66c6..bafa890384 100644 --- a/migration/vmstate.c +++ b/migration/vmstate.c @@ -362,7 +362,6 @@ int vmstate_save_state_v(QEMUFile *f, const VMStateDesc= ription *vmsd, } for (i =3D 0; i < n_elems; i++) { void *curr_elem =3D first_elem + size * i; - ret =3D 0; =20 vmsd_desc_field_start(vmsd, vmdesc_loop, field, i, n_elems= ); old_offset =3D qemu_ftell_fast(f); --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582597187; cv=none; d=zohomail.com; s=zohoarc; b=doplw1YnbqU1yE2eMwYs8bpSADUeGhNoPXKMtG8t9TmOrYn1dcxzd50iSfNqZ8rauWLTuKWX6yQieF/rBR269VlbKxKI/e5BCTo7D0IFWvOKlwgdEsGnzmLAJXrf5ReJoAcrPBCX+4AB451K+lcX2NrbA3EQjHm9tC0frcNLKsA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582597187; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=Qjpy8gIjoURlxpcsZ1LlPw0NUn5Aq1bz8LxFKykFaVM=; b=aEaqaXRQ4tYlnAxXwuuiijy2L/0v9tenyG6uWK1u4vEVKGOm1BAMTfrnKR5iY5nDhvBJjpv4VnZYXgXsLub7e0Jrsqy8p2Nvh8UfALjJtB+t7B9OG08sW7yY7j343FNYUUxr882qPAozpNUsLh3ZcTjqIrS+K3XANl6OTIB2HpU= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582597187191133.34158978644552; Mon, 24 Feb 2020 18:19:47 -0800 (PST) Received: from localhost ([::1]:47830 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Pp4-0004mM-5R for importer@patchew.org; Mon, 24 Feb 2020 21:19:46 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38650) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgR-0006zb-W1 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:53 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgQ-0008D1-Tn for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:51 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3247 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgN-00085s-KB; Mon, 24 Feb 2020 21:10:47 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id A78BD7B223F2D41E97D7; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:34 +0800 From: To: , Subject: [PATCH 11/13] timer/exynos4210_mct: Remove redundant statement in exynos4210_mct_write() Date: Tue, 25 Feb 2020 10:09:35 +0800 Message-ID: <20200225020937.25028-12-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Igor Mitsyanko , peter.maydell@linaro.org, qemu-arm@nongnu.org, zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: hw/timer/exynos4210_mct.c:1370:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1399:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ hw/timer/exynos4210_mct.c:1441:9: warning: Value stored to 'index' is never= read index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); ^ ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: Igor Mitsyanko Cc: Peter Maydell Cc: qemu-arm@nongnu.org --- hw/timer/exynos4210_mct.c | 4 ---- 1 file changed, 4 deletions(-) diff --git a/hw/timer/exynos4210_mct.c b/hw/timer/exynos4210_mct.c index 944120aea5..570cf7075b 100644 --- a/hw/timer/exynos4210_mct.c +++ b/hw/timer/exynos4210_mct.c @@ -1367,7 +1367,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_TCNTB: case L1_TCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 /* * TCNTB is updated to internal register only after CNT expired. @@ -1396,7 +1395,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_ICNTB: case L1_ICNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_ICNTB_WRITE; s->l_timer[lt_i].reg.cnt[L_REG_CNT_ICNTB] =3D value & @@ -1438,8 +1436,6 @@ static void exynos4210_mct_write(void *opaque, hwaddr= offset, =20 case L0_FRCNTB: case L1_FRCNTB: lt_i =3D GET_L_TIMER_IDX(offset); - index =3D GET_L_TIMER_CNT_REG_IDX(offset, lt_i); - DPRINTF("local timer[%d] FRCNTB write %llx\n", lt_i, value); =20 s->l_timer[lt_i].reg.wstat |=3D L_WSTAT_FRCCNTB_WRITE; --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596842; cv=none; d=zohomail.com; s=zohoarc; b=d4oRSlHyP+FCSGvLoBp99cefO476P2lUQjXidnPoIZYpFiWMv1XiaV6V4TPiDV86rdRdhiRIo5O59Mu81sVPw7EkK96cOXE4z1Xr0B/WsyBKa9jetndcmdkFrQv4LuF296flfkpEPHu+2YPTlFBM2fCLIYkbbDItMYrW4Ji0G98= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596842; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=ZibuON2Rbduk+fK5EpVw+dCjBZDubNaJzWhWCOxM1Ck=; b=cXjwFcSVVlNiURVw1hjM+n9Z+BP8kK1hP+NWyNnhDjAJtoDvHozP2wmIr9Q+qHWeaTcyAkH7+o/cqWg3LyABjI/zLZeNcP0vnUloG0Ew3EjEzc0voDZd2cc03SzSG7TBqbqXmvwBW0hI4LbNM3TZpCINmJpkCeHUAKEBWKptyGc= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596842500160.80714977190655; Mon, 24 Feb 2020 18:14:02 -0800 (PST) Received: from localhost ([::1]:47720 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PjV-0004Sp-ED for importer@patchew.org; Mon, 24 Feb 2020 21:14:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38409) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgN-0006rR-Gr for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:48 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgL-00085A-RB for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:47 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3242 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007zQ-D6; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9018B2E2D7E06BA90EA8; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:35 +0800 From: To: , Subject: [PATCH 12/13] usb/hcd-ehci: Remove redundant statements Date: Tue, 25 Feb 2020 10:09:36 +0800 Message-ID: <20200225020937.25028-13-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, Gerd Hoffmann , zhang.zhanghailiang@huawei.com, Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun The "again" assignment is meaningless before g_assert_not_reached. In addition, the break statements no longer needs to be after g_assert_not_reached. Clang static code analyzer show warning: hw/usb/hcd-ehci.c:2108:13: warning: Value stored to 'again' is never read again =3D -1; ^ ~~ Reported-by: Euler Robot Signed-off-by: Chen Qun Reviewed-by: Philippe Mathieu-Daud=C3=A9 --- Cc: Gerd Hoffmann --- hw/usb/hcd-ehci.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/hw/usb/hcd-ehci.c b/hw/usb/hcd-ehci.c index 56ab2f457f..29d49c2d7e 100644 --- a/hw/usb/hcd-ehci.c +++ b/hw/usb/hcd-ehci.c @@ -1301,7 +1301,6 @@ static void ehci_execute_complete(EHCIQueue *q) /* should not be triggerable */ fprintf(stderr, "USB invalid response %d\n", p->packet.status); g_assert_not_reached(); - break; } =20 /* TODO check 4.12 for splits */ @@ -2105,9 +2104,7 @@ static void ehci_advance_state(EHCIState *ehci, int a= sync) =20 default: fprintf(stderr, "Bad state!\n"); - again =3D -1; g_assert_not_reached(); - break; } =20 if (again < 0 || itd_count > 16) { --=20 2.23.0 From nobody Thu Nov 13 19:25:44 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582596875; cv=none; d=zohomail.com; s=zohoarc; b=ApKdPpF4eH4xYSwmcGtPwqHEh4ch2NoKb0Ka+R6F2V/1O9OGNt+haF3TPeEfQ6OM8Tcyi2tlSARtyAd7eYLMA/PkvOwbIZqv2HDv2Z/rO4gSzKMudr9IynU47u2Zm2ytS1aj+SJZfLVsHzXFtBxCFwnMZ1p34wHhKiGUeSfrORw= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582596875; h=Content-Type:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XSVQVx/sIOZ1OCq+G4GXRHKsCH2Lr0gxUGs/EmpY6WE=; b=E7PmuCBkgGT8Y50Dk6oMRPO+sboijj3hMhl2a1efFHTWRWZn5x++Sm7evOLH0hqdjEbD/o/0KxPMu3IkosN2Q205pNHWS/4mO3RhP3UdBSCr0XNBJ2Opo6jY0zeZ/Riic7RDWmi8cviy+lzFJWta3F1EZAziqaQ1fkeaVOa5aXk= ARC-Authentication-Results: i=1; mx.zohomail.com; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582596875918377.7076192024433; Mon, 24 Feb 2020 18:14:35 -0800 (PST) Received: from localhost ([::1]:47728 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Pk2-0005v0-Le for importer@patchew.org; Mon, 24 Feb 2020 21:14:34 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:38375) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6PgN-0006qr-0B for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:47 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6PgL-00084z-QQ for qemu-devel@nongnu.org; Mon, 24 Feb 2020 21:10:46 -0500 Received: from szxga05-in.huawei.com ([45.249.212.191]:3245 helo=huawei.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6PgL-0007zU-CX; Mon, 24 Feb 2020 21:10:45 -0500 Received: from DGGEMS412-HUB.china.huawei.com (unknown [172.30.72.60]) by Forcepoint Email with ESMTP id 9E7248434096C9F3081A; Tue, 25 Feb 2020 10:10:42 +0800 (CST) Received: from huawei.com (10.133.205.93) by DGGEMS412-HUB.china.huawei.com (10.3.19.212) with Microsoft SMTP Server id 14.3.439.0; Tue, 25 Feb 2020 10:10:35 +0800 From: To: , Subject: [PATCH 13/13] monitor/hmp-cmds: Remove redundant statement in hmp_rocker_of_dpa_groups() Date: Tue, 25 Feb 2020 10:09:37 +0800 Message-ID: <20200225020937.25028-14-kuhn.chenqun@huawei.com> X-Mailer: git-send-email 2.14.1.windows.1 In-Reply-To: <20200225020937.25028-1-kuhn.chenqun@huawei.com> References: <20200225020937.25028-1-kuhn.chenqun@huawei.com> MIME-Version: 1.0 X-Originating-IP: [10.133.205.93] X-CFilter-Loop: Reflected X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 45.249.212.191 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, zhang.zhanghailiang@huawei.com, "Dr. David Alan Gilbert" , Chen Qun Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="utf-8" From: Chen Qun Clang static code analyzer show warning: monitor/hmp-cmds.c:2867:17: warning: Value stored to 'set' is never read set =3D true; ^ ~~~~ Reported-by: Euler Robot Signed-off-by: Chen Qun --- Cc: "Dr. David Alan Gilbert" --- monitor/hmp-cmds.c | 1 - 1 file changed, 1 deletion(-) diff --git a/monitor/hmp-cmds.c b/monitor/hmp-cmds.c index 53bc3f76c4..84f94647cd 100644 --- a/monitor/hmp-cmds.c +++ b/monitor/hmp-cmds.c @@ -2864,7 +2864,6 @@ void hmp_rocker_of_dpa_groups(Monitor *mon, const QDi= ct *qdict) =20 if (group->has_set_eth_dst) { if (!set) { - set =3D true; monitor_printf(mon, " set"); } monitor_printf(mon, " dst %s", group->set_eth_dst); --=20 2.23.0