From nobody Thu Nov 13 20:41:59 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org ARC-Seal: i=1; a=rsa-sha256; t=1582587664; cv=none; d=zohomail.com; s=zohoarc; b=XL/XAAZyIU4oo+3AFaDUDusxOrH3N/MACagUxHNDuMrshUwINZGAoMrstwYsytAaiy3JC8oso5P0GSgXZqf03xU1xUHZaCYf9+WcJdnISy/kj5DCXu81cq+Grmf1OYlGJnsIB51Vx2RRKM0bc1IeCxg4Pr4OKVblYR+Gzvxcmjg= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582587664; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=nWs207me3GjX4NPzhGSmVSX+MaxNI8OYJBDI3WTCZ10=; b=XySXt+AMe9zWYMJQFejirl5guNQrWB0+ickUTwNsB7jmX7YTakIpi3yKpjDlGQj6zNrmfRgQ+dlI10h2gGLgz/EcNKcELxFc9BP9EVxeAZnbnDl4Haz0mSb3fm5p3stJ8k7KSCVJdFjsiixC/dj1ropvYuQiNtLsSp6sDUgkpiU= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582587664974148.70697833279792; Mon, 24 Feb 2020 15:41:04 -0800 (PST) Received: from localhost ([::1]:46154 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6NLT-0004EX-OF for importer@patchew.org; Mon, 24 Feb 2020 18:41:03 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:47209) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6NIP-0006VX-86 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 18:37:54 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6NIO-000892-1P for qemu-devel@nongnu.org; Mon, 24 Feb 2020 18:37:53 -0500 Received: from ozlabs.org ([2401:3900:2:1::2]:38821) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6NIN-00083v-Mh; Mon, 24 Feb 2020 18:37:51 -0500 Received: by ozlabs.org (Postfix, from userid 1007) id 48RJQ42Yjgz9sSM; Tue, 25 Feb 2020 10:37:31 +1100 (AEDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gibson.dropbear.id.au; s=201602; t=1582587452; bh=/E6r6c1U/O72mbX+roOccD8oy03Pdofs/lMnmoRwM/s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=jyhHKcNjcjm4McK+vbaMJBjNoV9gyPZ+gU92OmjQ4fJM0C7EtYZiF42zVUyLCtlyH 3GBHzVUqlBpyWOBnrVn1MB2RCJ2yIuQ4iRIlOarM7+Bc1/vXUEWUKLBmo8d3dhZPmB XYwFFnCTFDRaX92I4A5/PrHkDQeMfYfqE8WLu5G8= From: David Gibson To: groug@kaod.org, qemu-ppc@nongnu.org, qemu-devel@nongnu.org, clg@kaod.org Subject: [PATCH v6 10/18] target/ppc: Correct RMLS table Date: Tue, 25 Feb 2020 10:37:16 +1100 Message-Id: <20200224233724.46415-11-david@gibson.dropbear.id.au> X-Mailer: git-send-email 2.24.1 In-Reply-To: <20200224233724.46415-1-david@gibson.dropbear.id.au> References: <20200224233724.46415-1-david@gibson.dropbear.id.au> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2401:3900:2:1::2 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: lvivier@redhat.com, Thomas Huth , Xiao Guangrong , "Michael S. Tsirkin" , aik@ozlabs.ru, farosas@linux.ibm.com, Mark Cave-Ayland , Igor Mammedov , paulus@samba.org, Paolo Bonzini , "Edgar E. Iglesias" , David Gibson Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" The table of RMA limits based on the LPCR[RMLS] field is slightly wrong. We're missing the RMLS =3D=3D 0 =3D> 256 GiB RMA option, which is available= on POWER8, so add that. The comment that goes with the table is much more wrong. We *don't* filter invalid RMLS values when writing the LPCR, and there's not really a sensible way to do so. Furthermore, while in theory the set of RMLS values is implementation dependent, it seems in practice the same set has been available since around POWER4+ up until POWER8, the last model which supports RMLS at all. So, correct that as well. Signed-off-by: David Gibson Reviewed-by: C=C3=A9dric Le Goater Reviewed-by: Greg Kurz --- target/ppc/mmu-hash64.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/target/ppc/mmu-hash64.c b/target/ppc/mmu-hash64.c index 4f082d775d..dd0df6fd01 100644 --- a/target/ppc/mmu-hash64.c +++ b/target/ppc/mmu-hash64.c @@ -762,12 +762,12 @@ static target_ulong rmls_limit(PowerPCCPU *cpu) { CPUPPCState *env =3D &cpu->env; /* - * This is the full 4 bits encoding of POWER8. Previous - * CPUs only support a subset of these but the filtering - * is done when writing LPCR + * In theory the meanings of RMLS values are implementation + * dependent. In practice, this seems to have been the set from + * POWER4+..POWER8, and RMLS is no longer supported in POWER9. */ const target_ulong rma_sizes[] =3D { - [0] =3D 0, + [0] =3D 256 * GiB, [1] =3D 16 * GiB, [2] =3D 1 * GiB, [3] =3D 64 * MiB, --=20 2.24.1