From nobody Thu Nov 13 20:40:39 2025 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582581122; cv=none; d=zohomail.com; s=zohoarc; b=DoRGh1vy0FfcuKsrBtcflVlOWiKo/oIS5/oHysxX9HSXrUkfWqNSlxXBqokOBgOO9RDlh9YCwjkSG7uZy/iMywy/p6xl9FKGJlDoUGqghQvDtG+1k6MWwv2qX0g+P8Vd9IP8isUe/YxsipwLEhi+fVJ5TFOcDowrEFM22GJ65TA= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582581122; h=Content-Type:Content-Transfer-Encoding:Cc:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=XVZvi/YHzEh7ylVqPr697ez8p22nG0yVmTeif46TOmw=; b=IVZCXB1o6t05qX+490Al6tAQ40q6t0mT89uf0hclFbBDEOFjK4Jr3X2cWjA6YvE2gzrn0ZC3gj8ldQkNPQIhJDex0GihaxX0XH+QrkxUUn4JnmtcKgEbsDXWTXrS5UBG5MtXjzLRAwXx8PbfKp5wrzk0x6gidxGWOVdpKjBet0Y= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=fail; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=fail header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582581122606359.7774451317256; Mon, 24 Feb 2020 13:52:02 -0800 (PST) Received: from localhost ([::1]:44576 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Ldx-0007mk-JK for importer@patchew.org; Mon, 24 Feb 2020 16:52:01 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:53792) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j6Ksa-0000sQ-NK for qemu-devel@nongnu.org; Mon, 24 Feb 2020 16:03:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j6KsZ-0008NL-J5 for qemu-devel@nongnu.org; Mon, 24 Feb 2020 16:03:04 -0500 Received: from us-smtp-1.mimecast.com ([207.211.31.81]:20204 helo=us-smtp-delivery-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j6KsZ-0008Mh-FK for qemu-devel@nongnu.org; Mon, 24 Feb 2020 16:03:03 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-473-v-AiIWesPt2X2quRXpPcbw-1; Mon, 24 Feb 2020 16:03:01 -0500 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id B9C21801E6C; Mon, 24 Feb 2020 21:02:56 +0000 (UTC) Received: from x1w.redhat.com (ovpn-205-162.brq.redhat.com [10.40.205.162]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 3CEBA5C21B; Mon, 24 Feb 2020 21:02:42 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582578183; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=XVZvi/YHzEh7ylVqPr697ez8p22nG0yVmTeif46TOmw=; b=LOcpmxI4gKqqhkmNheMcNGBzbQiq0OcfMlLyG8pBvi1JQpO2BflwkHfjzocD8+e4gV9LDb syXWrS2QFjOeqrvAqhHfOlYH7NO/FnP4zyXDudUH0KYpwXKSBzgIHapS++mudlV1QmteT9 WMyyDC4gPDf/qtX/RPnrowIQu2hXsAE= X-MC-Unique: v-AiIWesPt2X2quRXpPcbw-1 From: =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= To: qemu-devel@nongnu.org, Paolo Bonzini , Peter Maydell Subject: [RFC PATCH RESEND v2 31/32] hw/net/milkymist-minimac2: Let devices own the MemoryRegion they create Date: Mon, 24 Feb 2020 21:55:32 +0100 Message-Id: <20200224205533.23798-32-philmd@redhat.com> In-Reply-To: <20200224205533.23798-1-philmd@redhat.com> References: <20200224205533.23798-1-philmd@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.81 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Sagar Karandikar , "Michael S. Tsirkin" , Jason Wang , =?UTF-8?q?Philippe=20Mathieu-Daud=C3=A9?= , Mark Cave-Ayland , KONRAD Frederic , Alistair Francis , "Edgar E. Iglesias" , Subbaraya Sundeep , qemu-block@nongnu.org, Magnus Damm , =?UTF-8?q?Herv=C3=A9=20Poussineau?= , Joel Stanley , =?UTF-8?q?Marc-Andr=C3=A9=20Lureau?= , Aleksandar Rikalo , David Gibson , Artyom Tarasenko , Eduardo Habkost , Jean-Christophe Dubois , Alistair Francis , Fabien Chouteau , qemu-arm@nongnu.org, Peter Chubb , Palmer Dabbelt , Richard Henderson , Kevin Wolf , qemu-riscv@nongnu.org, Igor Mitsyanko , Bastian Koppelmann , Laurent Vivier , Max Reitz , Michael Walle , qemu-ppc@nongnu.org, Aleksandar Markovic , Aurelien Jarno Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: fail (Header signature does not verify) Content-Type: text/plain; charset="utf-8" Avoid orphan memory regions being added in the /unattached QOM container. Note this change break the migration of the LM32 milkymist machine. Signed-off-by: Philippe Mathieu-Daud=C3=A9 --- hw/net/milkymist-minimac2.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/hw/net/milkymist-minimac2.c b/hw/net/milkymist-minimac2.c index 1ba01754ee..9582b5f8a3 100644 --- a/hw/net/milkymist-minimac2.c +++ b/hw/net/milkymist-minimac2.c @@ -473,9 +473,9 @@ static void milkymist_minimac2_realize(DeviceState *dev= , Error **errp) sysbus_init_mmio(sbd, &s->regs_region); =20 /* register buffers memory */ - memory_region_init_ram_nomigrate(&s->buffers, OBJECT(dev), "milkymist-= minimac2.buffers", + memory_region_init_ram(&s->buffers, OBJECT(dev), + "milkymist-minimac2.buffers", buffers_size, &error_fatal); - vmstate_register_ram_global(&s->buffers); s->rx0_buf =3D memory_region_get_ram_ptr(&s->buffers); s->rx1_buf =3D s->rx0_buf + MINIMAC2_BUFFER_SIZE; s->tx_buf =3D s->rx1_buf + MINIMAC2_BUFFER_SIZE; @@ -506,8 +506,8 @@ static const VMStateDescription vmstate_milkymist_minim= ac2_mdio =3D { =20 static const VMStateDescription vmstate_milkymist_minimac2 =3D { .name =3D "milkymist-minimac2", - .version_id =3D 1, - .minimum_version_id =3D 1, + .version_id =3D 2, + .minimum_version_id =3D 2, .fields =3D (VMStateField[]) { VMSTATE_UINT32_ARRAY(regs, MilkymistMinimac2State, R_MAX), VMSTATE_UINT16_ARRAY(phy_regs, MilkymistMinimac2State, R_PHY_MAX), --=20 2.21.1