From nobody Mon Feb 9 05:41:05 2026 Delivered-To: importer@patchew.org Received-SPF: pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; envelope-from=qemu-devel-bounces+importer=patchew.org@nongnu.org; helo=lists.gnu.org; Authentication-Results: mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass(p=none dis=none) header.from=redhat.com ARC-Seal: i=1; a=rsa-sha256; t=1582292488; cv=none; d=zohomail.com; s=zohoarc; b=c2n1WWxwnHA0MPNAOEx+AZ0Jddy3rzl2bonaAfn53gJGAu5Yt1A9FDMs7WXbRIwfPiMcB2VfaEaHxfD9Mc7lBfj8KYUBvJGj7tDk38IYWenZMEE4NJ92gGSVEXTptM383Ep7RNdcZEH23ys6q14nbI4/NPX8bdgswRSy+wWeCoY= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1582292488; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:List-Subscribe:List-Post:List-Id:List-Archive:List-Help:List-Unsubscribe:MIME-Version:Message-ID:References:Sender:Subject:To; bh=uX9UesRfQ5VevuWklXMAkSBnSnsaUKk6WMwfeYmvayw=; b=PXdUoLvi8hxFsIVmpc3TKzbERKYRZFbd0kEYeGqU5ManK4RiYEpMPMq9CzTGLiO4kv33rNZbnXNnY9sqs2hjZ92ilvJRAwNPzu9NrUdKUbfjWzQ2fLzz9WE8TDrWbRj4SQaGt2hTkCe9JctrzU7QlEpThpgJIUZRR/eQEm7T3S0= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass; spf=pass (zohomail.com: domain of gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=qemu-devel-bounces+importer=patchew.org@nongnu.org; dmarc=pass header.from= (p=none dis=none) header.from= Return-Path: Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) by mx.zohomail.com with SMTPS id 1582292488437960.5844935203085; Fri, 21 Feb 2020 05:41:28 -0800 (PST) Received: from localhost ([::1]:58028 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j58YZ-0001XF-FK for importer@patchew.org; Fri, 21 Feb 2020 08:41:27 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]:32945) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1j58JV-0002rx-RM for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:25:56 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1j58JU-0007Ir-4b for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:25:53 -0500 Received: from us-smtp-delivery-1.mimecast.com ([207.211.31.120]:29573 helo=us-smtp-1.mimecast.com) by eggs.gnu.org with esmtps (TLS1.0:DHE_RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1j58JT-0007Hr-V3 for qemu-devel@nongnu.org; Fri, 21 Feb 2020 08:25:52 -0500 Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-431-eYrySuXtP06viUveA0SgSA-1; Fri, 21 Feb 2020 08:25:45 -0500 Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 67956107ACC5; Fri, 21 Feb 2020 13:25:44 +0000 (UTC) Received: from dgilbert-t580.localhost (unknown [10.36.118.1]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6135F84BCC; Fri, 21 Feb 2020 13:25:43 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1582291550; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=uX9UesRfQ5VevuWklXMAkSBnSnsaUKk6WMwfeYmvayw=; b=Gt8BQl0Gp1OOPAwTX4+NURk8CmYVJg/WTY11vQc7DzHMBYyU2tM/5g6YcZhkClN+XKVO4b elurKyWXVlCmzoaE9oIoIejdJFtb3ABgrUWsA6QDfBHVJZXxG027bAxWdD+/XvnfpPAVHb wjTvIoD4K7CllHisN96rYrlNGVxe/Qk= X-MC-Unique: eYrySuXtP06viUveA0SgSA-1 From: "Dr. David Alan Gilbert (git)" To: qemu-devel@nongnu.org, philmd@redhat.com, yangx.jy@cn.fujitsu.com, mrezanin@redhat.com Subject: [PULL 3/6] tools/virtiofsd/passthrough_ll: Remove unneeded variable assignment Date: Fri, 21 Feb 2020 13:25:33 +0000 Message-Id: <20200221132536.38364-4-dgilbert@redhat.com> In-Reply-To: <20200221132536.38364-1-dgilbert@redhat.com> References: <20200221132536.38364-1-dgilbert@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Transfer-Encoding: quoted-printable X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] [fuzzy] X-Received-From: 207.211.31.120 X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+importer=patchew.org@nongnu.org Sender: "Qemu-devel" X-ZohoMail-DKIM: pass (identity @redhat.com) Content-Type: text/plain; charset="utf-8" From: Philippe Mathieu-Daud=C3=A9 Fix warning reported by Clang static code analyzer: CC tools/virtiofsd/passthrough_ll.o tools/virtiofsd/passthrough_ll.c:925:9: warning: Value stored to 'newfd' = is never read newfd =3D -1; ^ ~~ tools/virtiofsd/passthrough_ll.c:942:9: warning: Value stored to 'newfd' = is never read newfd =3D -1; ^ ~~ Fixes: 7c6b66027 Reported-by: Clang Static Analyzer Signed-off-by: Philippe Mathieu-Daud=C3=A9 Reviewed-by: J=C3=A1n Tomko Signed-off-by: Dr. David Alan Gilbert --- tools/virtiofsd/passthrough_ll.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/tools/virtiofsd/passthrough_ll.c b/tools/virtiofsd/passthrough= _ll.c index e9e71d5fc2..02ff01fad0 100644 --- a/tools/virtiofsd/passthrough_ll.c +++ b/tools/virtiofsd/passthrough_ll.c @@ -922,7 +922,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t pare= nt, const char *name, inode =3D lo_find(lo, &e->attr); if (inode) { close(newfd); - newfd =3D -1; } else { inode =3D calloc(1, sizeof(struct lo_inode)); if (!inode) { @@ -939,7 +938,6 @@ static int lo_do_lookup(fuse_req_t req, fuse_ino_t pare= nt, const char *name, =20 inode->nlookup =3D 1; inode->fd =3D newfd; - newfd =3D -1; inode->key.ino =3D e->attr.st_ino; inode->key.dev =3D e->attr.st_dev; pthread_mutex_init(&inode->plock_mutex, NULL); --=20 2.24.1